[hibernate-commits] [hibernate/hibernate-search] b5a98f: HSEARCH-3450 Remove the "lucene." prefix used in s...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: b5a98f8bfd723efab13c61f1289bff81f5d4026f https://github.com/hibernate/hibernate-search/commit/b5a98f8bfd723efab13c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-14 (Fri, 14 Dec 2018) Changed paths: M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/cfg/SearchBackendLuceneSettings.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M documentation/src/test/resources/META-INF/persistence.xml M documentation/src/test/resources/hibernate-test-lucene.properties M integrationtest/backend/lucene/src/test/resources/backend-tck-analysis-custom.properties M integrationtest/backend/lucene/src/test/resources/backend-tck-multi-tenancy.properties M integrationtest/backend/lucene/src/test/resources/backend-tck.properties Log Message: ----------- HSEARCH-3450 Remove the "lucene." prefix used in some configuration property keys Rationale: 1. Each backend has only one type, so there is no risk of having to use property keys from multiple backend types, which could result in naming conflicts. 2. There is no concept of defaults for backend properties that could introduce naming conflicts. I do not think introducing defaults would make sense, as I don't expect people to configure more than one backend most of the time. Regarding index properties (we don't have any at the moment), such naming conflicts could occur because of the default properties. However, I would personally be in favor of moving away from that concept and: 1. Introducing a "default backend name" property, e.g. hibernate.search.default_backend = myBackend hibernate.search.backends.myBackend.type = lucene 2. Allowing to configure default index properties on a per-backend basis, e.g. hibernate.search.backends.myBackend.index_defaults.someProperty = someValue Then there couldn't be naming conflicts for default index properties anymore. See https://hibernate.atlassian.net/browse/HSEARCH-3451 Commit: 6303fb6b9fb1e9132a31f4a4f79a53a2709833d9 https://github.com/hibernate/hibernate-search/commit/6303fb6b9fb1e9132a31... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-14 (Fri, 14 Dec 2018) Changed paths: M documentation/src/test/resources/META-INF/persistence.xml M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendFactory.java M engine/src/main/java/org/hibernate/search/engine/cfg/SearchEngineSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java M engine/src/test/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolderTest.java M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/util/rule/SearchSetupHelper.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/bootstrap/UnusedPropertiesIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/ManualIndexingIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/OrmElasticsearchLibraryShowcaseIT.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/MappingSetupHelper.java Log Message: ----------- HSEARCH-3451 Make the index defaults backend-scoped Commit: d66f845f0799ca81ca93d84309807c4b991e0e4f https://github.com/hibernate/hibernate-search/commit/d66f845f0799ca81ca93... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-14 (Fri, 14 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendFactory.java M engine/src/main/java/org/hibernate/search/engine/backend/spi/BackendImplementor.java A engine/src/main/java/org/hibernate/search/engine/cfg/SearchBackendCommonSettings.java M engine/src/main/java/org/hibernate/search/engine/cfg/SearchEngineSettings.java A engine/src/main/java/org/hibernate/search/engine/cfg/SearchIndexCommonSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java Log Message: ----------- HSEARCH-3451 Move all engine properties to constants Compare: https://github.com/hibernate/hibernate-search/compare/db471fdc60e4...d66f... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.