[hibernate-commits] [hibernate/hibernate-search] 9ebe57: HSEARCH-3349 Fix an obsolete Hibernate ORM caching...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 9ebe577defeb4bc2bfb3d808d564bac053236e7a https://github.com/hibernate/hibernate-search/commit/9ebe577defeb4bc2bfb3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/jdk/java-modules/src/main/resources/hibernate.properties M util/internal/integrationtest/orm/src/main/resources/hibernate.properties Log Message: ----------- HSEARCH-3349 Fix an obsolete Hibernate ORM caching configuration in integration tests The property had no effect whatsoever. Commit: 2c987cb8d91536f1bdf3d1bd19365a5335de7bdf https://github.com/hibernate/hibernate-search/commit/2c987cb8d91536f1bdf3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: A integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseBaseIT.java A integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseMassIndexingIT.java R integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/OrmLibraryShowcaseIT.java R integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/OrmManualIndexingIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/service/TestDataService.java Log Message: ----------- HSEARCH-3349 Rename integration tests in the showcase Commit: 2d812c2e6292ce507ac89c3bc7af2be1d193b372 https://github.com/hibernate/hibernate-search/commit/2d812c2e6292ce507ac8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseBaseIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/service/TestDataService.java Log Message: ----------- HSEARCH-3349 Move constants from LibraryShowcaseBaseIT to TestDataService Commit: 79814900b43301b65fcc5a3cf6d58bd41724cbb7 https://github.com/hibernate/hibernate-search/commit/79814900b43301b65fcc... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepository.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/service/DocumentService.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseMassIndexingIT.java Log Message: ----------- HSEARCH-3349 Count indexed documents instead of loading the whole database in LibraryShowcaseMassIndexingIT Commit: c9ae08fe7f949779d7b6e4c6c1d09c5244a23bc5 https://github.com/hibernate/hibernate-search/commit/c9ae08fe7f949779d7b6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseBaseIT.java Log Message: ----------- HSEARCH-3349 Remove an unused field from LibraryShowcaseBaseIT Commit: 4841ca58f3ecc482317fa3fd2519ae5b53b0142d https://github.com/hibernate/hibernate-search/commit/4841ca58f3ecc482317f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/VerifyingStubBackendBehavior.java Log Message: ----------- HSEARCH-3349 Move VerifyingStubBackendBehavior to its own file It's getting too big to just be an inner class. Commit: 05ca0e47ae559fe8299c81716c6ff1afe66cef93 https://github.com/hibernate/hibernate-search/commit/05ca0e47ae559fe8299c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/CountWorkCall.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/IndexScopeWorkCall.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/SearchWorkCall.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/VerifyingStubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/StubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexScope.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubIndexWorkExecutor.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/StubSearchQuery.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/impl/StubScopeModel.java Log Message: ----------- HSEARCH-3349 Do not expect any order for index names in the stub backend In some situations, such as when a query targets an abstract type, the order of index names passed to the backend is deterministic, but not easily predictable, because it depends on the execution order of some mapping operations at boot time. So it's easier to just ignore the order, which isn't very important anyway. Commit: 9411a098425342ba7b36bf14dddf3fd1a67d2c8c https://github.com/hibernate/hibernate-search/commit/9411a098425342ba7b36... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/BackendMock.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/CallQueue.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/VerifyingStubBackendBehavior.java Log Message: ----------- HSEARCH-3349 Add a way to temporarily allow unexpected operations on the backend mock (lenient mode) Commit: 43f0cf5a2ca8b7bb5f3a6275a58bb01fd24fbf70 https://github.com/hibernate/hibernate-search/commit/43f0cf5a2ca8b7bb5f3a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/AnnotationMappingSmokeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/ProgrammaticMappingSmokeIT.java Log Message: ----------- HSEARCH-3349 Fix invalid uses of Session.get in ORM integration tests These calls used to return null, which was consistent with Hibernate Search 6's behavior of returning null for non-existing entities. However, the test was clearly incorrect, as I had forgotten to persist the entities beforehand. Session.get is dangerous, we really should prefer getReference when possible. Commit: 5f7fc2e17c0f05ee027184bc53e19542737d1fc6 https://github.com/hibernate/hibernate-search/commit/5f7fc2e17c0f05ee0271... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: R integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/SearchQueryEntityLoadingIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/singletype/EntityIdDocumentIdIndexedEntity.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/singletype/NonEntityIdDocumentIdIndexedEntity.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/StubSearchWorkBehavior.java Log Message: ----------- HSEARCH-3349 Restructure single-type search query loading ITs in the ORM mapper ... so that we can easily add more tests for each entity type. Commit: c8f439a9da6c325ab5519406c80bb01a17ef1777 https://github.com/hibernate/hibernate-search/commit/c8f439a9da6c325ab551... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/SearchWorkCall.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/VerifyingStubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/StubBackendBehavior.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/index/impl/StubSearchQueryBuilderFactory.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/StubSearchQuery.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/StubSearchQueryBuilder.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeBiFunctionSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeFunctionSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeListSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubCompositeTriFunctionSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubDefaultSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubEntitySearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubFieldSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubReferenceSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionBuilderFactory.java A util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionContext.java Log Message: ----------- HSEARCH-3349 Use a dedicated class to represent projection context in the stub backend This will be useful in the next commits. Commit: 27491367d6ca7e0cc4f5125d606485aa0b782acc https://github.com/hibernate/hibernate-search/commit/27491367d6ca7e0cc4f5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/ElasticsearchEntityProjection.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/projection/impl/SearchProjectionTransformContext.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchLoadableSearchResult.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/LuceneEntityProjection.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/projection/impl/SearchProjectionTransformContext.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneLoadableSearchResult.java M engine/src/main/java/org/hibernate/search/engine/search/loading/spi/LoadingResult.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByTypeEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmSingleTypeCriteriaEntityLoader.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/rule/SearchWorkCall.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubEntitySearchProjection.java M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/projection/impl/StubSearchProjectionContext.java Log Message: ----------- HSEARCH-3349 Skip search hits when loading fails Commit: 09f00b614bbdcf35f5becac40cd1cccd20fa0560 https://github.com/hibernate/hibernate-search/commit/09f00b614bbdcf35f5be... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryResultLoadingOrTransformingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepository.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/repository/indexsearch/IndexSearchDocumentRepositoryImpl.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/service/DocumentService.java A integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/LibraryShowcaseOutOfSyncIndexIT.java M integrationtest/showcase/library/src/test/java/org/hibernate/search/integrationtest/showcase/library/service/TestDataService.java Log Message: ----------- HSEARCH-3349 Test that search query hits that cannot be loaded are skipped in the search result Commit: f90995dc66a40fe88b88147da68f1993e4016f19 https://github.com/hibernate/hibernate-search/commit/f90995dc66a40fe88b88... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy1_A_B.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy1_A_C.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy1_A__Abstract.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy2_A_B.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy2_A_C.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy2_A__NonAbstract_Indexed.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy3_A_B.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy3_A_C.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy3_A__NonAbstract_NonIndexed.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy4_A_B__integer1DocumentId.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy4_A_C__integer2DocumentId.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy4_A_D.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy4_A__NonAbstract_NonIndexed.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy5_A_B_C.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy5_A_B_D.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy5_A_B__MappedSuperClass.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy5_A__Abstract.java Log Message: ----------- HSEARCH-3349 Test multi-entity type loading more extensively Commit: 322544cfdc75d69a99819075f4e81a754a959f61 https://github.com/hibernate/hibernate-search/commit/322544cfdc75d69a9981... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoaderBuilder.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByTypeEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmComposableEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmLoadingIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmSingleTypeByIdEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmSingleTypeCriteriaEntityLoader.java Log Message: ----------- HSEARCH-3349 Remove an unnecessary generic type parameter in HibernateOrmComposableEntityLoader Commit: 30f93bc05d55a4f8832e6b5defd46b94c5618d05 https://github.com/hibernate/hibernate-search/commit/30f93bc05d55a4f8832e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmTypeContextContainer.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoaderBuilder.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoaderFactory.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByIdEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByTypeEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmComposableEntityLoader.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmCriteriaEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmLoadingIndexedTypeContext.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmSingleTypeByIdEntityLoader.java R mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmSingleTypeCriteriaEntityLoader.java Log Message: ----------- HSEARCH-3349 Optimize multi-entity type loading in search queries by loading multiple types in a single query Commit: 579715b62d65b455cd5e2065e416bc9c8cd86e7a https://github.com/hibernate/hibernate-search/commit/579715b62d65b455cd5e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/mapping/impl/JavaBeanIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmCriteriaEntityLoader.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIdentityMappingCollectorImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/spi/PojoIndexedTypeExtendedMappingCollector.java Log Message: ----------- HSEARCH-3349 Always execute a single statement when loading an entity whose document ID is not the entity ID The old code used to execute a first SQL statement to retrieve entity proxies, then additional statements to initialize the proxies. When no batch size was set, we could end up executing N + 1 queries. The new code apparently loads the entities directly as part of the first statement, so it should be better. We'll add tests in the next commits. Commit: 2438781003cf472379f04eb086692bbbe8987be2 https://github.com/hibernate/hibernate-search/commit/2438781003cf472379f0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java A util/internal/integrationtest/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/orm/OrmSoftAssertions.java Log Message: ----------- HSEARCH-3349 Test the number of SQL statements triggered by entity loading in search queries Commit: ec0263f36e800f33009ceb3bd63f584ed3051e40 https://github.com/hibernate/hibernate-search/commit/ec0263f36e800f33009c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmCriteriaEntityLoader.java Log Message: ----------- HSEARCH-3349 Fix HibernateOrmSingleTypeCriteriaEntityLoader when dealing with proxies Commit: 3c9e4d5dc0a68fad670445a63f69eaf81bc63e5c https://github.com/hibernate/hibernate-search/commit/3c9e4d5dc0a68fad6704... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java M util/internal/integrationtest/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/orm/OrmSoftAssertions.java Log Message: ----------- HSEARCH-3349 Test that entity loading always returns fully initialized entities Commit: 5deb16f61b7171a1d0cf1a147fd4314c6e0330d3 https://github.com/hibernate/hibernate-search/commit/5deb16f61b7171a1d0cf... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/scope/impl/SearchScopeImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/dsl/query/impl/HibernateOrmSearchQueryHitTypeStepImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/context/impl/HibernateOrmLoadingContext.java Log Message: ----------- HSEARCH-3349 Simplify Hibernate ORM loading context building Commit: b042791b6d9f6038d4f5ee6a1ad074ca16be758f https://github.com/hibernate/hibernate-search/commit/b042791b6d9f6038d4f5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByIdEntityLoader.java Log Message: ----------- HSEARCH-3349 Avoid unnecessary caching of the MultiAccess object in the ById entity loader It's just asking for trouble, since that object stores parameters that we could forget to reset. Commit: 380c64479a433d137e0dbe914e3a5605e24a3220 https://github.com/hibernate/hibernate-search/commit/380c64479a433d137e0d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmMapperSettings.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/dsl/query/HibernateOrmSearchQueryHitTypeStep.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/dsl/query/impl/HibernateOrmSearchQueryHitTypeStepImpl.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/EntityLoadingCacheLookupStrategy.java Log Message: ----------- HSEARCH-3349 Add APIs for configuring the cache lookup strategy in search queries Commit: a064999a85ad89bcd55db46a6fae87bb03a9df05 https://github.com/hibernate/hibernate-search/commit/a064999a85ad89bcd55d... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmIndexedTypeContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingPartialBuildState.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/scope/impl/HibernateOrmScopeMappingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/scope/impl/SearchScopeImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/dsl/query/impl/HibernateOrmSearchQueryHitTypeStepImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/context/impl/HibernateOrmLoadingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoaderBuilder.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoaderFactory.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/EntityLoadingCacheLookupStrategyImplementor.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByIdEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmComposableEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmCriteriaEntityLoader.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmLoadingMappingContext.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/PersistenceContextLookupStrategy.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/PersistenceContextThenSecondLevelCacheLookupStrategy.java Log Message: ----------- HSEARCH-3349 Restore support for preliminary cache lookups when loading entities in search queries Commit: 2a17403dde7b09753304df8ce9f15c1fdcf83cdc https://github.com/hibernate/hibernate-search/commit/2a17403dde7b09753304... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java Log Message: ----------- HSEARCH-3349 Add a parameter to customize loading options in AbstractSearchQueryEntityLoadingIT#testLoading Commit: 5430f43a6b01ab62ef7e2cf96cde774fc490abd4 https://github.com/hibernate/hibernate-search/commit/5430f43a6b01ab62ef7e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingBaseIT.java Log Message: ----------- HSEARCH-3349 Factorize some code into AbstractSearchQueryEntityLoadingSingleTypeIT Commit: 527c0608335a03d4a0287f3f2712f2afdaceb5ec https://github.com/hibernate/hibernate-search/commit/527c0608335a03d4a028... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingCacheLookupIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy6_A_B_Cacheable.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy6_A_C_Cacheable.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy6_A__Abstract.java M util/internal/integrationtest/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/orm/OrmSoftAssertions.java M util/internal/integrationtest/orm/src/main/java/org/hibernate/search/util/impl/integrationtest/orm/SimpleSessionFactoryBuilder.java Log Message: ----------- HSEARCH-3349 Test cache lookup strategies for entity loading Commit: 9c3b64ef5e73a849807e7bcf6965445edb734926 https://github.com/hibernate/hibernate-search/commit/9c3b64ef5e73a849807e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingPartialBuildState.java Log Message: ----------- HSEARCH-3349 Move mapping-level configuration property lookup to HibernateOrmMapping We're adding more and more options, so we may as well interpret them in the class that ends up exposing them to the rest of the application. Commit: 39d17f2f0361ced5f4a0d7f393c01e14f560a77c https://github.com/hibernate/hibernate-search/commit/39d17f2f0361ced5f4a0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmMapperSettings.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMapping.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/context/impl/HibernateOrmLoadingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByIdEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmCriteriaEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmLoadingMappingContext.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/MutableEntityLoadingOptions.java M util/common/src/main/java/org/hibernate/search/util/common/impl/Contracts.java M util/common/src/main/java/org/hibernate/search/util/common/logging/impl/Log.java Log Message: ----------- HSEARCH-3349 Allow setting a global default fetch size for entity loading in search queries Similar to hibernate.default_batch_fetch_size in ORM. This should provide similar functionnality to setting the database retrieval type to FIND_BY_ID in Search 5, since the only reason to do that (apparently) was to benefit from ORM's batch fetching. Commit: 9c77a60fd019d84631a7cd3b62e1df5a1c263ecb https://github.com/hibernate/hibernate-search/commit/9c77a60fd019d84631a7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingSingleTypeIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingFetchSizeIT.java Log Message: ----------- HSEARCH-3349 Test fetch size when loading search query hits more extensively Commit: 493283d5380834db414f73da13dd40a49315670e https://github.com/hibernate/hibernate-search/commit/493283d5380834db414f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/loading/impl/HibernateOrmByIdEntityLoader.java Log Message: ----------- HSEARCH-3349 Restore support for loading on out-of-date indexes when an entity was deleted then recreated with a different type Commit: b42497fd3bbebdd38343569eb6f1b9528be69ce0 https://github.com/hibernate/hibernate-search/commit/b42497fd3bbebdd38343... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/AbstractSearchQueryEntityLoadingIT.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/SearchQueryEntityLoadingMultipleTypesIT.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy7_A_B.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy7_A_C.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy7_A_D.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy7_A__Abstract.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy8_A_B_Cacheable.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy8_A_C_Cacheable.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy8_A_D_Cacheable.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Hierarchy8_A__Abstract.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Interface1.java A integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/search/loading/model/multipletypes/Interface2.java Log Message: ----------- HSEARCH-3349 Test loading on out-of-date indexes when an entity was deleted then recreated with a different type Commit: 190ca88be3b3cf4ff04cd8981d3234bf29f856a3 https://github.com/hibernate/hibernate-search/commit/190ca88be3b3cf4ff04c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2019-07-03 (Wed, 03 Jul 2019) Changed paths: M documentation/src/main/asciidoc/search-dsl.asciidoc M documentation/src/test/java/org/hibernate/search/documentation/searchdsl/query/Book.java M documentation/src/test/java/org/hibernate/search/documentation/searchdsl/query/QueryDslIT.java Log Message: ----------- HSEARCH-3349 Document the loading cache lookup strategy and loading fetch size Compare: https://github.com/hibernate/hibernate-search/compare/a05c0e888c58...190c...