[hibernate-commits] [hibernate/hibernate-orm] 96b2b7: HHH-14323 Remove unnecessary checks around Java 8 ...

Branch: refs/heads/5.4 Home: https://github.com/hibernate/hibernate-orm Commit: 96b2b71393995b10f9d0e8e937b7a4ecdd78451c https://github.com/hibernate/hibernate-orm/commit/96b2b71393995b10f9d0e8e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M documentation/documentation.gradle M gradle/published-java-module.gradle Log Message: ----------- HHH-14323 Remove unnecessary checks around Java 8 compatibility The build requires JDK8+, so we're alwways Java 8 compatible. Commit: 1b44713d0926d3603641d9adf90addc45f21a35f https://github.com/hibernate/hibernate-orm/commit/1b44713d0926d3603641d9a... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/base-information.gradle M gradle/java-module.gradle M hibernate-integrationtest-java-modules/hibernate-integrationtest-java-modules.gradle Log Message: ----------- HHH-14323 Generate Java 13/14 bytecode for tests when building with JDK13/14 Commit: dfc04d8f5d30d67daf3fde4e993ad03241a16b6c https://github.com/hibernate/hibernate-orm/commit/dfc04d8f5d30d67daf3fde4... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/java-module.gradle Log Message: ----------- HHH-14323 Do not set net.bytebuddy.experimental=true in tests anymore It's no longer necessary since we upgraded to byte-buddy 1.10.2, and it causes bytecode to be converted from Java 14 to Java 12 in some cases (I don't know why). Commit: ddb474f7c3385d56362882b18cdf105edb3fb800 https://github.com/hibernate/hibernate-orm/commit/ddb474f7c3385d56362882b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest.java Log Message: ----------- HHH-14323 Enable extended bytecode enhancement in NaturalIdInUninitializedAssociationTest This test accesses a field of an entity directly and expects it to be automatically initialized; this cannot work without extended bytecode enhancement. This used to work with Java 8 bytecode, but only by chance. It seems that Java 8 bytecode relies on "synthetic", static access methods inserted by the compiler to access the fields of entities in this test: any access to the field is done through this access method instead of through a direct field access. Since we apply bytecode enhancement to all methods of entities, this means that access to fields triggers initialization, without any bytecode enhancement in the caller class. I believe this is specific to nested classes, but couldn't find a source. For reference, the bytecode of access methods looks like this: static int access$002(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, int); Code: 0: aload_0 1: iload_1 2: dup_x1 3: putfield #3 // Field id:I 6: ireturn static org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId access$102(org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$AnEntity, org.hibernate.test.bytecode.enhancement.lazy.NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId); Code: 0: aload_0 1: aload_1 2: dup_x1 3: putfield #2 // Field entityImmutableNaturalId:Lorg/hibernate/test/bytecode/enhancement/lazy/NaturalIdInUninitializedAssociationTest$EntityImmutableNaturalId; 6: areturn With Java 11, however, access to fields of entities is done directly, even for nested classes. So the access methods no longer exist, and we don't get automatic initialization upon field access. We need extended bytecode enhancement, like we would in any other case of field access (in particular accessing fields of non-nested classes). Commit: 4bf0a96c226cc3cb12752c6754eac46348f745e8 https://github.com/hibernate/hibernate-orm/commit/4bf0a96c226cc3cb12752c6... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M build.gradle M gradle/base-information.gradle M gradle/java-module.gradle M hibernate-integrationtest-java-modules/hibernate-integrationtest-java-modules.gradle M settings.gradle Log Message: ----------- HHH-14323 Allow forcing the tested Java version in the Gradle build ... just in case we need that for some cutting-edge JDK, for example 15, that would not be supported by Gradle yet. Commit: 4c15128838a735e4066e71b2ca4f368a85612c45 https://github.com/hibernate/hibernate-orm/commit/4c15128838a735e4066e71b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/java-module.gradle Log Message: ----------- HHH-14323 Restore the system property net.bytebuddy.experimental=true in tests on JDK15+ Turns out it's necessary for JDKs with experimental support. Commit: adcadc855cf526e9b565df1a1a9bb025dc612b9f https://github.com/hibernate/hibernate-orm/commit/adcadc855cf526e9b565df1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/wrapper/gradle-wrapper.jar M gradle/wrapper/gradle-wrapper.properties M gradlew M gradlew.bat Log Message: ----------- HHH-14315 Upgrade to Gradle 6.7 Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: fb2a5cf94bef4c0f2ffd07983c08737757bccbb6 https://github.com/hibernate/hibernate-orm/commit/fb2a5cf94bef4c0f2ffd079... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M build.gradle M documentation/documentation.gradle M gradle.properties M gradle/base-information.gradle M gradle/java-module.gradle M gradle/published-java-module.gradle M hibernate-core/hibernate-core.gradle M hibernate-integrationtest-java-modules/hibernate-integrationtest-java-modules.gradle M hibernate-osgi/hibernate-osgi.gradle M settings.gradle M tooling/hibernate-gradle-plugin/hibernate-gradle-plugin.gradle Log Message: ----------- HHH-14315 Add optional support for toolchains to the Gradle build Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 08079035c7f1e6530fda300084b90ee0c569d232 https://github.com/hibernate/hibernate-orm/commit/08079035c7f1e6530fda300... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M documentation/documentation.gradle M gradle.properties M gradle/java-module.gradle M hibernate-core/hibernate-core.gradle Log Message: ----------- HHH-14315 Force JVM options when using toolchains Apparently Gradle won't just use the same options as in its own JVM. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 00a2486c27fdb1f7af7d6a818d8802e1692f245e https://github.com/hibernate/hibernate-orm/commit/00a2486c27fdb1f7af7d6a8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M .travis.yml Log Message: ----------- HHH-14315 Upgrade Travis build to OpenJDK 11.0.9 For some reason the gradle build gets stuck at task :hibernate-core:compileTestJava when using OpenJDK 11.0.3. I can't reproduce the problem with 11.0.9, though, so it's probably a bug in OpenJDK 11.0.3. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 2010497df9ecf8b5e1e7e29938fa0bdf1441a3ee https://github.com/hibernate/hibernate-orm/commit/2010497df9ecf8b5e1e7e29... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle.properties Log Message: ----------- HHH-14370 Add --add-opens options required for Gradle In order to work around illegal accesses in Gradle. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: ab448302515e8840ce770f5d32a59615674ec5d9 https://github.com/hibernate/hibernate-orm/commit/ab448302515e8840ce770f5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/libraries.gradle Log Message: ----------- HHH-14372 Upgrade to Weld 3.1.5.Final in tests Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 6845edd74ef0af7e74a50066550c512fb4fdcb72 https://github.com/hibernate/hibernate-orm/commit/6845edd74ef0af7e74a5006... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M gradle/java-module.gradle M hibernate-core/hibernate-core.gradle Log Message: ----------- HHH-14371 Correctly set JVM args in the JVM running tests Turns out getJvmArgs() returns a copy, so modifying that copy won't change the JVM args. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: f2a866e0af3fc8d4214a29b070654e8d1d0a1c28 https://github.com/hibernate/hibernate-orm/commit/f2a866e0af3fc8d4214a29b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-core/hibernate-core.gradle Log Message: ----------- HHH-14371 Open java.base/java.nio.charset to the unnamed module in tests NamingHelper test needs access to Charset.defaultCharset. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 0dd322d4be0e04b9bdb41393a815a3d46d25403e https://github.com/hibernate/hibernate-orm/commit/0dd322d4be0e04b9bdb4139... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-core/hibernate-core.gradle Log Message: ----------- HHH-14371 Open java.base/java.security and java/base/java.lang to the unnamed module in tests Weld needs this, in CDI tests. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 50d5be3abf79ee188f4f7a721b79280d594c00e4 https://github.com/hibernate/hibernate-orm/commit/50d5be3abf79ee188f4f7a7... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-core/src/test/java/org/hibernate/test/bytecode/ReflectionOptimizerTest.java A hibernate-core/src/testJavassist/java/org/hibernate/test/bytecode/javassist/Bean.java A hibernate-core/src/testJavassist/java/org/hibernate/test/bytecode/javassist/BeanReflectionHelper.java A hibernate-core/src/testJavassist/java/org/hibernate/test/bytecode/javassist/BulkAccessorTest.java Log Message: ----------- HHH-14371 Move tests specific to Javassist to the appropriate source set Otherwise they won't be executed with the appropriate JVM args. Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: d89ebc2097f3f74b3eb310fd9a6b68cc383d2388 https://github.com/hibernate/hibernate-orm/commit/d89ebc2097f3f74b3eb310f... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-core/hibernate-core.gradle Log Message: ----------- HHH-14371 Open java.base/java.lang to the unnamed module in javassist tests Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 91269dccab4348c84618060a7abf4fcb39b56611 https://github.com/hibernate/hibernate-orm/commit/91269dccab4348c84618060... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M tooling/hibernate-gradle-plugin/hibernate-gradle-plugin.gradle Log Message: ----------- HHH-14371 Add --add-opens options required for Gradle plugin tests Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Commit: 51dafa9245ac4b42e83dca1ce6a09a3e1ddf37f6 https://github.com/hibernate/hibernate-orm/commit/51dafa9245ac4b42e83dca1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2021-01-07 (Thu, 07 Jan 2021) Changed paths: M hibernate-proxool/hibernate-proxool.gradle Log Message: ----------- HHH-14371 Open java.base/java.lang to the unnamed module in Proxool tests Signed-off-by: Yoann Rodière <yoann(a)hibernate.org&gt; Compare: https://github.com/hibernate/hibernate-orm/compare/bbec5c31182d...51dafa9...