Re: [jboss-as7-dev] DataSource Enable/disable
IMO if it's important to the users of the API (aka Heiko) to have it be
regular (i.e. all attributes that can be independently toggled expose a
write-attribute op) then give them what they want. The effect of
changing the attribute can be explained in the attribute description.
I think offering both variants is fine too.
On 4/20/11 9:31 AM, Stefano Maestri wrote:
When John have changed datasources subsystem he have created 4
operations for them:
- add
- remove
- enable
- disable
I like them, now Heiko is asking to move enable/disable out in favour of
a more standard r/w attribute enabled (note that this attribute is
present in our xml). See There:
https://issues.jboss.org/browse/JBAS-9341
Since the operation don't just change the attribute, but also stop
services and unbind ds from jndi I'd prefer to keep operations as is. I
think an explicit operation make clearer to users that they are changing
the status of the entire datasourrce
opinions?
S.
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat