Re: [jboss-as7-dev] Request for review: AS7 management additions

Thanks Brian! > This looks ok, except in the > OSGiSubsystemProviders.OSGI_MODULES_REMOVE > the operation name is set to ADD instead of the intended REMOVE. Well spotted (thanks!) and this actually brings me to my next question: where are these DescriptionProviders used? I see that it even provides i18n-capable descriptions but at least using jboss-admin.sh I couldn't figure out how to get this info out. Is there also a relation to any .xsd file out there that contains the same information?

Cheers, David ----- Original Message ----- > From: "Brian Stansberry"<brian.stansberry(a)redhat.com> > To: jboss-as7-dev(a)lists.jboss.org > Sent: Tuesday, 31 May, 2011 5:22:36 PM > Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions > > This looks ok, except in the > OSGiSubsystemProviders.OSGI_MODULES_REMOVE > the operation name is set to ADD instead of the intended REMOVE. > > Re: > > + // TODO what is this one used for? > static final DescriptionProvider SUBSYSTEM_ADD = new > DescriptionProvider() { > > When the config is parsed and it finds the osgi subsystem element, > your > parser generates an add operation with address subsystem=osgi and > whatever parameters that operation takes. The SUBSYSTEM_ADD above is > meant to describe those parameters (it currently doesn't). The > OSGiSubsystemAdd handler then handles the operation. > > You're pulling some of the stuff currently handled by OSGiSubsystemAdd > out into a separate child resource, so the OSGiSubsystemAdd logic will > need to be updated to reflect that. > > > On 5/31/11 7:22 AM, David Bosschaert wrote: >> Hi all, >> >> I'm currently learning the AS7 management API so I can work on >> providing additional management functionality. >> As a start, I've extended the OSGi management API so that a >> pre-loaded module can be added/removed. >> >> Before I go add more stuff to this I would appreciate if someone >> could quickly review what I did, just to make sure I didn't miss >> anything... >> >> The changes are this branch: >> https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001... >> >> Thanks! >> >> David >> _______________________________________________ >> jboss-as7-dev mailing list >> jboss-as7-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev > > > -- > Brian Stansberry > Principal Software Engineer > JBoss by Red Hat > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev