Re: [jboss-as7-dev] JBAS-9268: OOM when uploading content through HTTP API
Ike,
I actually looked at using the Apache library (instead of writing my
own) when I started, but did not follow that path simply because of the
potential licensing issues. However, if Jason agrees that it is okay to go
down that path, I would love to replace the custom multipart parsing code
with a more mature library. That being said, the multipart parsing
currently relies on a library Jason wrote a while back to treat the incoming
stream as multipart data. I can certainly try digging into this to see if I
can pinpoint what is causing the OOM issue (if it is in the HTTP server code
itself or in the multipart stream class).
Thanks,
--Jonathan
On Fri, Apr 15, 2011 at 7:50 AM, Heiko Braun <hbraun(a)redhat.com> wrote:
I've run into a OOM issue when uploading content through the HTTP API
again.
(https://issues.jboss.org/browse/JBAS-9268)
I did take a look at the current implementation and propose that we change
it in the following way:
- read multipart contents from mime boundary
- replace the custom multipart stream implementation with a mature one
(leans on apache commons fileupload)
I've got this changes tested and verified in a custom branch:
https://github.com/heiko-braun/jboss-as/commits/out_of_memory
However before going ahead, I would like get some feedback from
a) the original author (Jonathan Pearlin. Welcome onboard btw)
b) Jason wrt the Apache License sources (See
org.jboss.as.domain.http.server.multipart.asf.*)
Regards, Ike
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Attachments:
- attachment.html (text/html — 2.3 KB)