3:22 a.m.
Please do not use square brackets [] in commit messages.
The contents between the brackets is deleted during a git-am process.
Carlo
3:33 a.m.
Wasn't that required for proper jira integration (e.g. [AS7-838] blah
blah) ?
Alessio
On 06/14/2011 10:22 AM, Carlo de Wolf wrote:
Please do not use square brackets [] in commit messages.
The contents between the brackets is deleted during a git-am process.
Carlo
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Alessio Soldano
Web Service Lead, JBoss
3:38 a.m.
It'll pickup anything resembling a Jira issue. So just AS7-838 would be
enough.
Note that I consider this a bug in git-am. git-mailinfo does have an
extra option (-b), but I don't see how to enable that by default on git-am.
Carlo
On 06/14/2011 10:33 AM, Alessio Soldano wrote:
Wasn't that required for proper jira integration (e.g. [AS7-838]
blah
blah) ?
Alessio
On 06/14/2011 10:22 AM, Carlo de Wolf wrote:
> Please do not use square brackets [] in commit messages.
> The contents between the brackets is deleted during a git-am process.
>
> Carlo
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
9:25 a.m.
On 06/14/2011 03:22 AM, Carlo de Wolf wrote:
Please do not use square brackets [] in commit messages.
The contents between the brackets is deleted during a git-am process.
We don't use git-am applying patches to AS upstream. I still prefer the
"[AS7-2000] Blah Blah" format personally.
--
- DML
9:31 a.m.
On 14/06/2011 15:25, David M. Lloyd wrote:
On 06/14/2011 03:22 AM, Carlo de Wolf wrote:
> Please do not use square brackets [] in commit messages.
> The contents between the brackets is deleted during a git-am process.
We don't use git-am applying patches to AS upstream. I still prefer the
"[AS7-2000] Blah Blah" format personally.
Is there an obvious alternative that doesn't suffer from this issue?
(AS7-2000) Blah Blah
{AS7-2000} Blah Blah
<AS7-2000> Blah Blah
Cheers,
David
9:34 a.m.
On 06/14/2011 04:31 PM, David Bosschaert wrote:
On 14/06/2011 15:25, David M. Lloyd wrote:
> On 06/14/2011 03:22 AM, Carlo de Wolf wrote:
>> Please do not use square brackets [] in commit messages.
>> The contents between the brackets is deleted during a git-am process.
> We don't use git-am applying patches to AS upstream. I still prefer the
> "[AS7-2000] Blah Blah" format personally.
>
Is there an obvious alternative that doesn't suffer from this issue?
(AS7-2000) Blah Blah
{AS7-2000} Blah Blah
<AS7-2000> Blah Blah
Cheers,
David
I believe you can use any of the above, I use AS7-2000: Blah Blah.
Carlo
4946
days inactive
4946
days old
5 comments
4 participants
participants (4)
-
Alessio Soldano -
Carlo de Wolf -
David Bosschaert -
David M. Lloyd