I've touched on this topic before, but now I'd like to propose an action
item for fairly early in AS 8 work.
Let's get most, if not all, of the stuff in testsuite/integration/smoke
out of there and into testsuite/integration/basic.
Why? Because leaving it in smoke just wastes time to little benefit.
When is the last time you did some work, ran ./build.sh install before
submitting a pull request, and a smoke test failure told you you had a
problem? (Let's exclude any brand new smoke test you added as part of
the patch, since presumably a good engineer would run the test whether
or not it was in smoke.)
For me it has probably been at least a year. All the smoke tests are
doing for me is adding time to a standard build.
A separate, limited-in-order-to-run-fast set of smoke tests was
important in the AS < 7 days when devs would often only run the smoke
tests and then commit directly to SVN. Now the full testsuite always
gets run for any patch at least once and normally 3 times before it gets
merged.
To be clear -- the suggestion is to move these tests, not to drop them.
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
Show replies by date