[JBoss JIRA] (AS7-4387) CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
by Jason Greene (JIRA)
[ https://issues.jboss.org/browse/AS7-4387?page=com.atlassian.jira.plugin.s... ]
Jason Greene commented on AS7-4387:
-----------------------------------
Ah ok its because set doesnt take effect until the next command is evaluated
> CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
> ---------------------------------------------------------
>
> Key: AS7-4387
> URL: https://issues.jboss.org/browse/AS7-4387
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Jason Greene
> Priority: Critical
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat doesn't modify JAVA_OPTS correctly because Only last change of JAVA_OPTS is reflected. JAVA_OPTS isn't dynamically changed withing 'if' part.
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
> must be changed to
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4420) CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
by Jason Greene (JIRA)
[ https://issues.jboss.org/browse/AS7-4420?page=com.atlassian.jira.plugin.s... ]
Jason Greene commented on AS7-4420:
-----------------------------------
This is by design. The intention is to optimize for development on development OS setups. Mac OSX and 32bit vm running on Windows are use in the majority for development. 64bit vm on windows won't use client. Anyone running a production server in an environment like this can easily change this setting if they choose to.
> CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
> ----------------------------------------------------------------------------------------
>
> Key: AS7-4420
> URL: https://issues.jboss.org/browse/AS7-4420
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Fix For: No Release
>
>
> standalone.bat sets -client by default if -server or -client isn't specified in JAVA_OPTS
> standalone.sh sets -server by default if -server or -client isn't specified in JAVA_OPTS (with exception for darwin)
> I think EAP should set -server by default.
> Part of standalone.bat
> {code}
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> {code}
> Part of standalone.sh
> {code}
> CLIENT_VM=false
> if [ "x$CLIENT_SET" != "x" ]; then
> CLIENT_VM=true
> elif [ "x$SERVER_SET" = "x" ]; then
> if $darwin && [ "$JVM_OPTVERSION" = "-d32" ]; then
> # Prefer client for Macs, since they are primarily used for development
> CLIENT_VM=true
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -client"
> else
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -server"
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (JBRULES-3416) WorkingMemory corruption
by Reinis Vicups (JIRA)
Reinis Vicups created JBRULES-3416:
--------------------------------------
Summary: WorkingMemory corruption
Key: JBRULES-3416
URL: https://issues.jboss.org/browse/JBRULES-3416
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-compiler (expert), drools-core (expert)
Affects Versions: 5.4.0.Beta2
Environment: linux ubuntu; java version "1.6.0_26"; Java(TM) SE Runtime Environment (build 1.6.0_26-b03); Java HotSpot(TM) Server VM (build 20.1-b02, mixed mode)
Reporter: Reinis Vicups
Assignee: Mark Proctor
Given rules lead to (presumed) memmory corruption in some data scenarios:
package de.orbitx.accumulatetesettest;
import de.orbitx.accumulatesettest.DomainObject;
import de.orbitx.accumulatesettest.Foo;
import de.orbitx.accumulatesettest.Bar;
import org.drools.planner.core.score.constraint.IntConstraintOccurrence;
import org.drools.planner.core.score.constraint.ConstraintType;
global DomainObject aggregator;
rule "reward Bar consolidation"
when
$leftFoo : Foo($leftBar : bar, $leftId : id, $leftInterval : interval)
$rightFoo : Foo(bar == $leftBar, id != $leftId, interval.getStart() < $leftInterval.getStart())
eval($leftFoo.getInterval().getStart() - $rightFoo.getInterval().getStart() < 4)
then
insertLogical(new IntConstraintOccurrence("reward Bar consolidation", ConstraintType.POSITIVE, 1, $leftFoo, $rightFoo));
System.out.println("Rewarding leftFoo:" + $leftFoo + " rightFoo:" + $rightFoo);
end
rule "softConstraintsBroken"
when
$softTotal : Number() from accumulate(
IntConstraintOccurrence(constraintType == ConstraintType.NEGATIVE_SOFT, $weight : weight),
sum($weight))
$positiveSoftTotal : Number() from accumulate(
IntConstraintOccurrence(constraintType == ConstraintType.POSITIVE, $weight : weight), sum($weight))
then
aggregator.setValue($softTotal.intValue() - $positiveSoftTotal.intValue());
end
For instance:
Foo(id:1, bar:Bar: 0, baz:null, int:Int(start:3, duration:0))
Foo(id:2, bar:Bar: 0, baz:null, int:Int(start:1, duration:0))
Foo(id:3, bar:Bar: 1, baz:null, int:Int(start:4, duration:0))
Foo(id:4, bar:Bar: 1, baz:null, int:Int(start:2, duration:0))
session.fireAllRules lead to aggregator.getValue of -2 and following activations
Rewarding leftFoo:Foo(id:3, bar:Bar: 1, baz:null, int:Int(start:4, duration:0)) rightFoo:Foo(id:4, bar:Bar: 1, baz:null, int:Int(start:2, duration:0))
Rewarding leftFoo:Foo(id:1, bar:Bar: 0, baz:null, int:Int(start:3, duration:0)) rightFoo:Foo(id:2, bar:Bar: 0, baz:null, int:Int(start:1, duration:0))
when swapping Bars of Foo 1 and Foo 3:
Foo(id:1, bar:Bar: 1, baz:null, int:Int(start:3, duration:0))
Foo(id:3, bar:Bar: 0, baz:null, int:Int(start:4, duration:0))
session.fireAllRules lead to aggregator.getValue of -1 and following activations
Rewarding leftFoo:Foo(id:3, bar:Bar: 0, baz:null, int:Int(start:4, duration:0)) rightFoo:Foo(id:2, bar:Bar: 0, baz:null, int:Int(start:1, duration:0))
Second activation for the Foo 1 and Foo 4 does not happen, thus Geoffreys assumption is that working memory is corrupted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4420) CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/AS7-4420?page=com.atlassian.jira.plugin.s... ]
Brian Stansberry resolved AS7-4420.
-----------------------------------
Fix Version/s: No Release
(was: 7.1.2.Final-redhat1)
Resolution: Rejected
Won't Fix. Looking more carefully I see this was done deliberately and I don't see a reason to change it in community AS.
> CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
> ----------------------------------------------------------------------------------------
>
> Key: AS7-4420
> URL: https://issues.jboss.org/browse/AS7-4420
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Fix For: No Release
>
>
> standalone.bat sets -client by default if -server or -client isn't specified in JAVA_OPTS
> standalone.sh sets -server by default if -server or -client isn't specified in JAVA_OPTS (with exception for darwin)
> I think EAP should set -server by default.
> Part of standalone.bat
> {code}
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> {code}
> Part of standalone.sh
> {code}
> CLIENT_VM=false
> if [ "x$CLIENT_SET" != "x" ]; then
> CLIENT_VM=true
> elif [ "x$SERVER_SET" = "x" ]; then
> if $darwin && [ "$JVM_OPTVERSION" = "-d32" ]; then
> # Prefer client for Macs, since they are primarily used for development
> CLIENT_VM=true
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -client"
> else
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -server"
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4387) CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
by Jason Greene (JIRA)
[ https://issues.jboss.org/browse/AS7-4387?page=com.atlassian.jira.plugin.s... ]
Jason Greene commented on AS7-4387:
-----------------------------------
I'm going to test this, but I don't follow how the suggested change makes a difference.
> CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
> ---------------------------------------------------------
>
> Key: AS7-4387
> URL: https://issues.jboss.org/browse/AS7-4387
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Priority: Critical
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat doesn't modify JAVA_OPTS correctly because Only last change of JAVA_OPTS is reflected. JAVA_OPTS isn't dynamically changed withing 'if' part.
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
> must be changed to
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4420) CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/AS7-4420?page=com.atlassian.jira.plugin.s... ]
Brian Stansberry commented on AS7-4420:
---------------------------------------
Note that this requires review. The reason -client is used on Darwin is due to the expectation that a Mac is a developer machine. With Windows it's not so clear cut.
> CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
> ----------------------------------------------------------------------------------------
>
> Key: AS7-4420
> URL: https://issues.jboss.org/browse/AS7-4420
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat sets -client by default if -server or -client isn't specified in JAVA_OPTS
> standalone.sh sets -server by default if -server or -client isn't specified in JAVA_OPTS (with exception for darwin)
> I think EAP should set -server by default.
> Part of standalone.bat
> {code}
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> {code}
> Part of standalone.sh
> {code}
> CLIENT_VM=false
> if [ "x$CLIENT_SET" != "x" ]; then
> CLIENT_VM=true
> elif [ "x$SERVER_SET" = "x" ]; then
> if $darwin && [ "$JVM_OPTVERSION" = "-d32" ]; then
> # Prefer client for Macs, since they are primarily used for development
> CLIENT_VM=true
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -client"
> else
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -server"
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4387) CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
by Jason Greene (JIRA)
[ https://issues.jboss.org/browse/AS7-4387?page=com.atlassian.jira.plugin.s... ]
Jason Greene reassigned AS7-4387:
---------------------------------
Assignee: Jason Greene (was: Brian Stansberry)
> CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
> ---------------------------------------------------------
>
> Key: AS7-4387
> URL: https://issues.jboss.org/browse/AS7-4387
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Jason Greene
> Priority: Critical
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat doesn't modify JAVA_OPTS correctly because Only last change of JAVA_OPTS is reflected. JAVA_OPTS isn't dynamically changed withing 'if' part.
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
> must be changed to
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4387) CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
by Jason Greene (JIRA)
[ https://issues.jboss.org/browse/AS7-4387?page=com.atlassian.jira.plugin.s... ]
Jason Greene commented on AS7-4387:
-----------------------------------
Hmm these should be functionally equivalent
> CLONE - standalone.bat doesn't modify JAVA_OPTS correctly
> ---------------------------------------------------------
>
> Key: AS7-4387
> URL: https://issues.jboss.org/browse/AS7-4387
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Priority: Critical
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat doesn't modify JAVA_OPTS correctly because Only last change of JAVA_OPTS is reflected. JAVA_OPTS isn't dynamically changed withing 'if' part.
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
> must be changed to
> {code}
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add compressed oops, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-UseCompressedOops \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+UseCompressedOops -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+UseCompressedOops %JAVA_OPTS%"
> )
> )
> )
> if not "%PRESERVE_JAVA_OPTS%" == "true" (
> rem Add tiered compilation, if supported (64 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I "\-XX:\-TieredCompilation \-client" > nul
> if errorlevel == 1 (
> "%JAVA%" -XX:+TieredCompilation -version > nul 2>&1
> if not errorlevel == 1 (
> set "JAVA_OPTS=-XX:+TieredCompilation %JAVA_OPTS%"
> )
> )
> )
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4420) CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/AS7-4420?page=com.atlassian.jira.plugin.s... ]
Brian Stansberry moved JBPAPP-8646 to AS7-4420:
-----------------------------------------------
Project: Application Server 7 (was: JBoss Enterprise Application Platform)
Key: AS7-4420 (was: JBPAPP-8646)
Workflow: GIT Pull Request workflow (was: jira)
Affects Version/s: 7.1.1.Final
(was: EAP 6.0.0 ER 4)
Component/s: Scripts
(was: Scripts and Commands)
Security: (was: Public)
Fix Version/s: 7.1.2.Final-redhat1
(was: EAP 6.0.0 ER 5)
Docs QE Status: (was: NEW)
> CLONE - standalone.bat sets -client by default and standalone.sh sets -server by default
> ----------------------------------------------------------------------------------------
>
> Key: AS7-4420
> URL: https://issues.jboss.org/browse/AS7-4420
> Project: Application Server 7
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 7.1.1.Final
> Reporter: Rostislav Svoboda
> Assignee: Brian Stansberry
> Fix For: 7.1.2.Final-redhat1
>
>
> standalone.bat sets -client by default if -server or -client isn't specified in JAVA_OPTS
> standalone.sh sets -server by default if -server or -client isn't specified in JAVA_OPTS (with exception for darwin)
> I think EAP should set -server by default.
> Part of standalone.bat
> {code}
> rem Add -client to the JVM options, if supported (32 bit VM), and not overriden
> echo "%JAVA_OPTS%" | findstr /I \-server > nul
> if errorlevel == 1 (
> "%JAVA%" -client -version 2>&1 | findstr /I /C:"Client VM" > nul
> if not errorlevel == 1 (
> set "JAVA_OPTS=-client %JAVA_OPTS%"
> )
> )
> {code}
> Part of standalone.sh
> {code}
> CLIENT_VM=false
> if [ "x$CLIENT_SET" != "x" ]; then
> CLIENT_VM=true
> elif [ "x$SERVER_SET" = "x" ]; then
> if $darwin && [ "$JVM_OPTVERSION" = "-d32" ]; then
> # Prefer client for Macs, since they are primarily used for development
> CLIENT_VM=true
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -client"
> else
> PREPEND_JAVA_OPTS="$PREPEND_JAVA_OPTS -server"
> fi
> fi
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] (AS7-4419) CLONE - EJB remoting server side doesn't honour the max outbound messages configured on a channel
by Radoslav Husar (JIRA)
Radoslav Husar created AS7-4419:
-----------------------------------
Summary: CLONE - EJB remoting server side doesn't honour the max outbound messages configured on a channel
Key: AS7-4419
URL: https://issues.jboss.org/browse/AS7-4419
Project: Application Server 7
Issue Type: Bug
Components: EJB
Affects Versions: 7.1.1.Final
Reporter: Radoslav Husar
Assignee: jaikiran pai
Priority: Critical
While sending out messages/responses on the EJB remote channel, the server side doesn't take into account the configured max outbound messages on the channel. This can lead to the following exception on the server side:
{code}
org.jboss.remoting3.ChannelBusyException: Too many open outbound writes
at org.jboss.remoting3.remote.RemoteConnectionChannel.openOutboundMessage(RemoteConnectionChannel.java:111) [jboss-remoting-3.2.4.GA.jar:3.2.4.GA]
at org.jboss.remoting3.remote.RemoteConnectionChannel.writeMessage(RemoteConnectionChannel.java:296) [jboss-remoting-3.2.4.GA.jar:3.2.4.GA]
at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler.writeMethodInvocationResponse(MethodInvocationMessageHandler.java:330)
at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler.access$500(MethodInvocationMessageHandler.java:64)
at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler$1.run(MethodInvocationMessageHandler.java:226)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [rt.jar:1.7.0_b147-icedtea]
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) [rt.jar:1.7.0_b147-icedtea]
at java.util.concurrent.FutureTask.run(FutureTask.java:166) [rt.jar:1.7.0_b147-icedtea]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_b147-icedtea]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_b147-icedtea]
at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_b147-icedtea]
at org.jboss.threads.JBossThread.run(JBossThread.java:122) [jboss-threads-2.0.0.GA.jar:2.0.0.GA]
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month