[JBoss JIRA] (WFCORE-3441) Undeprecate SubsystemRegistration.registerXMLElementWriter
by Brian Stansberry (JIRA)
Brian Stansberry created WFCORE-3441:
----------------------------------------
Summary: Undeprecate SubsystemRegistration.registerXMLElementWriter
Key: WFCORE-3441
URL: https://issues.jboss.org/browse/WFCORE-3441
Project: WildFly Core
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
It's not clear that using a Supplier<XMLElementWriter> is better or even best practice, so we shouldn't push it.
1) The supplier very likely costs more metaspace, since the class being newed up in a method reference gets loaded anyway, plus the cost of the method reference.
2) Sharing the instance between the writer and the parser is more efficient for one that stores state. (Not completely trivial though, as it means the Extension impl must cache it.)
3) For non-legacy versions of the parser, we don't really want a Supplier. A Supplier defers work until the single threaded parsing phase of boot, and we want a lot of work to happen instead in the concurrently executed Extension.initializeParsers call.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (WFCORE-3415) Cut the time to execute MBeanServerConnection.getMBeanCount()
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3415?page=com.atlassian.jira.plugi... ]
Brian Stansberry updated WFCORE-3415:
-------------------------------------
Git Pull Request: https://github.com/wildfly/wildfly-core/pull/2930, https://github.com/wildfly/wildfly-core/pull/2961 (was: https://github.com/wildfly/wildfly-core/pull/2930)
> Cut the time to execute MBeanServerConnection.getMBeanCount()
> -------------------------------------------------------------
>
> Key: WFCORE-3415
> URL: https://issues.jboss.org/browse/WFCORE-3415
> Project: WildFly Core
> Issue Type: Enhancement
> Components: JMX
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Fix For: 4.0.0.Alpha3
>
>
> The time it takes to count the mbeans associated with the jboss.as and jboss.as.expr domains is way too high, over a full second when the WildFly full standalone-full-ha.xml config is used, and potentially much higher if complex deployments are installed. See WFLY-9408.
> This enhancement proposes doing two things to mitigate this:
> 1) There is no point doing a full count of both jboss.as and jboss.as.expr as they are just 2 views on the same underlying resources. If both are present, count one and double it.
> 2) Do not use RBAC to exclude from the count mbeans the user won't be allowed to see. They exist whether the user can see them or not. Simply count the resources.
> Looking at the JMX specification (https://docs.oracle.com/javase/8/docs/technotes/guides/jmx/JMX_1_4_specif...) I see nothing directly on the topic of the effect of any security checks on the result of getMBeanCount(). Section 12.1.2.4 "Permission Checking for Queries" clearly states that permission checks should remove mbeans that should not be visible according to the permission scheme from the query result, so definitely queries returning a subset of the entire mbean universe is contemplated. Now, that section is about security manager permissions, not our RBAC scheme, but it's the most on topic thing I see.
> Doing these two things I can get the cost of a getMBeanCount() from around 1 second to under 10 ms. (Note the 1 sec figure is the first call; once the JVM optimizes the existing code it drops to under 500ms.)
> The enhancement will also make it possible for custom Resource implementations to optimize things. For example a resource that represents a possibly large number of dynamic children could ask the system behind those children for a child count, rather that iterating over the children.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (WFCORE-3429) DuplicateServiceException when artifact name equals to alias
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3429?page=com.atlassian.jira.plugi... ]
Brian Stansberry resolved WFCORE-3429.
--------------------------------------
Assignee: (was: Jason Greene)
Resolution: Rejected
I agree with [~jaikiran]. Please re-open if we're missing something.
> DuplicateServiceException when artifact name equals to alias
> ------------------------------------------------------------
>
> Key: WFCORE-3429
> URL: https://issues.jboss.org/browse/WFCORE-3429
> Project: WildFly Core
> Issue Type: Task
> Components: Server
> Affects Versions: 2.2.0.Final
> Reporter: Сергей Машкевич
> Priority: Minor
> Labels: support
>
> Suppose that there is an artifact «moduleA.ear» with the following deployment descriptor:
> {code:java}
> <?xml version="1.0" encoding="UTF-8"?>
> <jboss-deployment-structure>
> <deployment>
> <module-alias name="deployment.moduleA.ear"/>
> </deployment>
> </jboss-deployment-structure>
> {code}
> When I try to deploy this module on *WildFly 10.1.0*, I get the DuplicateServiceException:
> {code:java}
> jboss.deployment.unit."moduleA.ear".CONFIGURE_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.unit."moduleA.ear".CONFIGURE_MODULE: WFLYSRV0153: Failed to process phase CONFIGURE_MODULE of deployment "moduleA.ear"
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:154)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1948)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1881)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: org.jboss.msc.service.DuplicateServiceException: Service jboss.module.spec.service."deployment.moduleA.ear".main is already registered
> at org.jboss.msc.service.ServiceRegistrationImpl.setInstance(ServiceRegistrationImpl.java:158)
> at org.jboss.msc.service.ServiceControllerImpl.startInstallation(ServiceControllerImpl.java:235)
> at org.jboss.msc.service.ServiceContainerImpl.install(ServiceContainerImpl.java:768)
> at org.jboss.msc.service.ServiceTargetImpl.install(ServiceTargetImpl.java:223)
> at org.jboss.msc.service.ServiceControllerImpl$ChildServiceTarget.install(ServiceControllerImpl.java:2401)
> at org.jboss.msc.service.ServiceTargetImpl.install(ServiceTargetImpl.java:223)
> at org.jboss.msc.service.ServiceControllerImpl$ChildServiceTarget.install(ServiceControllerImpl.java:2401)
> at org.jboss.msc.service.ServiceBuilderImpl.install(ServiceBuilderImpl.java:317)
> at org.jboss.as.server.deployment.module.ModuleSpecProcessor.createModuleService(ModuleSpecProcessor.java:263)
> at org.jboss.as.server.deployment.module.ModuleSpecProcessor.deployModuleSpec(ModuleSpecProcessor.java:124)
> at org.jboss.as.server.deployment.module.ModuleSpecProcessor.deploy(ModuleSpecProcessor.java:87)
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:147)
> ... 5 more
> {code}
> I think this exception should not be thrown in this case. Could you fix it?
> Thanks,
> Sergey Mashkevich
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (WFCORE-3396) Provide certificate authority integration
by Farah Juma (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3396?page=com.atlassian.jira.plugi... ]
Farah Juma reassigned WFCORE-3396:
----------------------------------
Assignee: Farah Juma (was: Darran Lofthouse)
> Provide certificate authority integration
> -----------------------------------------
>
> Key: WFCORE-3396
> URL: https://issues.jboss.org/browse/WFCORE-3396
> Project: WildFly Core
> Issue Type: Feature Request
> Components: Security
> Affects Versions: 4.0.0.Alpha2
> Reporter: Martin Choma
> Assignee: Farah Juma
>
> Let's Encrypt provide API to fully automate (gain/renew) certificate retrieval using ACME protocol. Integrate this capability into wildfly.
> This can simplify administrator work. No need to perform certification renewal routine tasks.
> This is follow up on WFCORE-3305 and piece of bigger task "Simplify SSL configuration in wildfly". That said it is just "User experience" issue. Administrator still can work with Let's Encrypt by third party client and just reference wildfly to this certificate.
> [1] Latest draft: https://tools.ietf.org/html/draft-ietf-acme-acme-08
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years