[JBoss JIRA] (WFLY-1547) deploy directories not cleaned up
by jaikiran pai (JIRA)
[ https://issues.jboss.org/browse/WFLY-1547?page=com.atlassian.jira.plugin.... ]
jaikiran pai commented on WFLY-1547:
------------------------------------
A PR has been sent to VFS upstream https://github.com/jbossas/jboss-vfs/pull/15 to introduce an API which helps fix this issue. Once that's reviewed, merged and released, a minor change to WildFly server code to use that new API will ensure that this issue is fixed. I'll talk to Tomaz and David this week, to see if we can get a VFS release done and then send a WildFly upstream PR for that upgrade and the fix.
> deploy directories not cleaned up
> ---------------------------------
>
> Key: WFLY-1547
> URL: https://issues.jboss.org/browse/WFLY-1547
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 8.0.0.Alpha1
> Reporter: Shaun Appleton
> Assignee: jaikiran pai
> Attachments: deployment_with_hack_no_hook.txt
>
>
> JBoss EAP 6.0.0 (and 6.0.1.ER3) doesn't clean up it's tmp/vfs directories.
> The following reproduces this -
> i) ensure run.conf has the -Xrs set
> ii) ensure deployments has a deployable .ear in it
> iii) ./run standalone.sh and allow the deployments to deploy
> iv) stop the EAP process ie kill <process_id>
> v) observe content tmp/vfs
> (The -Xrs parameter is used to "-Xrs" to prevent possible interference when JVM is running as a service and receives CTRL_LOGOFF_EVENT or SIGHUP)
> This will eventually cause problems with lack of disk space.
> Note if the -Xrs parameter content is removed but the tmp/vfs dirs stills exist. This could potentially cause inode problems.
> It would be better if there were any additional code so the temp dirs are cleaned up on start up. That would resolve both the -Xrs problem and the excessive dir creation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBVFS-190) ANDIAMO-7 compliance
by Brian Stansberry (JIRA)
Brian Stansberry created JBVFS-190:
--------------------------------------
Summary: ANDIAMO-7 compliance
Key: JBVFS-190
URL: https://issues.jboss.org/browse/JBVFS-190
Project: JBoss VFS
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Reporter: Brian Stansberry
Adjust logging and exception messages to comply with the ANDIAMO-7 i18n and message format requirements.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBWEB-279) Overlays do not work as expected
by Remy Maucherat (JIRA)
[ https://issues.jboss.org/browse/JBWEB-279?page=com.atlassian.jira.plugin.... ]
Remy Maucherat commented on JBWEB-279:
--------------------------------------
That functionality is used to implement the spec behavior. Some configurability was added since it appeared to be easy and cheap to do, but as a result it inherits the same behavior. A configuration option can be added to switch that (disabled by default) but the switch can break spec compliant webapps.
> Overlays do not work as expected
> --------------------------------
>
> Key: JBWEB-279
> URL: https://issues.jboss.org/browse/JBWEB-279
> Project: JBoss Web
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: JBossWeb-7.2.1.GA
> Reporter: Mustafa Musaji
> Assignee: Remy Maucherat
> Attachments: fix.proposal.txt
>
>
> It is expected that the <overlay> element in jboss-web.xml has the same outcome as the overlay feature in the CLI: https://docs.jboss.org/author/display/AS72/Deployment+Overlays
> In jboss-web.xml the overlays element is not used to actually overlay existing files but to add files to a deployment. This is confusing and either this should work the same as the CLI or the documentation around the <overlay> element in jboss-web.xml should clearly state this is not the case and that we do not replace artifacts but rather
> Attached is a proposed patch that fixes this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (WFLY-1547) deploy directories not cleaned up
by jaikiran pai (JIRA)
[ https://issues.jboss.org/browse/WFLY-1547?page=com.atlassian.jira.plugin.... ]
jaikiran pai reassigned WFLY-1547:
----------------------------------
Assignee: jaikiran pai (was: Bartosz Baranowski)
> deploy directories not cleaned up
> ---------------------------------
>
> Key: WFLY-1547
> URL: https://issues.jboss.org/browse/WFLY-1547
> Project: WildFly
> Issue Type: Bug
> Affects Versions: 8.0.0.Alpha1
> Reporter: Shaun Appleton
> Assignee: jaikiran pai
> Attachments: deployment_with_hack_no_hook.txt
>
>
> JBoss EAP 6.0.0 (and 6.0.1.ER3) doesn't clean up it's tmp/vfs directories.
> The following reproduces this -
> i) ensure run.conf has the -Xrs set
> ii) ensure deployments has a deployable .ear in it
> iii) ./run standalone.sh and allow the deployments to deploy
> iv) stop the EAP process ie kill <process_id>
> v) observe content tmp/vfs
> (The -Xrs parameter is used to "-Xrs" to prevent possible interference when JVM is running as a service and receives CTRL_LOGOFF_EVENT or SIGHUP)
> This will eventually cause problems with lack of disk space.
> Note if the -Xrs parameter content is removed but the tmp/vfs dirs stills exist. This could potentially cause inode problems.
> It would be better if there were any additional code so the temp dirs are cleaned up on start up. That would resolve both the -Xrs problem and the excessive dir creation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBWEB-279) Overlays do not work as expected
by Tom Fonteyne (JIRA)
[ https://issues.jboss.org/browse/JBWEB-279?page=com.atlassian.jira.plugin.... ]
Tom Fonteyne commented on JBWEB-279:
------------------------------------
Remu, from your own words:
> AS added at some point another feature called "overlay", which is not the same thing (here, it is a proprietary feature unrelated to any EE spefication
and this functionality in jbossweb is *broken*
> Overlays do not work as expected
> --------------------------------
>
> Key: JBWEB-279
> URL: https://issues.jboss.org/browse/JBWEB-279
> Project: JBoss Web
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: JBossWeb-7.2.1.GA
> Reporter: Mustafa Musaji
> Assignee: Remy Maucherat
> Attachments: fix.proposal.txt
>
>
> It is expected that the <overlay> element in jboss-web.xml has the same outcome as the overlay feature in the CLI: https://docs.jboss.org/author/display/AS72/Deployment+Overlays
> In jboss-web.xml the overlays element is not used to actually overlay existing files but to add files to a deployment. This is confusing and either this should work the same as the CLI or the documentation around the <overlay> element in jboss-web.xml should clearly state this is not the case and that we do not replace artifacts but rather
> Attached is a proposed patch that fixes this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBWEB-279) Overlays do not work as expected
by Remy Maucherat (JIRA)
[ https://issues.jboss.org/browse/JBWEB-279?page=com.atlassian.jira.plugin.... ]
Remy Maucherat commented on JBWEB-279:
--------------------------------------
I thought my sentence was clear enough: "This code is the implementation for the specification /META-INF/resources mechanism. As a result, it must follow the specification's behavior. I'm sorry, but there is little way around that."
This is not the implementation for a JBoss specific feature, this is the specifcation standard feature. The xml configuration allows specifying a JAR as if it was included directly in the WAR itself. AS added at some point another feature called "overlay", which is not the same thing (here, it is a proprietary feature unrelated to any EE spefication).
So, well, have fun with the JIRA, but this is a "bug" that will not be fixed.
> Overlays do not work as expected
> --------------------------------
>
> Key: JBWEB-279
> URL: https://issues.jboss.org/browse/JBWEB-279
> Project: JBoss Web
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: JBossWeb-7.2.1.GA
> Reporter: Mustafa Musaji
> Assignee: Remy Maucherat
> Attachments: fix.proposal.txt
>
>
> It is expected that the <overlay> element in jboss-web.xml has the same outcome as the overlay feature in the CLI: https://docs.jboss.org/author/display/AS72/Deployment+Overlays
> In jboss-web.xml the overlays element is not used to actually overlay existing files but to add files to a deployment. This is confusing and either this should work the same as the CLI or the documentation around the <overlay> element in jboss-web.xml should clearly state this is not the case and that we do not replace artifacts but rather
> Attached is a proposed patch that fixes this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBWEB-279) Overlays do not work as expected
by Mustafa Musaji (JIRA)
[ https://issues.jboss.org/browse/JBWEB-279?page=com.atlassian.jira.plugin.... ]
Mustafa Musaji reopened JBWEB-279:
----------------------------------
> Overlays do not work as expected
> --------------------------------
>
> Key: JBWEB-279
> URL: https://issues.jboss.org/browse/JBWEB-279
> Project: JBoss Web
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: JBossWeb-7.2.1.GA
> Reporter: Mustafa Musaji
> Assignee: Remy Maucherat
> Attachments: fix.proposal.txt
>
>
> It is expected that the <overlay> element in jboss-web.xml has the same outcome as the overlay feature in the CLI: https://docs.jboss.org/author/display/AS72/Deployment+Overlays
> In jboss-web.xml the overlays element is not used to actually overlay existing files but to add files to a deployment. This is confusing and either this should work the same as the CLI or the documentation around the <overlay> element in jboss-web.xml should clearly state this is not the case and that we do not replace artifacts but rather
> Attached is a proposed patch that fixes this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (JBWEB-279) Overlays do not work as expected
by Mustafa Musaji (JIRA)
[ https://issues.jboss.org/browse/JBWEB-279?page=com.atlassian.jira.plugin.... ]
Mustafa Musaji commented on JBWEB-279:
--------------------------------------
[~rmaucher] I don't think overlays has anything to do with the spec. This is when you are a deploy to JBoss and yes we should follow the spec to look for resources as stated in your first comment. In addition to the spec, we allow overlays to be included and this is as [~tfonteyn] points out, is a JBoss specific feature. With the overlays we blatently do one thing via CLI and another thing with jboss-web.xml.
> Overlays do not work as expected
> --------------------------------
>
> Key: JBWEB-279
> URL: https://issues.jboss.org/browse/JBWEB-279
> Project: JBoss Web
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Core
> Affects Versions: JBossWeb-7.2.1.GA
> Reporter: Mustafa Musaji
> Assignee: Remy Maucherat
> Attachments: fix.proposal.txt
>
>
> It is expected that the <overlay> element in jboss-web.xml has the same outcome as the overlay feature in the CLI: https://docs.jboss.org/author/display/AS72/Deployment+Overlays
> In jboss-web.xml the overlays element is not used to actually overlay existing files but to add files to a deployment. This is confusing and either this should work the same as the CLI or the documentation around the <overlay> element in jboss-web.xml should clearly state this is not the case and that we do not replace artifacts but rather
> Attached is a proposed patch that fixes this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months