[JBoss JIRA] (WFLY-5682) Can't define absolute path for object store location
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-5682?page=com.atlassian.jira.plugin.... ]
Brian Stansberry commented on WFLY-5682:
----------------------------------------
Yes, it's confusing. Using a default value for 'relative-to' was a mistake; better would have been to leave the attribute with no default and just include object-store-relative-to="jboss.server.data.dir" in our standard config files. But we didn't do that and needed to preserve compatibility so we created the AS7-2078 standard for handling such cases. I don't want to have a separate variant beyond the two approaches described there.
It is tempting to do something very much like what you did though, Amos, and switch this to the version of the standard handling where there is no default for relative-to, and whether that is defined or not controls whether 'path' is regarded as being absolute. To do that though:
1) The standard config files will need to be updated to explicitly declare object-store-relative-to="jboss.server.data.dir" and object-store-path="tx-object-store". This will make the OOTB behavior consistent with past releases.
2) The parsers for old xsd versions should probably be updated to set object-store-relative-to to jboss.server.data.dir if the xml attribute is not defined, so the parsing of an old config produces the same result as it did before.
3) TransactionSubsystemAdd can have logic similar to what you have in your PR where it checks for object-store-relative-to being undefined and object-store-path being undefined or with a value of 'tx-object-store' and if found it uses the 'jboss.server.data.dir' as the object-store-relative-to value. It should do this in populateModel though, so the 'jboss.server.data.dir' value is stored in the model and persisted to xml. That allows old CLI scripts to work unchanged. If it does this though it should log a WARN. All of this paragraph is really just a bit of migration assistance.
I don't see any reason to drop the default value of 'tx-object-store' for 'object-store-path'. If we did, we would have to require that the attribute not be null, and that might break users who assumed it didn't have to be set.
Any of these changes (my branch, your PR or the suggestion above) all mean the management API for this subsystem has changed though, and we need to bump the API version. It's too late to do that for WF 10.0.0.Final, so this will need to be deferred to the next WildFly release. JBEAP-1913 then would not be resolved until after WildFly 10 is done.
> Can't define absolute path for object store location
> ----------------------------------------------------
>
> Key: WFLY-5682
> URL: https://issues.jboss.org/browse/WFLY-5682
> Project: WildFly
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 10.0.0.CR4
> Reporter: Ondřej Chaloupka
> Assignee: Amos Feng
> Fix For: 10.0.0.CR5
>
>
> As trying to set absolute path for location of transaction log store I've got to suspicion that's not possible.
> If I try to set `object-store-relative-to` to some absolute path or set `object-store-relative-to` to empty string and then `object-store-path` to some absolute path the server starts with exceptions [1][2].
> [1]
> {code}
> ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC000001: Failed to start service jboss.txn.ArjunaObjectStoreEnvironment: org.jboss.msc.service.StartException in service jboss.txn.ArjunaObjectStoreEnvironment: Failed to start service
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1904) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)Caused by: java.lang.IllegalArgumentException: WFLYCTL0256: Could not find a path called '/home/ochaloup/tmp/'
> at org.jboss.as.controller.services.path.PathManagerService.resolveRelativePathEntry(PathManagerService.java:87) at org.jboss.as.txn.service.ArjunaObjectStoreEnvironmentService.start(ArjunaObjectStoreEnvironmentService.java:76)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1948) at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1881)
> ...
> ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([("subsystem" => "transactions")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.txn.ArjunaObjectStoreEnvironment" => "org.jboss.msc.service.StartException in service jboss.txn.ArjunaObjectStoreEnvironment: Failed to start service
> Caused by: java.lang.IllegalArgumentException: WFLYCTL0256: Could not find a path called '/home/ochaloup/tmp/'"}}
> INFO [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0183: Service status reportWFLYCTL0186: Services which failed to start: service jboss.txn.ArjunaObjectStoreEnvironment: org.jboss.msc.service.StartException in service jboss.txn.ArjunaObjectStoreEnvironment: Failed to start service
> {code}
> [2]
> {code}
> ERROR [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0055: Caught exception during boot: org.jboss.as.controller.persistence.ConfigurationPersistenceException: WFLYCTL0085: Failed to parse configuration
> at org.jboss.as.controller.persistence.XmlConfigurationPersister.load(XmlConfigurationPersister.java:131)
> at org.jboss.as.server.ServerService.boot(ServerService.java:356) at org.jboss.as.controller.AbstractControllerService$1.run(AbstractControllerService.java:299)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[348,13]
> Message: "WFLYCTL0113: '' is an invalid value for parameter relative-to. Values must have a minimum length of 1 characters"
> at org.jboss.as.controller.SimpleAttributeDefinition.parse(SimpleAttributeDefinition.java:161) at org.jboss.as.controller.SimpleAttributeDefinition.parseAndSetParameter(SimpleAttributeDefinition.java:186)
> at org.jboss.as.txn.subsystem.TransactionSubsystem14Parser.parseObjectStoreEnvironmentElementAndEnrichOperation(TransactionSubsystem14Parser.java:205)
> at org.jboss.as.txn.subsystem.TransactionSubsystem30Parser.readElement(TransactionSubsystem30Parser.java:67) at org.jboss.as.txn.subsystem.TransactionSubsystem14Parser.readElement(TransactionSubsystem14Parser.java:111)
> at org.jboss.as.txn.subsystem.TransactionSubsystem14Parser.readElement(TransactionSubsystem14Parser.java:54) at org.jboss.staxmapper.XMLMapperImpl.processNested(XMLMapperImpl.java:110)
> at org.jboss.staxmapper.XMLExtendedStreamReaderImpl.handleAny(XMLExtendedStreamReaderImpl.java:69) at org.jboss.as.server.parsing.StandaloneXml_4.parseServerProfile(StandaloneXml_4.java:547)
> at org.jboss.as.server.parsing.StandaloneXml_4.readServerElement(StandaloneXml_4.java:244) at org.jboss.as.server.parsing.StandaloneXml_4.readElement(StandaloneXml_4.java:143)
> at org.jboss.as.server.parsing.StandaloneXml.readElement(StandaloneXml.java:69) at org.jboss.as.server.parsing.StandaloneXml.readElement(StandaloneXml.java:47) at org.jboss.staxmapper.XMLMapperImpl.processNested(XMLMapperImpl.java:110)
> at org.jboss.staxmapper.XMLMapperImpl.parseDocument(XMLMapperImpl.java:69) at org.jboss.as.controller.persistence.XmlConfigurationPersister.load(XmlConfigurationPersister.java:123)
> ... 3 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFCORE-1178) Use specific description for reply value types in ListAttributeDefintion and MapAttributeDefinition
by ehsavoie Hugonnet (JIRA)
ehsavoie Hugonnet created WFCORE-1178:
-----------------------------------------
Summary: Use specific description for reply value types in ListAttributeDefintion and MapAttributeDefinition
Key: WFCORE-1178
URL: https://issues.jboss.org/browse/WFCORE-1178
Project: WildFly Core
Issue Type: Bug
Components: Domain Management
Affects Versions: 2.0.3.Final
Reporter: ehsavoie Hugonnet
Assignee: Brian Stansberry
Priority: Minor
Currently when we get the description of a reply value type for a ListAttributeDefintion or a MapAttributeDefinition we call addOperationParameterValueTypeDescription() from addOperationReplyValueTypeDescription() instead of providing its specific description.
We should override the current code in the subclass to have a description specific to the reply attribute like we have per default after WFCORE-313
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFCORE-1177) Service can't be installed if the path contains a closed bracket
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1177?page=com.atlassian.jira.plugi... ]
James Perkins moved WFLY-5751 to WFCORE-1177:
---------------------------------------------
Project: WildFly Core (was: WildFly)
Key: WFCORE-1177 (was: WFLY-5751)
Component/s: Scripts
(was: Scripts)
Affects Version/s: (was: 10.0.0.CR4)
(was: 9.0.1.Final)
(was: 9.0.2.Final)
Fix Version/s: (was: Awaiting Volunteers)
> Service can't be installed if the path contains a closed bracket
> ----------------------------------------------------------------
>
> Key: WFCORE-1177
> URL: https://issues.jboss.org/browse/WFCORE-1177
> Project: WildFly Core
> Issue Type: Bug
> Components: Scripts
> Environment: all Windows versions
> Reporter: Paul Wildberg
> Priority: Critical
> Labels: jboss
>
> Problem:
> If you start "service.bat install" in e.g. in C:\Program Files (x86)\wildfly-9.0.1.Final\bin\service you will get:
> Using the X86-64bit version of prunsrv
> "\wildfly-9.0.1.Final\domain\log" can not be used syntatically at this point (don't know if it is correct, I translated it from german. Original it is "kann syntaktisch an dieser Stelle nicht verarbeitet werden.")
> Cause:
> This is because of the ) in "Program Files (x86)" and this is a problem because in the service.bat in line 175 and 179 (set LOGPATH=%JBOSS_HOME%\domain\log - in version 9.0.1 and 9.0.2 - in Version 10 it may be in another line) the path is not set in double quotation marks.
> All other paths are set in double quotation marks.
> Solution:
> Set the path in double quotation marks:
> set LOGPATH="%JBOSS_HOME%\domain\log"
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFLY-5751) Service can't be installed if the path contains a closed bracket
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-5751?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar reassigned WFLY-5751:
---------------------------------
Assignee: (was: James Perkins)
> Service can't be installed if the path contains a closed bracket
> ----------------------------------------------------------------
>
> Key: WFLY-5751
> URL: https://issues.jboss.org/browse/WFLY-5751
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 9.0.1.Final, 9.0.2.Final, 10.0.0.CR4
> Environment: all Windows versions
> Reporter: Paul Wildberg
> Priority: Critical
> Labels: jboss
> Fix For: Awaiting Volunteers
>
>
> Problem:
> If you start "service.bat install" in e.g. in C:\Program Files (x86)\wildfly-9.0.1.Final\bin\service you will get:
> Using the X86-64bit version of prunsrv
> "\wildfly-9.0.1.Final\domain\log" can not be used syntatically at this point (don't know if it is correct, I translated it from german. Original it is "kann syntaktisch an dieser Stelle nicht verarbeitet werden.")
> Cause:
> This is because of the ) in "Program Files (x86)" and this is a problem because in the service.bat in line 175 and 179 (set LOGPATH=%JBOSS_HOME%\domain\log - in version 9.0.1 and 9.0.2 - in Version 10 it may be in another line) the path is not set in double quotation marks.
> All other paths are set in double quotation marks.
> Solution:
> Set the path in double quotation marks:
> set LOGPATH="%JBOSS_HOME%\domain\log"
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFLY-5751) Service can't be installed if the path contains a closed bracket
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFLY-5751?page=com.atlassian.jira.plugin.... ]
Tomaz Cerar updated WFLY-5751:
------------------------------
Fix Version/s: Awaiting Volunteers
> Service can't be installed if the path contains a closed bracket
> ----------------------------------------------------------------
>
> Key: WFLY-5751
> URL: https://issues.jboss.org/browse/WFLY-5751
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 9.0.1.Final, 9.0.2.Final, 10.0.0.CR4
> Environment: all Windows versions
> Reporter: Paul Wildberg
> Priority: Critical
> Labels: jboss
> Fix For: Awaiting Volunteers
>
>
> Problem:
> If you start "service.bat install" in e.g. in C:\Program Files (x86)\wildfly-9.0.1.Final\bin\service you will get:
> Using the X86-64bit version of prunsrv
> "\wildfly-9.0.1.Final\domain\log" can not be used syntatically at this point (don't know if it is correct, I translated it from german. Original it is "kann syntaktisch an dieser Stelle nicht verarbeitet werden.")
> Cause:
> This is because of the ) in "Program Files (x86)" and this is a problem because in the service.bat in line 175 and 179 (set LOGPATH=%JBOSS_HOME%\domain\log - in version 9.0.1 and 9.0.2 - in Version 10 it may be in another line) the path is not set in double quotation marks.
> All other paths are set in double quotation marks.
> Solution:
> Set the path in double quotation marks:
> set LOGPATH="%JBOSS_HOME%\domain\log"
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFLY-5751) Service can't be installed if the path contains a closed bracket
by Paul Wildberg (JIRA)
[ https://issues.jboss.org/browse/WFLY-5751?page=com.atlassian.jira.plugin.... ]
Paul Wildberg edited comment on WFLY-5751 at 12/1/15 10:17 AM:
---------------------------------------------------------------
news:
With the workaround I was able to install the service - but I couldn't start it.
So I dived some more into it.
If you change it to
set "LOGPATH=%JBOSS_HOME%\domain\log" (difference is the double quotation mark in front of "LOGPATH" and not in front of "%JBOSS_HOME%")
you can install the service and start it.
I edited the workaround.
I don't think all lines are like this so maybe there need to be a lot more lines to be changed than this two.
was (Author: wildberg):
news:
With the workaround I was able to install the service - but I couldn't start it.
So I dived some more into it.
If you change it to
set "LOGPATH=%JBOSS_HOME%\domain\log" (difference is the double quotation mark in front of "LOGPATH" and not in front of "%JBOSS_HOME%")
you can install the service and start it.
I edited the workaround.
> Service can't be installed if the path contains a closed bracket
> ----------------------------------------------------------------
>
> Key: WFLY-5751
> URL: https://issues.jboss.org/browse/WFLY-5751
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 9.0.1.Final, 9.0.2.Final, 10.0.0.CR4
> Environment: all Windows versions
> Reporter: Paul Wildberg
> Assignee: James Perkins
> Priority: Critical
> Labels: jboss
>
> Problem:
> If you start "service.bat install" in e.g. in C:\Program Files (x86)\wildfly-9.0.1.Final\bin\service you will get:
> Using the X86-64bit version of prunsrv
> "\wildfly-9.0.1.Final\domain\log" can not be used syntatically at this point (don't know if it is correct, I translated it from german. Original it is "kann syntaktisch an dieser Stelle nicht verarbeitet werden.")
> Cause:
> This is because of the ) in "Program Files (x86)" and this is a problem because in the service.bat in line 175 and 179 (set LOGPATH=%JBOSS_HOME%\domain\log - in version 9.0.1 and 9.0.2 - in Version 10 it may be in another line) the path is not set in double quotation marks.
> All other paths are set in double quotation marks.
> Solution:
> Set the path in double quotation marks:
> set LOGPATH="%JBOSS_HOME%\domain\log"
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months
[JBoss JIRA] (WFLY-5751) Service can't be installed if the path contains a closed bracket
by Paul Wildberg (JIRA)
[ https://issues.jboss.org/browse/WFLY-5751?page=com.atlassian.jira.plugin.... ]
Paul Wildberg edited comment on WFLY-5751 at 12/1/15 10:17 AM:
---------------------------------------------------------------
news:
With the workaround I was able to install the service - but I couldn't start it.
So I dived some more into it.
If you change it to
set "LOGPATH=%JBOSS_HOME%\domain\log" (difference is the double quotation mark in front of "LOGPATH" and not in front of "%JBOSS_HOME%")
you can install the service and start it.
I edited the workaround.
I don't think all lines are like this so maybe there need to be a lot more lines (maybe even in other files) to be changed than this two.
was (Author: wildberg):
news:
With the workaround I was able to install the service - but I couldn't start it.
So I dived some more into it.
If you change it to
set "LOGPATH=%JBOSS_HOME%\domain\log" (difference is the double quotation mark in front of "LOGPATH" and not in front of "%JBOSS_HOME%")
you can install the service and start it.
I edited the workaround.
I don't think all lines are like this so maybe there need to be a lot more lines to be changed than this two.
> Service can't be installed if the path contains a closed bracket
> ----------------------------------------------------------------
>
> Key: WFLY-5751
> URL: https://issues.jboss.org/browse/WFLY-5751
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 9.0.1.Final, 9.0.2.Final, 10.0.0.CR4
> Environment: all Windows versions
> Reporter: Paul Wildberg
> Assignee: James Perkins
> Priority: Critical
> Labels: jboss
>
> Problem:
> If you start "service.bat install" in e.g. in C:\Program Files (x86)\wildfly-9.0.1.Final\bin\service you will get:
> Using the X86-64bit version of prunsrv
> "\wildfly-9.0.1.Final\domain\log" can not be used syntatically at this point (don't know if it is correct, I translated it from german. Original it is "kann syntaktisch an dieser Stelle nicht verarbeitet werden.")
> Cause:
> This is because of the ) in "Program Files (x86)" and this is a problem because in the service.bat in line 175 and 179 (set LOGPATH=%JBOSS_HOME%\domain\log - in version 9.0.1 and 9.0.2 - in Version 10 it may be in another line) the path is not set in double quotation marks.
> All other paths are set in double quotation marks.
> Solution:
> Set the path in double quotation marks:
> set LOGPATH="%JBOSS_HOME%\domain\log"
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 5 months