[JBoss JIRA] (JBMETA-385) Add overridable flag to servlet metadata
by James Livingston (JIRA)
James Livingston created JBMETA-385:
---------------------------------------
Summary: Add overridable flag to servlet metadata
Key: JBMETA-385
URL: https://issues.jboss.org/browse/JBMETA-385
Project: JBoss Metadata
Issue Type: Enhancement
Components: web
Affects Versions: 7.2.1.Final
Reporter: James Livingston
Assignee: Jean-Frederic Clere
To resolve https://bugzilla.redhat.com/show_bug.cgi?id=1094248, I believe we need an additional 'overridable' flag on the servlet metadata which indicates whether ServletContainerInitializers (and other code using servlet dynamic registration) should be allowed to override the servlet. Normally this is not allowed, however JBWeb's internal use of DefaultServlet to handle static resources should be.
This only needs to go into 7, since the Undertow subsystem in Wildfly handles this quite differently, so does not need to pass a flag between components.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (WFCORE-567) Invoking shutdown command for slave HC results in CLI disconnecting
by Brian Stansberry (JIRA)
Brian Stansberry created WFCORE-567:
---------------------------------------
Summary: Invoking shutdown command for slave HC results in CLI disconnecting
Key: WFCORE-567
URL: https://issues.jboss.org/browse/WFCORE-567
Project: WildFly Core
Issue Type: Bug
Components: CLI
Affects Versions: 1.0.0.Alpha19
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
Connect the CLI to the master in a domain with a slave HC and shut down the slave. CLI disconnects:
{code}
[domain@localhost:9990 /] shutdown --host=slave
[disconnected /]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (WFCORE-565) StaticDiscoveryResourceDefinition allows undefined values for its attributes
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-565?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFCORE-565:
-----------------------------------------
The "get" methods from DiscoveryOption can legitimately return null before the "discover()" method is invoked. The uses of DiscoveryOptionStrategy.DiscoveryOptionComparator are not properly dealing with that.
We need to rethink the DiscoveryOption sorting, as there's sorting going on before discovery has taken place.
> StaticDiscoveryResourceDefinition allows undefined values for its attributes
> ----------------------------------------------------------------------------
>
> Key: WFCORE-565
> URL: https://issues.jboss.org/browse/WFCORE-565
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Reporter: Brian Stansberry
>
> StaticDiscoveryResourceDefinition reuses the AttributeDefinitions from RemoteDomainControllerAddHandler, but those ADs allow undefined. That's appropriate for that OSH, but not for the StaticDiscoveryResourceDefinition ADs.
> Also, the RemoteDomainControllerAddHandler AD's could use some clarification and validation as well, e.g. use setRequires(...) on the builder such that each of protocol, host, port requires the other two. So none are required, but if any is set all 3 must be.
> The StaticDiscovery constructor should validate inputs with assert statements and javadoc its parameters, include whether null is allowed. (A null protocol or host will result in an IAE in discover(), so the current code does not support null.)
> The DiscoveryOption interface should document whether the 3 "get" methods can return null.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (WFCORE-565) StaticDiscoveryResourceDefinition allows undefined values for its attributes
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-565?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFCORE-565:
-----------------------------------------
DiscoveryOptionStrategy.DiscoveryOptionComparator will fail if protocol or port are null for any DiscoveryOption.
> StaticDiscoveryResourceDefinition allows undefined values for its attributes
> ----------------------------------------------------------------------------
>
> Key: WFCORE-565
> URL: https://issues.jboss.org/browse/WFCORE-565
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Reporter: Brian Stansberry
>
> StaticDiscoveryResourceDefinition reuses the AttributeDefinitions from RemoteDomainControllerAddHandler, but those ADs allow undefined. That's appropriate for that OSH, but not for the StaticDiscoveryResourceDefinition ADs.
> Also, the RemoteDomainControllerAddHandler AD's could use some clarification and validation as well, e.g. use setRequires(...) on the builder such that each of protocol, host, port requires the other two. So none are required, but if any is set all 3 must be.
> The StaticDiscovery constructor should validate inputs with assert statements and javadoc its parameters, include whether null is allowed. (A null protocol or host will result in an IAE in discover(), so the current code does not support null.)
> The DiscoveryOption interface should document whether the 3 "get" methods can return null.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months