[JBoss JIRA] (WFLY-4839) annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true
by Chao Wang (JIRA)
[ https://issues.jboss.org/browse/WFLY-4839?page=com.atlassian.jira.plugin.... ]
Chao Wang commented on WFLY-4839:
---------------------------------
quickstart reproducer checks that filter did not function with web.xml version 2.4 https://github.com/soul2zimate/quickstart/tree/WFLY-4839-reproducer/servl...
> annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-4839
> URL: https://issues.jboss.org/browse/WFLY-4839
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 10.0.0.Alpha4
> Reporter: Chao Wang
> Assignee: Chao Wang
>
> {noformat}
> ### Description of problem:
> Annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true.
> Note that Servlet 3.0 specification clearly states the following:
> ~~~
> 1.6.2 Processing annotations
> In Servlet 2.5, metadata-complete only affected the scanning of annotations at
> deployment time. The notion of web-fragments did not exist in servlet 2.5. However
> in servlet 3.0 metadata-complete affects scanning of all annotations and web-
> fragments at deployment time. The version of the descriptor MUST not affect which
> annotations you scan for in a web application. An implementation of a particular
> version of the specification MUST scan for all annotations supported in that
> configuration, unless metadata-complete is specified.
> ~~~
> ### How reproducible:
> Anytime
> ### Steps to Reproduce:
> 1. Create a library jar which contains a servlet filter using @WebFilter
> 2. Put the jar under WEB-INF/lib of the web application which web.xml version is 2.3 or 2.4
> 3. Start JBoss EAP 6
> 4. Access the web application and see if the servlet filter works
> ### Actual results:
> The servlet filter is not invoked
> ### Expected results:
> The servlet filter is invoked
> ### Additional info:
> It works when the version of web.xml is 2.5 or 3.0
> [reply] [−]
> Private
> Comment 1 Masafumi Miura 2015-06-25 07:18:17 EDT
> RED HAT CONFIDENTIAL
> It looks metadata-complete is always set to true when the version of web.xml is 2.3 or 2.4 at the line 96 of web/src/main/java/org/jboss/as/web/deployment/WarMetaDataProcessor.java.
> Though Servlet 2.3/2.3 specification does not have metadata-complete attribute, Servlet 3.0 specification states the following. I think it means that the metadata-complete attribute default to false if it is not specified.
> ~~~
> 8.1 Annotations and pluggability
> if the metadata-complete attribute is not specified or is set to "false", the
> deployment tool must examine the class files of the application for annotations, and
> scan for web fragments.
> ~~~
> * web/src/main/java/org/jboss/as/web/deployment/WarMetaDataProcessor.java
> 76 public class WarMetaDataProcessor implements DeploymentUnitProcessor {
> 77
> 78 @Override
> 79 public void deploy(DeploymentPhaseContext phaseContext) throws DeploymentUnitProcessingException {
> ...
> 87 boolean isComplete = false;
> 88 WebMetaData specMetaData = warMetaData.getWebMetaData();
> 89 if (specMetaData != null) {
> 90 if (specMetaData instanceof Web25MetaData) {
> 91 isComplete |= ((Web25MetaData) specMetaData).isMetadataComplete();
> 92 } else if (specMetaData instanceof Web30MetaData) {
> 93 isComplete |= ((Web30MetaData) specMetaData).isMetadataComplete();
> 94 } else {
> 95 // Any web.xml 2.4 or earlier deployment is metadata complete
> 96 isComplete = true;
> 97 }
> 98 }
> 99
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months
[JBoss JIRA] (WFLY-4839) annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true
by Chao Wang (JIRA)
Chao Wang created WFLY-4839:
-------------------------------
Summary: annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true
Key: WFLY-4839
URL: https://issues.jboss.org/browse/WFLY-4839
Project: WildFly
Issue Type: Bug
Components: Web (Undertow)
Affects Versions: 10.0.0.Alpha4
Reporter: Chao Wang
Assignee: Chao Wang
{noformat}
### Description of problem:
Annotation must be scanned regardless of the version of web.xml unless metadata-complete is explicitly set to true.
Note that Servlet 3.0 specification clearly states the following:
~~~
1.6.2 Processing annotations
In Servlet 2.5, metadata-complete only affected the scanning of annotations at
deployment time. The notion of web-fragments did not exist in servlet 2.5. However
in servlet 3.0 metadata-complete affects scanning of all annotations and web-
fragments at deployment time. The version of the descriptor MUST not affect which
annotations you scan for in a web application. An implementation of a particular
version of the specification MUST scan for all annotations supported in that
configuration, unless metadata-complete is specified.
~~~
### How reproducible:
Anytime
### Steps to Reproduce:
1. Create a library jar which contains a servlet filter using @WebFilter
2. Put the jar under WEB-INF/lib of the web application which web.xml version is 2.3 or 2.4
3. Start JBoss EAP 6
4. Access the web application and see if the servlet filter works
### Actual results:
The servlet filter is not invoked
### Expected results:
The servlet filter is invoked
### Additional info:
It works when the version of web.xml is 2.5 or 3.0
[reply] [−]
Private
Comment 1 Masafumi Miura 2015-06-25 07:18:17 EDT
RED HAT CONFIDENTIAL
It looks metadata-complete is always set to true when the version of web.xml is 2.3 or 2.4 at the line 96 of web/src/main/java/org/jboss/as/web/deployment/WarMetaDataProcessor.java.
Though Servlet 2.3/2.3 specification does not have metadata-complete attribute, Servlet 3.0 specification states the following. I think it means that the metadata-complete attribute default to false if it is not specified.
~~~
8.1 Annotations and pluggability
if the metadata-complete attribute is not specified or is set to "false", the
deployment tool must examine the class files of the application for annotations, and
scan for web fragments.
~~~
* web/src/main/java/org/jboss/as/web/deployment/WarMetaDataProcessor.java
76 public class WarMetaDataProcessor implements DeploymentUnitProcessor {
77
78 @Override
79 public void deploy(DeploymentPhaseContext phaseContext) throws DeploymentUnitProcessingException {
...
87 boolean isComplete = false;
88 WebMetaData specMetaData = warMetaData.getWebMetaData();
89 if (specMetaData != null) {
90 if (specMetaData instanceof Web25MetaData) {
91 isComplete |= ((Web25MetaData) specMetaData).isMetadataComplete();
92 } else if (specMetaData instanceof Web30MetaData) {
93 isComplete |= ((Web30MetaData) specMetaData).isMetadataComplete();
94 } else {
95 // Any web.xml 2.4 or earlier deployment is metadata complete
96 isComplete = true;
97 }
98 }
99
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months
[JBoss JIRA] (WFLY-4743) Unable to start server on Windows from path containing special characters jboss-eap-ŽlutýKůň-7.0
by Bartosz Baranowski (JIRA)
[ https://issues.jboss.org/browse/WFLY-4743?page=com.atlassian.jira.plugin.... ]
Bartosz Baranowski resolved WFLY-4743.
--------------------------------------
Resolution: Rejected
> Unable to start server on Windows from path containing special characters jboss-eap-ŽlutýKůň-7.0
> ------------------------------------------------------------------------------------------------
>
> Key: WFLY-4743
> URL: https://issues.jboss.org/browse/WFLY-4743
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Affects Versions: 10.0.0.Alpha2
> Reporter: Marek Kopecký
> Assignee: Bartosz Baranowski
>
> *Description of problem:*
> Server is unable to start if JBOSS_HOME contaings "ŽlutýKůň" characters. This issue is valid for standalone and domain.
> *How reproducible:*
> Windows
> *Steps to Reproduce:*
> * standalone.bat
> * standalone.ps1
> *Actual results:*
> {noformat}
> ....
> Error: Unable to access jarfile C:\Users\Administrator\7.0.0.DR3\jboss-eap-Älut²Kun\jboss-modules.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months
[JBoss JIRA] (WFLY-4838) Add smoke test for cloning profiles in CLI
by Marek Kopecký (JIRA)
Marek Kopecký created WFLY-4838:
-----------------------------------
Summary: Add smoke test for cloning profiles in CLI
Key: WFLY-4838
URL: https://issues.jboss.org/browse/WFLY-4838
Project: WildFly
Issue Type: Task
Components: Test Suite
Reporter: Marek Kopecký
Assignee: Marek Kopecký
https://issues.jboss.org/browse/EAP7-35 provides profile cloning ability (runtime (CLI)) to create new profiles based on existing JBoss profiles (web, full, web-ha, full-ha).
This test serves as basic smoke tests to be run within the testsuite.
CloneProfileTestCase:
* clone default, full, ha, full-ha profiles via CLI
* check results
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months
[JBoss JIRA] (WFLY-4801) When expression is used in jndi name attribute of datasource then test-connection-in-pool operation is not working
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-4801?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-4801:
-----------------------------------------------
Chao Wang <chaowan(a)redhat.com> changed the Status of [bug 1232781|https://bugzilla.redhat.com/show_bug.cgi?id=1232781] from ASSIGNED to POST
> When expression is used in jndi name attribute of datasource then test-connection-in-pool operation is not working
> -------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-4801
> URL: https://issues.jboss.org/browse/WFLY-4801
> Project: WildFly
> Issue Type: Bug
> Components: JCA
> Affects Versions: 10.0.0.Alpha3
> Reporter: Chao Wang
> Assignee: Chao Wang
> Fix For: 9.0.0.Final, 10.0.0.Alpha4
>
>
> {noformat}
> Description of problem:
> ========================
> - Expression is added in the datasource JNDI name attribute as below:
> -----
> <datasource jndi-name="${ds}" pool-name="ExampleDS" enabled="true" use-java-context="true">
> -----
> - Value for the expression is passed to the JBoss server during the JBoss startup as below:
> -----
> ./standalone.sh -Dds=java:jboss/datasources/ExampleDS
> -----
> - In the server.log file below is the information regarding the datasource.
> -----
> INFO [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-3) JBAS010400: Bound data source [${ds}]
> -----
> - Test the datasource using the below command and here is the result:
> ----
> [standalone@localhost:9999 /] /subsystem=datasources/data-source=ExampleDS:test-connection-in-pool()
> {
> "outcome" => "failed",
> "failure-description" => "JBAS010440: failed to invoke operation: JBAS010442: failed to match pool. Check JndiName: java:/${ds}",
> "rolled-back" => true
> }
> ----
> - Here is the information regarding the JNDI name attribute:
> ----
> [standalone@localhost:9999 /] /subsystem=datasources/data-source=ExampleDS:read-resource-description(recursive=true)
> {
> "outcome" => "success",
> "result" => {
> :
> "jndi-name" => {
> "type" => STRING,
> "description" => "Specifies the JNDI name for the datasource",
> "expressions-allowed" => true,
> "nillable" => false,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "no-services"
> },
> :
> }
> -----
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months
[JBoss JIRA] (WFLY-4695) Remove infinispan-query module and its dependencies
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/WFLY-4695?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero commented on WFLY-4695:
---------------------------------------
[~pferraro] What do you prefer, should I take your branch as a starting point for a new pull request?
> Remove infinispan-query module and its dependencies
> ---------------------------------------------------
>
> Key: WFLY-4695
> URL: https://issues.jboss.org/browse/WFLY-4695
> Project: WildFly
> Issue Type: Task
> Components: Clustering
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
>
> We generally expect people to use the version bundled by the Infinispan project, and there are no strong reasons to include this in WildFly.
> Also it makes it much harder to upgrade components such as Hibernate and Infinispan as this components introduces strong coupling on several of these components, essentially mandating that these are all upgraded in lock step.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
8 years, 10 months