[JBoss JIRA] (DROOLS-760) Code style formatters are not up-to-date
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-760?page=com.atlassian.jira.plugin... ]
Petr Široký reassigned DROOLS-760:
----------------------------------
Assignee: (was: Petr Široký)
> Code style formatters are not up-to-date
> ----------------------------------------
>
> Key: DROOLS-760
> URL: https://issues.jboss.org/browse/DROOLS-760
> Project: Drools
> Issue Type: Task
> Reporter: Tibor Zimányi
> Priority: Minor
> Labels: reported-by-qe
> Attachments: code-styleQE.zip
>
>
> Code style formatters in git repo are not actual. Or not widely used. This causes that different styles are used in code.
> There should be some agreement about how the code should be written and this should be forced in PRs. This can remove many problems with whitespaces in PR diffs.
> Attached code style templates can be used as a base for new templates that (hope) will be used in Drools projects.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months
[JBoss JIRA] (DROOLS-746) Window operators - Type safety
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-746?page=com.atlassian.jira.plugin... ]
Petr Široký reassigned DROOLS-746:
----------------------------------
Assignee: (was: Petr Široký)
> Window operators - Type safety
> ------------------------------
>
> Key: DROOLS-746
> URL: https://issues.jboss.org/browse/DROOLS-746
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 6.2.0.Final
> Environment: OS: Mac OS Yosemite 10.10.2
> Java: 1.7.0_75 / 1.8.0_25
> Reporter: Wilson Akio Higashino
>
> It seems the rule compiler is not correctly checking type safety when using window operators to define rule conditions.
> I defined a rule using the following code (note that I incorrectly used "time:window" to define the window, instead of "window:time"):
> declare SensorReading
> @role(event)
> @timestamp(timestamp)
> end
> rule "boilers"
> when
> $b1: (SensorReading(sensorId == 1L && status == SensorStatus.ON) over time:window(10s))
> then
> ....
> end
> The rule has been compiled and executed, but not following the correct window semantics. The forum link contains a full description of the (unexpected) behaviour I found when defining rule like this.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months
[JBoss JIRA] (DROOLS-1121) Run tests with different supported databases
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1121?page=com.atlassian.jira.plugi... ]
Petr Široký reassigned DROOLS-1121:
-----------------------------------
Assignee: (was: Petr Široký)
> Run tests with different supported databases
> --------------------------------------------
>
> Key: DROOLS-1121
> URL: https://issues.jboss.org/browse/DROOLS-1121
> Project: Drools
> Issue Type: Task
> Reporter: Petr Široký
>
> Currently we only run tests with embedded H2 database, which is often not enough, because different databases do slightly different things and thus even if the code works on H2, it does not mean it will work on all supported databases.
> We need to look into testing with multiple databases, preferably using Docker containers as that way we can make sure the databases are always in a clean state (as opposed to using shared DB instances).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months
[JBoss JIRA] (DROOLS-1088) Add spring-jbpm-osgi-example to JBPM repository
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1088?page=com.atlassian.jira.plugi... ]
Petr Široký reassigned DROOLS-1088:
-----------------------------------
Assignee: (was: Petr Široký)
> Add spring-jbpm-osgi-example to JBPM repository
> -----------------------------------------------
>
> Key: DROOLS-1088
> URL: https://issues.jboss.org/browse/DROOLS-1088
> Project: Drools
> Issue Type: Feature Request
> Affects Versions: 6.4.0.CR1
> Reporter: David virgil naranjo
>
> The spring-jbpm-osgi-example is currently placed on Fuse-bxms-integ repository. It will be removed from this repository because it does not contain any kie-camel or another fuse-bxms-integ dependency.
> It is required to include this quickstart and its feature to the jbpm repository:
> <feature name="fuse-bxms-spring-jbpm-osgi-example" version="${project.version}">
> <feature version="${karaf.version.org.kie}">kie-spring</feature>
> <bundle>mvn:org.jboss.integration.fuse.quickstarts/spring-jbpm-osgi-example/${project.version}</bundle>
> </feature>
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months
[JBoss JIRA] (DROOLS-1170) JDK9 with drools: Build: switch back to maven-jaxb2-plugin (but it throws ClassNotFoundException: com.sun.codemodel.CodeWriter)
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1170?page=com.atlassian.jira.plugi... ]
Petr Široký reassigned DROOLS-1170:
-----------------------------------
Assignee: (was: Petr Široký)
> JDK9 with drools: Build: switch back to maven-jaxb2-plugin (but it throws ClassNotFoundException: com.sun.codemodel.CodeWriter)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-1170
> URL: https://issues.jboss.org/browse/DROOLS-1170
> Project: Drools
> Issue Type: Bug
> Components: build
> Reporter: Geoffrey De Smet
> Priority: Minor
> Labels: java9
>
> See
> https://kie-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/kie-all-build-mas...
> {code}
> 13:47:25 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc (default) on project drools-pmml: Execution default of goal org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc failed: A required class was missing while executing org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc: com/sun/codemodel/CodeWriter
> 13:47:25 -----------------------------------------------------
> 13:47:25 realm = plugin>org.codehaus.mojo:jaxb2-maven-plugin:2.2
> 13:47:25 strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> 13:47:25 urls[0] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/mojo/jaxb2-maven-plugin/2.2/jaxb2-maven-plugin-2.2.jar
> 13:47:25 urls[1] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/javax/xml/bind/jaxb-api/2.2.11/jaxb-api-2.2.11.jar
> 13:47:25 urls[2] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-core/2.2.11/jaxb-core-2.2.11.jar
> 13:47:25 urls[3] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-runtime/2.2.11/jaxb-runtime-2.2.11.jar
> 13:47:25 urls[4] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-xjc/2.2.11/jaxb-xjc-2.2.11.jar
> 13:47:25 urls[5] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-jxc/2.2.11/jaxb-jxc-2.2.11.jar
> 13:47:25 urls[6] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/com/thoughtworks/qdox/qdox/2.0-M3/qdox-2.0-M3.jar
> 13:47:25 urls[7] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
> 13:47:25 urls[8] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
> 13:47:25 urls[9] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
> 13:47:25 urls[10] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
> 13:47:25 urls[11] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> 13:47:25 urls[12] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> 13:47:25 urls[13] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> 13:47:25 urls[14] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-compiler-api/2.5/plexus-compiler-api-2.5.jar
> 13:47:25 urls[15] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
> 13:47:25 urls[16] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar
> 13:47:25 Number of foreign imports: 1
> 13:47:25 import: Entry[import from realm ClassRealm[project>org.drools:drools:7.0.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
> 13:47:25
> 13:47:25 -----------------------------------------------------
> 13:47:25
> 13:47:25 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
> 13:47:25 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> 13:47:25 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> 13:47:25 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> 13:47:25 at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:188)
> 13:47:25 at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:184)
> 13:47:25 at java.util.concurrent.FutureTask.run(java.base@9-ea/FutureTask.java:266)
> 13:47:25 at java.util.concurrent.Executors$RunnableAdapter.call(java.base@9-ea/Executors.java:514)
> 13:47:25 at java.util.concurrent.FutureTask.run(java.base@9-ea/FutureTask.java:266)
> 13:47:25 at java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@9-ea/ThreadPoolExecutor.java:1158)
> 13:47:25 at java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@9-ea/ThreadPoolExecutor.java:632)
> 13:47:25 at java.lang.Thread.run(java.base@9-ea/Thread.java:804)
> 13:47:25 Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default of goal org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc failed: A required class was missing while executing org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc: com/sun/codemodel/CodeWriter
> 13:47:25 -----------------------------------------------------
> 13:47:25 realm = plugin>org.codehaus.mojo:jaxb2-maven-plugin:2.2
> 13:47:25 strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> 13:47:25 urls[0] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/mojo/jaxb2-maven-plugin/2.2/jaxb2-maven-plugin-2.2.jar
> 13:47:25 urls[1] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/javax/xml/bind/jaxb-api/2.2.11/jaxb-api-2.2.11.jar
> 13:47:25 urls[2] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-core/2.2.11/jaxb-core-2.2.11.jar
> 13:47:25 urls[3] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-runtime/2.2.11/jaxb-runtime-2.2.11.jar
> 13:47:25 urls[4] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-xjc/2.2.11/jaxb-xjc-2.2.11.jar
> 13:47:25 urls[5] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-jxc/2.2.11/jaxb-jxc-2.2.11.jar
> 13:47:25 urls[6] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/com/thoughtworks/qdox/qdox/2.0-M3/qdox-2.0-M3.jar
> 13:47:25 urls[7] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
> 13:47:25 urls[8] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
> 13:47:25 urls[9] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
> 13:47:25 urls[10] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
> 13:47:25 urls[11] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> 13:47:25 urls[12] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> 13:47:25 urls[13] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> 13:47:25 urls[14] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-compiler-api/2.5/plexus-compiler-api-2.5.jar
> 13:47:25 urls[15] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
> 13:47:25 urls[16] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar
> 13:47:25 Number of foreign imports: 1
> 13:47:25 import: Entry[import from realm ClassRealm[project>org.drools:drools:7.0.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
> 13:47:25
> 13:47:25 -----------------------------------------------------
> 13:47:25
> 13:47:25 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:166)
> 13:47:25 at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> 13:47:25 ... 11 more
> 13:47:25 Caused by: org.apache.maven.plugin.PluginContainerException: A required class was missing while executing org.codehaus.mojo:jaxb2-maven-plugin:2.2:xjc: com/sun/codemodel/CodeWriter
> 13:47:25 -----------------------------------------------------
> 13:47:25 realm = plugin>org.codehaus.mojo:jaxb2-maven-plugin:2.2
> 13:47:25 strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> 13:47:25 urls[0] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/mojo/jaxb2-maven-plugin/2.2/jaxb2-maven-plugin-2.2.jar
> 13:47:25 urls[1] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/javax/xml/bind/jaxb-api/2.2.11/jaxb-api-2.2.11.jar
> 13:47:25 urls[2] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-core/2.2.11/jaxb-core-2.2.11.jar
> 13:47:25 urls[3] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-runtime/2.2.11/jaxb-runtime-2.2.11.jar
> 13:47:25 urls[4] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-xjc/2.2.11/jaxb-xjc-2.2.11.jar
> 13:47:25 urls[5] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/glassfish/jaxb/jaxb-jxc/2.2.11/jaxb-jxc-2.2.11.jar
> 13:47:25 urls[6] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/com/thoughtworks/qdox/qdox/2.0-M3/qdox-2.0-M3.jar
> 13:47:25 urls[7] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
> 13:47:25 urls[8] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
> 13:47:25 urls[9] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
> 13:47:25 urls[10] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
> 13:47:25 urls[11] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> 13:47:25 urls[12] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> 13:47:25 urls[13] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> 13:47:25 urls[14] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-compiler-api/2.5/plexus-compiler-api-2.5.jar
> 13:47:25 urls[15] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/codehaus/plexus/plexus-utils/3.0.22/plexus-utils-3.0.22.jar
> 13:47:25 urls[16] = file:/home/jenkins/workspace/kie-all-build-master-jdk9/.repository/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar
> 13:47:25 Number of foreign imports: 1
> 13:47:25 import: Entry[import from realm ClassRealm[project>org.drools:drools:7.0.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
> 13:47:25
> 13:47:25 -----------------------------------------------------
> 13:47:25
> 13:47:25 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:164)
> 13:47:25 ... 12 more
> 13:47:25 Caused by: java.lang.NoClassDefFoundError: com/sun/codemodel/CodeWriter
> 13:47:25 at org.codehaus.mojo.jaxb2.javageneration.AbstractJavaGeneratorMojo.performExecution(AbstractJavaGeneratorMojo.java:402)
> 13:47:25 at org.codehaus.mojo.jaxb2.AbstractJaxbMojo.execute(AbstractJaxbMojo.java:257)
> 13:47:25 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> 13:47:25 ... 12 more
> 13:47:25 Caused by: java.lang.ClassNotFoundException: com.sun.codemodel.CodeWriter
> 13:47:25 at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> 13:47:25 at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
> 13:47:25 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
> 13:47:25 at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
> 13:47:25 ... 15 more
> {code}
> Looks like we need a newer version of the maven-jaxb2-plugin.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months
[JBoss JIRA] (DROOLS-1217) JDK 9 on drools with module-info: prove that drools-core and drools-compiler works in a 100% module-info.java environment (take them out of the "special" module)
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1217?page=com.atlassian.jira.plugi... ]
Petr Široký reassigned DROOLS-1217:
-----------------------------------
Assignee: (was: Petr Široký)
> JDK 9 on drools with module-info: prove that drools-core and drools-compiler works in a 100% module-info.java environment (take them out of the "special" module)
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-1217
> URL: https://issues.jboss.org/browse/DROOLS-1217
> Project: Drools
> Issue Type: Task
> Components: core engine
> Reporter: Geoffrey De Smet
>
> So far all our OpenJDK 9 tests put drools-core and drools-core in the "special" module. That's basically the anti-module for backwards compatibility. As soon as users start using module-info.java files themselves, there will be a big pressure for us to be a proper module, so to have our own module-info.java's. Because of our extended used of reflection, we need to validate this works long before OpenJDK 9 goes final, so we can still feed it back.
> Reqs:
> Add module-info.java to core and examples jar. Compile and run with both jars on the modulepath (instead of in the special classpath module).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 3 months