[JBoss JIRA] (DROOLS-3465) [DMN Designer] ContextGrid and DecisionTableGrid selectFirstCell() regression
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3465?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3465:
-----------------------------------
Tester: Jozef Marko
Labels: drools-tools (was: )
> [DMN Designer] ContextGrid and DecisionTableGrid selectFirstCell() regression
> -----------------------------------------------------------------------------
>
> Key: DROOLS-3465
> URL: https://issues.jboss.org/browse/DROOLS-3465
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> (Programmatic) selection of the "first cell" in both the {{ContextGrid}} and {{DecisionTableGrid}} has regressed. Selection should ignore the "row number" column however changes adding explicit "Row number columns" for the foregoing grids that do not extend {{RowNumberColumn}} have caused the expected behaviour to break.
> h2. Acceptance criteria
> # Create new Decision
> # Set expression to either {{Context}} or {{DecisionTable}}
> # The whole row should not be selected, only one cell.
> # Check other expression types.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3465) [DMN Designer] ContextGrid and DecisionTableGrid selectFirstCell() regression
by Michael Anstis (Jira)
Michael Anstis created DROOLS-3465:
--------------------------------------
Summary: [DMN Designer] ContextGrid and DecisionTableGrid selectFirstCell() regression
Key: DROOLS-3465
URL: https://issues.jboss.org/browse/DROOLS-3465
Project: Drools
Issue Type: Bug
Components: DMN Editor
Affects Versions: 7.15.0.Final
Reporter: Michael Anstis
Assignee: Michael Anstis
(Programmatic) selection of the "first cell" in both the {{ContextGrid}} and {{DecisionTableGrid}} has regressed. Selection should ignore the "row number" column however changes adding explicit "Row number columns" for the foregoing grids that do not extend {{RowNumberColumn}} have caused the expected behaviour to break.
h2. Acceptance criteria
# Create new Decision
# Set expression to either {{Context}} or {{DecisionTable}}
# The whole row should not be selected, only one cell.
# Check other expression types.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-1781) Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin
by Geoffrey De Smet (Jira)
[ https://issues.jboss.org/browse/DROOLS-1781?page=com.atlassian.jira.plugi... ]
Geoffrey De Smet commented on DROOLS-1781:
------------------------------------------
[~rsynek] Seeing as most of the work is already done by MichaelB I think the sonarcloud future work shouldn't prevent MichaelB from wrapping this up in the present. So let's get this through.
That being said, I am big fan of the sonarcloud work.
> Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin
> ------------------------------------------------------------------------------------
>
> Key: DROOLS-1781
> URL: https://issues.jboss.org/browse/DROOLS-1781
> Project: Drools
> Issue Type: Task
> Components: build
> Affects Versions: 7.4.1.Final
> Reporter: Petr Široký
> Assignee: Michael Biarnes Kiefer
> Priority: Major
> Labels: java9
>
> SpotBugs is a successor of FingBugs and as such uses different groupId + artifactId for maven plugin. It should also be compatible with Java 9 (at least in the latest versions). We need to investigate it the switch is painless and if so, do it. Otherwise we need to figure out what the blockers are and slowly start to fix them as FindBugs itself won't bet any more updates it seems and so won't be Java 9 compatible.
> *How to migrate*
> * Replace
> {code}
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>findbugs-maven-plugin</artifactId>
> {code}
> by
> {code}
> <groupId>com.github.spotbugs</groupId>
> <artifactId>spotbugs-maven-plugin</artifactId>
> {code}
> * Look for all "findbugs" and replace it by "spotbugs"
> ** Except for anything related to the findbugs annotations dependency that some dependencies drag in or exclude. Leave that one alone!
> ** For example, change findbugs-check -> spotbugs-check, ...
> * Merge this PR if it hasn't been merged already: https://github.com/kiegroup/optaplanner-wb/pull/320
> * Then you only need to adjust the following repo's: build-boostrap, drools, optaplanner and kie-wb-distributions.
> ** See https://github.com/search?q=org%3Akiegroup+findbugs-maven-plugin&type=Code
> ** Ignore contributed experiments, that repo is dead
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-1781) Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin
by Radovan Synek (Jira)
[ https://issues.jboss.org/browse/DROOLS-1781?page=com.atlassian.jira.plugi... ]
Radovan Synek commented on DROOLS-1781:
---------------------------------------
With SonarCloud showing up in some repositories - and my plan is to integrate it to entire KIE group - findbugs/spotbugs becomes a redundant tool. The only benefit of keeping this plugin is to provide some level of checking to developers even before they open a PR.
> Investigate possible replacement of findbugs-maven-plugin with spotbugs-maven-plugin
> ------------------------------------------------------------------------------------
>
> Key: DROOLS-1781
> URL: https://issues.jboss.org/browse/DROOLS-1781
> Project: Drools
> Issue Type: Task
> Components: build
> Affects Versions: 7.4.1.Final
> Reporter: Petr Široký
> Assignee: Michael Biarnes Kiefer
> Priority: Major
> Labels: java9
>
> SpotBugs is a successor of FingBugs and as such uses different groupId + artifactId for maven plugin. It should also be compatible with Java 9 (at least in the latest versions). We need to investigate it the switch is painless and if so, do it. Otherwise we need to figure out what the blockers are and slowly start to fix them as FindBugs itself won't bet any more updates it seems and so won't be Java 9 compatible.
> *How to migrate*
> * Replace
> {code}
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>findbugs-maven-plugin</artifactId>
> {code}
> by
> {code}
> <groupId>com.github.spotbugs</groupId>
> <artifactId>spotbugs-maven-plugin</artifactId>
> {code}
> * Look for all "findbugs" and replace it by "spotbugs"
> ** Except for anything related to the findbugs annotations dependency that some dependencies drag in or exclude. Leave that one alone!
> ** For example, change findbugs-check -> spotbugs-check, ...
> * Merge this PR if it hasn't been merged already: https://github.com/kiegroup/optaplanner-wb/pull/320
> * Then you only need to adjust the following repo's: build-boostrap, drools, optaplanner and kie-wb-distributions.
> ** See https://github.com/search?q=org%3Akiegroup+findbugs-maven-plugin&type=Code
> ** Ignore contributed experiments, that repo is dead
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3420) Replace Composite for SourceTypeSelector/TitledAttachmentFileWidget
by Klara Kufova (Jira)
[ https://issues.jboss.org/browse/DROOLS-3420?page=com.atlassian.jira.plugi... ]
Klara Kufova updated DROOLS-3420:
---------------------------------
Description:
SourceTypeSelector and TitledAttachmentFileWidget extends Composite, while we are currently strive to move toward new Elemental. At the same time, the list where they are using is expecting a IsWidget type. So, try if already a similar widget exists inside appformer/kie, otherwise create new one and (eventually) implement the asWidget method and returns a "Widget".
Later, ask [~Rikkola] to move it on upper framework.
*ADDITIONAL IMPROVEMENTS:*
# When there are two {{.dmn}} files in the project, the second one is not in the list when creating a new test scenario asset. *The list must be refreshed to contain all available {{.dmn}} files.* The same problem occurs also with a single {{.dmn}} file in the project. Sometimes the list of available {{.dmn}} files is not refreshed and even though they are in the project, they are not displayed in the list.
# Change *Choose DMN asset* to *Choose a DMN asset*.
# The box for choosing a {{.dmn}} file is not wide enough. Make it either as wide as the boxes above (for the name of the asset and the package) or change it to a drop down (the same style as the package drop down).
# The value of a {{.dmn}} file should not be pre-filled once the box has been used. Clear the status so the box is always empty.
was:
SourceTypeSelector and TitledAttachmentFileWidget extends Composite, while we are currently strive to move toward new Elemental. At the same time, the list where they are using is expecting a IsWidget type. So, try if already a similar widget exists inside appformer/kie, otherwise create new one and (eventually) implement the asWidget method and returns a "Widget".
Later, ask [~Rikkola] to move it on upper framework.
*ADDITIONAL IMPROVEMENTS:*
# When there are two {{.dmn}} files in the project, the second one is not in the list when creating a new test scenario asset. The list must be refreshed to contain all available {{.dmn}} files.
# Change *Choose DMN asset* to *Choose a DMN asset*.
# The box for choosing a {{.dmn}} file is not wide enough. Make it either as wide as the boxes above (for the name of the asset and the package) or change it to a drop down (the same style as the package drop down).
# The value of a {{.dmn}} file should not be pre-filled once the box has been used. Clear the status so the box is always empty.
> Replace Composite for SourceTypeSelector/TitledAttachmentFileWidget
> -------------------------------------------------------------------
>
> Key: DROOLS-3420
> URL: https://issues.jboss.org/browse/DROOLS-3420
> Project: Drools
> Issue Type: Task
> Components: Scenario Simulation and Testing
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Minor
>
> SourceTypeSelector and TitledAttachmentFileWidget extends Composite, while we are currently strive to move toward new Elemental. At the same time, the list where they are using is expecting a IsWidget type. So, try if already a similar widget exists inside appformer/kie, otherwise create new one and (eventually) implement the asWidget method and returns a "Widget".
> Later, ask [~Rikkola] to move it on upper framework.
> *ADDITIONAL IMPROVEMENTS:*
> # When there are two {{.dmn}} files in the project, the second one is not in the list when creating a new test scenario asset. *The list must be refreshed to contain all available {{.dmn}} files.* The same problem occurs also with a single {{.dmn}} file in the project. Sometimes the list of available {{.dmn}} files is not refreshed and even though they are in the project, they are not displayed in the list.
> # Change *Choose DMN asset* to *Choose a DMN asset*.
> # The box for choosing a {{.dmn}} file is not wide enough. Make it either as wide as the boxes above (for the name of the asset and the package) or change it to a drop down (the same style as the package drop down).
> # The value of a {{.dmn}} file should not be pre-filled once the box has been used. Clear the status so the box is always empty.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3451) [DMN Designer] Function: Not possible to select _expression_ cell
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3451?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3451:
----------------------------------------
[~jomarko] Thanks, the criteria looks good to me.
> [DMN Designer] Function: Not possible to select _expression_ cell
> -----------------------------------------------------------------
>
> Key: DROOLS-3451
> URL: https://issues.jboss.org/browse/DROOLS-3451
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: function-grid-left-click.png, function-grid-right-click.png
>
>
> It is not possible to select the {{FunctionGrid}} _expression_ cell.
> Left-single-click does not select cell:
> !function-grid-left-click.png|thumbnail!
> Whereas right-single-click does (and shows _context_ menu):
> !function-grid-right-click.png|thumbnail!
> It should be possible to select the cell with single-left-click too.
> h2. Acceptance criteria
> Select function expression cell by
> - Left Single click
> - Right Single click
> - Keyboard navigation
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3451) [DMN Designer] Function: Not possible to select _expression_ cell
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3451?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3451:
--------------------------------
Description:
It is not possible to select the {{FunctionGrid}} _expression_ cell.
Left-single-click does not select cell:
!function-grid-left-click.png|thumbnail!
Whereas right-single-click does (and shows _context_ menu):
!function-grid-right-click.png|thumbnail!
It should be possible to select the cell with single-left-click too.
h2. Acceptance criteria
Select function expression cell by
- Left Single click
- Right Single click
- Keyboard navigation
was:
It is not possible to select the {{FunctionGrid}} _expression_ cell.
Left-single-click does not select cell:
!function-grid-left-click.png|thumbnail!
Whereas right-single-click does (and shows _context_ menu):
!function-grid-right-click.png|thumbnail!
It should be possible to select the cell with single-left-click too.
> [DMN Designer] Function: Not possible to select _expression_ cell
> -----------------------------------------------------------------
>
> Key: DROOLS-3451
> URL: https://issues.jboss.org/browse/DROOLS-3451
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: function-grid-left-click.png, function-grid-right-click.png
>
>
> It is not possible to select the {{FunctionGrid}} _expression_ cell.
> Left-single-click does not select cell:
> !function-grid-left-click.png|thumbnail!
> Whereas right-single-click does (and shows _context_ menu):
> !function-grid-right-click.png|thumbnail!
> It should be possible to select the cell with single-left-click too.
> h2. Acceptance criteria
> Select function expression cell by
> - Left Single click
> - Right Single click
> - Keyboard navigation
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3451) [DMN Designer] Function: Not possible to select _expression_ cell
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3451?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3451:
-------------------------------------
[~manstis] [~dadossan] I added acceptace criteria for this issue, let me know if they are valid from your point of view.
> [DMN Designer] Function: Not possible to select _expression_ cell
> -----------------------------------------------------------------
>
> Key: DROOLS-3451
> URL: https://issues.jboss.org/browse/DROOLS-3451
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: function-grid-left-click.png, function-grid-right-click.png
>
>
> It is not possible to select the {{FunctionGrid}} _expression_ cell.
> Left-single-click does not select cell:
> !function-grid-left-click.png|thumbnail!
> Whereas right-single-click does (and shows _context_ menu):
> !function-grid-right-click.png|thumbnail!
> It should be possible to select the cell with single-left-click too.
> h2. Acceptance criteria
> Select function expression cell by
> - Left Single click
> - Right Single click
> - Keyboard navigation
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3451) [DMN Designer] Function: Not possible to select _expression_ cell
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3451?page=com.atlassian.jira.plugi... ]
Jozef Marko edited comment on DROOLS-3451 at 1/2/19 4:39 AM:
-------------------------------------------------------------
[~manstis] [~dadossan] I added acceptance criteria for this issue, let me know if they are valid from your point of view.
was (Author: jomarko):
[~manstis] [~dadossan] I added acceptace criteria for this issue, let me know if they are valid from your point of view.
> [DMN Designer] Function: Not possible to select _expression_ cell
> -----------------------------------------------------------------
>
> Key: DROOLS-3451
> URL: https://issues.jboss.org/browse/DROOLS-3451
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: function-grid-left-click.png, function-grid-right-click.png
>
>
> It is not possible to select the {{FunctionGrid}} _expression_ cell.
> Left-single-click does not select cell:
> !function-grid-left-click.png|thumbnail!
> Whereas right-single-click does (and shows _context_ menu):
> !function-grid-right-click.png|thumbnail!
> It should be possible to select the cell with single-left-click too.
> h2. Acceptance criteria
> Select function expression cell by
> - Left Single click
> - Right Single click
> - Keyboard navigation
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (DROOLS-3451) [DMN Designer] Function: Not possible to select _expression_ cell
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3451?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3451:
--------------------------------
Tester: Jozef Marko
> [DMN Designer] Function: Not possible to select _expression_ cell
> -----------------------------------------------------------------
>
> Key: DROOLS-3451
> URL: https://issues.jboss.org/browse/DROOLS-3451
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: function-grid-left-click.png, function-grid-right-click.png
>
>
> It is not possible to select the {{FunctionGrid}} _expression_ cell.
> Left-single-click does not select cell:
> !function-grid-left-click.png|thumbnail!
> Whereas right-single-click does (and shows _context_ menu):
> !function-grid-right-click.png|thumbnail!
> It should be possible to select the cell with single-left-click too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months