[JBoss JIRA] (DROOLS-4799) Adding "expression" type handling for Collection type propereties
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-4799?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-4799:
-------------------------------------------
[~yamer] My initial leaning though is to:
* If a user starts to input data inside a section (Define List/Create List) and then switch on the other one, imo the fields should clear out. We could add an inline notification if there's a concerning this will be unexpected for the user.
* After adding a Collection, the Grid cell will show "List (1)". It should be the same for "Define list" (i.e. Expression) case? - I'm not sure I'm following the question, the mockups illustrates this (is that what you're talking about)
!Screen Shot 2019-11-26 at 1.26.54 PM.png|thumbnail!
> Adding "expression" type handling for Collection type propereties
> -----------------------------------------------------------------
>
> Key: DROOLS-4799
> URL: https://issues.jboss.org/browse/DROOLS-4799
> Project: Drools
> Issue Type: Feature Request
> Components: Scenario Simulation and Testing, Test Scenarios Editor
> Reporter: Yeser Amer
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam
> Attachments: Screen Shot 2019-11-26 at 1.26.54 PM.png
>
>
> I need a clarification regarding the behaviour of the updated Collection Editor, in particular for this section -->https://marvelapp.com/5ab248j/screen/62093042/layer/102496330.
> Considering the editor introduces a new way to handle a Collection ("Define List"), can you please give us detailed behaviour for the following case:
> - What happen if a user starts to input data inside a section (Define List/Create List) and then switch on the other one?
> eg. if I start to define a List using "Define List" option (i.e. an expression) and then I change to "Create List" case. What should happen?
> - Currently, after adding a Collection, the Grid cell will show "List (1)". It should be the same for "Define list" (i.e. Expression) case?
> In case of additional clarificaiton, I'll update this ticket.
> Hope it's clear, if not you can contact me anytime.
> Thanks
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4799) Adding "expression" type handling for Collection type propereties
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-4799?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-4799:
-------------------------------------------
[~yamer] I understand, but I just haven't been able to replicate that view on the CICD. So would like the video to refer to instead.
> Adding "expression" type handling for Collection type propereties
> -----------------------------------------------------------------
>
> Key: DROOLS-4799
> URL: https://issues.jboss.org/browse/DROOLS-4799
> Project: Drools
> Issue Type: Feature Request
> Components: Scenario Simulation and Testing, Test Scenarios Editor
> Reporter: Yeser Amer
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam
>
> I need a clarification regarding the behaviour of the updated Collection Editor, in particular for this section -->https://marvelapp.com/5ab248j/screen/62093042/layer/102496330.
> Considering the editor introduces a new way to handle a Collection ("Define List"), can you please give us detailed behaviour for the following case:
> - What happen if a user starts to input data inside a section (Define List/Create List) and then switch on the other one?
> eg. if I start to define a List using "Define List" option (i.e. an expression) and then I change to "Create List" case. What should happen?
> - Currently, after adding a Collection, the Grid cell will show "List (1)". It should be the same for "Define list" (i.e. Expression) case?
> In case of additional clarificaiton, I'll update this ticket.
> Hope it's clear, if not you can contact me anytime.
> Thanks
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4810) KIE Server REST Command GetObjects with ObjectFilter not working
by Martin Weiler (Jira)
Martin Weiler created DROOLS-4810:
-------------------------------------
Summary: KIE Server REST Command GetObjects with ObjectFilter not working
Key: DROOLS-4810
URL: https://issues.jboss.org/browse/DROOLS-4810
Project: Drools
Issue Type: Bug
Components: kie server
Affects Versions: 7.15.0.Final
Environment: RHEL 7.5, EAP 7.1.0, Drools 7.15.0.Final
Reporter: Martin Weiler
Assignee: Mario Fusco
Filtering the facts in the GetObjectsCommand doesn't do any object filtering!.
Here are the two code pieces that were used to set the ObjectFilter into GetObjectsCommand, but didn't produce the expected filtered results.
*+Trial 1:+*
{code:java}
ObjectFilter filter = new ObjectFilter() {
@Override
public boolean accept(Object object) {
return object.getClass().getName().equals("a.b.c.PotentialFraudFact");
}
};
Command<?> getObjects = commandsFactory.newGetObjects(filter, "out");
{code}
*+Trial 2:+*
{code:java}
ClassObjectSerializationFilter filter = new ClassObjectSerializationFilter(PotentialFraudFact.class);
Command<?> getObjects = commandsFactory.newGetObjects(filter, "out");
{code}
In the response, the "out" identifier has *all* facts, not just the ones matching the given filter. It's as if it ignores the filter. Also, no error messages appear in the console.
When a ClassObjectFilter is used instead of the aforementioned implementations, a ClassNotFoundException (_shown below_) for the a.b.c.PotentialFraudFact.class occurs. This is incorrect as the deployed container/KJAR has this class!.
{code:java}
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: a.b.c.PotentialFraudFact from [Module "deployment.kie-server.war" from Service Module Loader]
at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:198)
at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:412)
at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:400)
at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:116)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at org.drools.core.ClassObjectSerializationFilter.accept(ClassObjectSerializationFilter.java:50)
... 73 more
{code}
The issue is with this line https://github.com/kiegroup/drools/blob/4c6856223b8be47b4fc52c35423be8b50... where the class loader used to find the class couldn't find the class that corresponds to the given Fact.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (WFWIP-160) Fix throughput and response time differences between TLS 1.2 and TLS 1.3
by David Lloyd (Jira)
[ https://issues.jboss.org/browse/WFWIP-160?page=com.atlassian.jira.plugin.... ]
David Lloyd commented on WFWIP-160:
-----------------------------------
It looks like it is spending the majority of time in JDK cryptographic functions. There might not be a lot that we can do about that (beyond requesting backports of TLS performance improvements to jdk11u, which is something we can ask [~aph] about, or using the TLSv1.3 support in {{wildfly-openssl}} as previously mentioned).
It would be interesting to compare OpenSSL performance here to see if it is an implementation issue, or if it is likely to be something inherent in the selected cipher suite.
> Fix throughput and response time differences between TLS 1.2 and TLS 1.3
> ------------------------------------------------------------------------
>
> Key: WFWIP-160
> URL: https://issues.jboss.org/browse/WFWIP-160
> Project: WildFly WIP
> Issue Type: Task
> Components: Web (Undertow)
> Reporter: Farah Juma
> Assignee: Richard Opalka
> Priority: Blocker
> Attachments: jstourac-report.zip, performance-hotspot.png, results-tlsv12.zip, results-tlsv13.zip
>
>
> Performance with TLS 1.3 on WildFly appears to be worse than with TLS 1.2. In particular, throughput is much lower (roughly three times lower) and response time is much higher (roughly three times higher), which is not supposed to be the case. The underlying issue seems to be in Undertow or XNIO, that is the code that actually gets invoked during the TLS handshake process. Looking at CPU time, there is significantly more time being spent in [io.undertow.protocols.ssl.SslConduit$5.run()|https://github.com/undertow-...] with TLS 1.3 than with TLS 1.2.
> Steps to reproduce (taken from EAP7-1022):
> 1. Build WildFly using the following feature branches or download a QE build of WildFly [here|https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/undertow-...]:
> https://github.com/fjuma/wildfly-elytron/tree/ELY-1706
> https://github.com/fjuma/wildfly-core/tree/WFCORE-4172 (Update the Elytron version in the pom.xml file to use the version built in the previous step)
> https://github.com/fjuma/wildfly/tree/WFCORE-4172 (Update the Core version in the pom.xml file to use the version built in the previous step)
> 2. Download and unzip JMeter from https://jmeter.apache.org/download_jmeter.cgi
> 3. Download attached test plan [TLSv1.3.jmx|https://issues.jboss.org/secure/attachment/12449098/12449098_...]
> 4. Start server with JDK11 and configure with TLSv1.3:
> {code}
> $ JAVA_HOME=/path/to/java/openjdk-11.0.2 <EAP_HOME>/bin/standalone.sh
> $ <EAP_HOME>/bin/jboss-cli.sh -c
> /subsystem=elytron/key-store=tls13:add(path=keystore.jks,relative-to=jboss.server.config.dir,credential-reference={clear-text=secret},type=JKS)
> /subsystem=elytron/key-store=tls13:generate-key-pair(alias=localhost,algorithm=RSA,key-size=1024,validity=365,credential-reference={clear-text=secret},distinguished-name="CN=localhost")
> /subsystem=elytron/key-store=tls13:store()
> /subsystem=elytron/key-manager=tls13:add(key-store=tls13,credential-reference={clear-text=secret})
> /subsystem=elytron/server-ssl-context=tls13:add(key-manager=tls13,protocols=["TLSv1.3"])
> batch
> /subsystem=undertow/server=default-server/https-listener=https:undefine-attribute(name=security-realm)
> /subsystem=undertow/server=default-server/https-listener=https:write-attribute(name=ssl-context,value=tls13)
> run-batch
> reload
> {code}
> 5. Start jmeter with JDK 11 and downloaded test plan
> {code}
> export JAVA_HOME=/path/to/java/openjdk-11.0.2; bin/jmeter -n -t TLSv1.3.jmx -e -l tlsv13.log -o results-tlsv13
> {code}
> 6. Set server to use TLSv1.2
> {code}
> /subsystem=elytron/server-ssl-context=tls13:write-attribute(name=protocols,value=["TLSv1.2"])
> reload
> {code}
> 7. Repeat same for TLSv1.2
> {code}
> export JAVA_HOME=/path/to/java/openjdk-11.0.2; bin/jmeter -n -t TLSv1.3.jmx -e -l tlsv12.log -o results-tlsv12
> {code}
> 8. Compare results (there will be an index.html file in the results-tlsv12 and results-tlsv13 directories)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4808) [DMN Designer] Time Constraint picker remains shown
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-4808?page=com.atlassian.jira.plugi... ]
Michael Anstis edited comment on DROOLS-4808 at 11/26/19 11:47 AM:
-------------------------------------------------------------------
[~jomarko] Did you compile both PRs for KOGITO-523?
I ask as I see a list of time zones in the "time-zone/time-offset picker" whereas your video shows it empty.
That said this JIRA has nothing to do with the changes for time-zone handling in kogito and exists equally in Business Central.
Reassigning to [~karreiro].
was (Author: manstis):
[~jomarko] Did you compile both PRs for KOGITO-523?
I ask as I see a list of time zones in the "timzeone/timeoffset picker" whereas your video shows it empty.
That said this JIRA has nothing to do with the changes for time-zone handling in kogito and exists equally in Business Central.
Reassigning to [~karreiro].
> [DMN Designer] Time Constraint picker remains shown
> ---------------------------------------------------
>
> Key: DROOLS-4808
> URL: https://issues.jboss.org/browse/DROOLS-4808
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.31.0.Final
> Reporter: Jozef Marko
> Assignee: karreiro
> Priority: Optional
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-26 16-44-21.png, time-range-2.webm
>
>
> See the attached video, there is scenario, when a timzeone/timeofset picker remains shown.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4808) [DMN Designer] Time Constraint picker remains shown
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-4808?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-4808:
----------------------------------------
[~jomarko] Did you compile both PRs for KOGITO-523?
I ask as I see a list of time zones in the "timzeone/timeoffset picker" whereas your video shows it empty.
That said this JIRA has nothing to do with the changes for time-zone handling in kogito and exists equally in Business Central.
Reassigning to [~karreiro].
> [DMN Designer] Time Constraint picker remains shown
> ---------------------------------------------------
>
> Key: DROOLS-4808
> URL: https://issues.jboss.org/browse/DROOLS-4808
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.31.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Optional
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-26 16-44-21.png, time-range-2.webm
>
>
> See the attached video, there is scenario, when a timzeone/timeofset picker remains shown.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months