[Red Hat JIRA] (DROOLS-5880) Revisit Kie/Drools maven archetype
by Matteo Mortari (Jira)
Matteo Mortari created DROOLS-5880:
--------------------------------------
Summary: Revisit Kie/Drools maven archetype
Key: DROOLS-5880
URL: https://issues.redhat.com/browse/DROOLS-5880
Project: Drools
Issue Type: Story
Components: integration
Reporter: Matteo Mortari
Assignee: Mario Fusco
*Motivation*: currently the only 1 available Kie maven archetype for Drools shows sign of age.
*Goals*: reconsidering the following aspects:
* contains only a mirror test (generated folder/file structure) but doesn't actually "use" the generated project so if it breaks we don't know. Potentially add a maven invoker test in droolsjbpm-integration to check it.
* License header: do as Camel / Quarkus do, the end result, the user files, do NOT contain a Red Hat license header. Can be resolved by template engine comment like Camel team did.
* the current Drools unit test is not very significative, always check that "type==color" maybe add some Measurement not of type color to get the test more significative
* currently Stateful Vs CEP test is governed by variable during archetype generation. Experience shows this is overlooked. It is best to actually separate this into 2 separate Archetypes.
* currently defines Eclipse IDE exclusion in the generated pom.xml, maybe just easier to:
** always generate it
** bring that into the kie-maven-plugin, albeit it may require providing the xml file manually. Here it could be worthy to check how Quarkus team resolved this issue
*Impacts*: archetypes are directly used by end-users when creating a project, but IIRC there is no mention in the Docs (for "v7x series" / Kie)
/cc [~lucamolteni][~danielezonca]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 5 months
[Red Hat JIRA] (DROOLS-5878) Fix "ApplyPmmlModelCommand.isMining()" implementation
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5878?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-5878:
-------------------------------------
Description:
Currently, ApplyPmmlModelCommand.isMining() is a little bit contrived and SONAR raise warning
Fix it and add appropriate test
was:
Currently, ApplyPmmlModelCommand.isMining() has two main issues
1) is contrived
2) it seems to return wrong values due to a doubled/wrong negation
{code:java}
if (hasMining == null || !hasMining.booleanValue() == false) {
return false;
{code}
Fix it and add appropriate test
> Fix "ApplyPmmlModelCommand.isMining()" implementation
> -----------------------------------------------------
>
> Key: DROOLS-5878
> URL: https://issues.redhat.com/browse/DROOLS-5878
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Critical
> Labels: TrustyAI
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Currently, ApplyPmmlModelCommand.isMining() is a little bit contrived and SONAR raise warning
> Fix it and add appropriate test
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 5 months
[Red Hat JIRA] (DROOLS-5879) Optional newline handling in MVEL parser
by Edoardo Vacchi (Jira)
Edoardo Vacchi created DROOLS-5879:
--------------------------------------
Summary: Optional newline handling in MVEL parser
Key: DROOLS-5879
URL: https://issues.redhat.com/browse/DROOLS-5879
Project: Drools
Issue Type: Enhancement
Components: core engine
Reporter: Edoardo Vacchi
Assignee: Edoardo Vacchi
MVEL parser explicitly handles newlines so that statements can be terminated automatically without semicolons.
However, in some situations this is not necessary. For instance, while parsing constraints, newlines should be treated as non-significant whitespace.
We add support to a new lexer state, that can be switched at run-time (parser instantiation time), to allow for whitespace to be fully ignored, newlines included.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 5 months
[Red Hat JIRA] (DROOLS-5878) Fix "ApplyPmmlModelCommand.isMining()" implementation
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-5878:
----------------------------------------
Summary: Fix "ApplyPmmlModelCommand.isMining()" implementation
Key: DROOLS-5878
URL: https://issues.redhat.com/browse/DROOLS-5878
Project: Drools
Issue Type: Task
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Currently, ApplyPmmlModelCommand.isMining() has two main issues
1) is contrived
2) it seems to return wrong values due to a doubled/wrong negation
{code:java}
if (hasMining == null || !hasMining.booleanValue() == false) {
return false;
{code}
Fix it and add appropriate test
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 5 months