[JBoss JIRA] (DROOLS-4605) DMN alpha network
by Luca Molteni (Jira)
[ https://issues.redhat.com/browse/DROOLS-4605?page=com.atlassian.jira.plug... ]
Luca Molteni reassigned DROOLS-4605:
------------------------------------
Assignee: Luca Molteni (was: Matteo Mortari)
> DMN alpha network
> -----------------
>
> Key: DROOLS-4605
> URL: https://issues.redhat.com/browse/DROOLS-4605
> Project: Drools
> Issue Type: Epic
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Luca Molteni
> Priority: Major
>
> *Motivation*: a DMN decision table can be evaluated faster than naive algorithm by translating it into a Rete/Phreak, but the current kie7 approach is suffering from performance bottleneck artificially induced by use of kie7 rule units, which provide more harm than benefit to perfomance (performance is actually worst for most "realistic" cases).
> *Goals*: a POC to understand what’s need to be done to support the alpha network compiler (wihout kie7 rule units) in DMN. We currently estimate it will take us 1 to 2 summer sprints and the output will be more epics to implement this feature.
> *Impact*: alpha network compiler code refactors for the better use of.
> One part of the POC was to hard-code the alpha network for a specific table ([DROOLS-4566]) the remained of the poc is to generalize the approach further to fully assess the impacts thanks to the poc.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (WFLY-13730) WFLY-9440 fix breaks Galleon provisioning
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-13730:
---------------------------------------
Summary: WFLY-9440 fix breaks Galleon provisioning
Key: WFLY-13730
URL: https://issues.redhat.com/browse/WFLY-13730
Project: WildFly
Issue Type: Bug
Components: Build System, EJB
Reporter: Brian Stansberry
Assignee: Brian Stansberry
The WFLY-9440 fix breaks server provisioning in my EE9 branch. This is because the feature-spec Galleon generates for the resource doesn't comprehend that the value of the 'enable-jacc' attribute is not relevant to the required capability so it expects to find a 'org.wildfly.security.jacc-policy.false' capability.
I'm not sure why it doesn't break things elsewhere.
There are a few possible ways to deal with this:
1) Don't register BooleanCapabilityReferenceRecorder with the ENABLE_JACC AttributeDefinition; instead manually do its work in the add/remove/write-attribute handlers. This essentially hides the capability relationship from Galleon by removing it from the resource description metadata and seems to work.
2) Have BooleanCapabilityReferenceRecorder correctly implement getRequirementPatternSegments to return an empty array. Perhaps this alone would fix it, but I doubt it.
3) Combine #2 with a change of some sort in WildFly Core's ReadFeatureDescriptionHandler to better understand and deal with this particular pattern.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (DROOLS-2638) Enumerations drop quotes when double quotes are used
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-2638?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-2638:
--------------------------------
Labels: drools-tools (was: )
> Enumerations drop quotes when double quotes are used
> ----------------------------------------------------
>
> Key: DROOLS-2638
> URL: https://issues.redhat.com/browse/DROOLS-2638
> Project: Drools
> Issue Type: Bug
> Components: Enumerations Editor
> Affects Versions: 7.42.0.Final
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools
>
> https://github.com/kiegroup/kie-wb-common/pull/1890
> @Rikkola The issue reported in the JIRA seem to be resolved; however I noticed (given an enumeration defined as Person.name: ['a', '"b, c"', 'd']) that the generated DRL is Person( name == "b, c" ) whereas should it be Person( name == "\"b, c\"" )? Closing and re-opening the decision table keeps the correct values selected in the table. I also tried defining the BRL fragment to use a literal value for the enumeration and this gave the same results (DRL possibly incorrect, but re-opening and editing the column was OK).
> I also checked Guided Rules and the DRL is equally wrong however re-opening the rule also led to the wrong enumeration value being selected in the editor (it selected the first option by default) and the DRL showing the same (i.e. I set it to "b, c" and re-opening the file selected a).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (DROOLS-2638) Enumerations drop quotes when double quotes are used
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-2638?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-2638:
--------------------------------
Affects Version/s: 7.42.0.Final
> Enumerations drop quotes when double quotes are used
> ----------------------------------------------------
>
> Key: DROOLS-2638
> URL: https://issues.redhat.com/browse/DROOLS-2638
> Project: Drools
> Issue Type: Bug
> Components: Enumerations Editor
> Affects Versions: 7.42.0.Final
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
>
> https://github.com/kiegroup/kie-wb-common/pull/1890
> @Rikkola The issue reported in the JIRA seem to be resolved; however I noticed (given an enumeration defined as Person.name: ['a', '"b, c"', 'd']) that the generated DRL is Person( name == "b, c" ) whereas should it be Person( name == "\"b, c\"" )? Closing and re-opening the decision table keeps the correct values selected in the table. I also tried defining the BRL fragment to use a literal value for the enumeration and this gave the same results (DRL possibly incorrect, but re-opening and editing the column was OK).
> I also checked Guided Rules and the DRL is equally wrong however re-opening the rule also led to the wrong enumeration value being selected in the editor (it selected the first option by default) and the DRL showing the same (i.e. I set it to "b, c" and re-opening the file selected a).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (DROOLS-5521) OutOfBound Exception for last DecisionTable cell
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5521?page=com.atlassian.jira.plug... ]
Jozef Marko commented on DROOLS-5521:
-------------------------------------
[~manstis] seems related, I will double check if DROOLS-5521 fixes DROOLS-5543.
> OutOfBound Exception for last DecisionTable cell
> ------------------------------------------------
>
> Key: DROOLS-5521
> URL: https://issues.redhat.com/browse/DROOLS-5521
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.41.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Priority: Major
> Labels: drools-tools, regression
> Attachments: edit-last-cell-of-row-and-press-tab.webm
>
>
> This issue is caused by DROOLS-5442.
> It can be spotted when user start to edit last cell of DMN Decision table row and finish the edit mode by pressing TAB key. It causes an attempt to select next cell of the row and an exception is thrown. See the attached video.
> h3. Acceptance criteria
> Check pressing TAB when edit mode of last cell is active for:
> - Guided Decision Table
> - Test Scenario
> - DMN Decision Table
> - DMN Relation
> - DMN Context
> - DMN Function
> - DMN Literal Expression
> - DMN List
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (WFLY-13697) JBoss CLI can't find java:app/AppName
by Michal Petrov (Jira)
[ https://issues.redhat.com/browse/WFLY-13697?page=com.atlassian.jira.plugi... ]
Michal Petrov commented on WFLY-13697:
--------------------------------------
[~cfang], CLI and web console execute jobs the same way. If you're working on that one I'll resolve this as duplicate.
> JBoss CLI can't find java:app/AppName
> -------------------------------------
>
> Key: WFLY-13697
> URL: https://issues.redhat.com/browse/WFLY-13697
> Project: WildFly
> Issue Type: Bug
> Components: Batch, Management
> Affects Versions: JBoss AS7 7.2.0.Final
> Reporter: José Fernando Tepedino Martins
> Assignee: Michal Petrov
> Priority: Minor
> Labels: CLI, JNDI
>
> With a JEE aplication in a WAR package, when starting a functionality, as a Batch Job, via CLI, CDI injection and JNDI lookup fail to find resources 'java:app/AppName' and 'java:module/ModuleName'.
> For example, a job listener or other job artifact with the following code
> {code:java}
> @Resource(lookup="java:app/AppName")
> private String applicationName;{code}
> or
> {code:java}
> private String applicationName;
> @PostConstruct
> protected void initialize() throws NamingException {
> applicationName = InitialContext.doLookup("java:app/AppName");
> }{code}
> when the batch job is started from JBoss CLI, the following error will be logged:
> {code:java}
> javax.naming.NameNotFoundException: java:app/AppName
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (DROOLS-5534) MarshallingException occurs during REST request (JSON) unmarshalling in KIE server.
by Enrique González Martínez (Jira)
[ https://issues.redhat.com/browse/DROOLS-5534?page=com.atlassian.jira.plug... ]
Enrique González Martínez commented on DROOLS-5534:
---------------------------------------------------
This is kinda strange:
{code}
@Override
public ServiceResponse<ExecutionResults> callContainer(String containerId, String payload, MarshallingFormat marshallingFormat, String classType) {
if( payload == null ) {
return new ServiceResponse<ExecutionResults>(ServiceResponse.ResponseType.FAILURE, "Error calling container " + containerId + ". Empty payload. ");
}
try {
KieContainerInstanceImpl kci = (KieContainerInstanceImpl) context.getContainer( containerId, ContainerLocatorProvider.get().getLocator());
if (kci != null && kci.getKieContainer() != null) {
Class<? extends Command> type = BatchExecutionCommandImpl.class;
if (classType != null && !classType.isEmpty()) {
type = (Class<? extends Command>) kci.getKieContainer().getClassLoader().loadClass(classType);
}
Command<?> cmd = kci.getMarshaller( marshallingFormat ).unmarshall(payload, type);
if (!(cmd instanceof BatchExecutionCommandImpl)) {
cmd = new BatchExecutionCommandImpl(Arrays.asList(new ExecutableCommand<?>[]{(ExecutableCommand<?>) cmd} ));
}
if (cmd == null || ((BatchExecutionCommandImpl)cmd).getCommands() == null || ((BatchExecutionCommandImpl)cmd).getCommands().isEmpty()) {
return new ServiceResponse<ExecutionResults>(ServiceResponse.ResponseType.FAILURE, "Bad request, no commands to be executed - either wrong format or no data");
}
ExecutionResults results = rulesExecutionService.call(kci, (BatchExecutionCommandImpl) cmd);
return new ServiceResponse<ExecutionResults>(ServiceResponse.ResponseType.SUCCESS, "Container " + containerId + " successfully called.", results);
} else {
return new ServiceResponse<ExecutionResults>(ServiceResponse.ResponseType.FAILURE, "Container " + containerId + " is not instantiated.");
}
} catch (Exception e) {
logger.error("Error calling container '" + containerId + "'", e);
return new ServiceResponse<ExecutionResults>(ServiceResponse.ResponseType.FAILURE, "Error calling container " + containerId + ": " + e.getMessage());
}
}
{code}
this use the next line to deserialize
{code}
Command<?> cmd = kci.getMarshaller( marshallingFormat ).unmarshall(payload, type);
{code}
which uses the kie container instance class loader which is presumed to hold all the classes for the project. I don't see why this is failing.
> MarshallingException occurs during REST request (JSON) unmarshalling in KIE server.
> -----------------------------------------------------------------------------------
>
> Key: DROOLS-5534
> URL: https://issues.redhat.com/browse/DROOLS-5534
> Project: Drools
> Issue Type: Bug
> Components: kie server
> Affects Versions: 7.40.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Attachments: full_error_messages.txt, reproducer_02699633_1.zip
>
>
> A user's decision service deployed on KIE server receives REST commands from client, MarshallingException due to class loading failure occurs during JSON unmarshalling before the commands are processed. I attached a simplified reproducer reproducer_02699633_1.zip expressing the issue, and the error message is like below:
> {noformat}
> Caused by: com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'com.example.reproducer.common.params.ContactParam' as a subtype of [simple type, class com.example.reproducer.common.base.IRuleParam]: no such class found
> at [Source: (String)"{ "lookup" : "ksession-rules", "commands" : [ { "insert" : { "object" : { "com.example.reproducer.common.base.Fact1": { "parameter" : { "@class" : "com.example.reproducer.common.params.ContactParam", "contactInfo" : 123456789 } } } } }, { "fire-all-rules" : "" } ]}"; line: 1, column: 185] (through reference chain: org.drools.core.command.runtime.BatchExecutionCommandImpl["commands"]->java.util.ArrayList[0]->org.drools.core.command.runtime.rule.InsertObjectCommand["object"]->com.example.reproducer.common.base.Fact1["parameter"])
> {noformat}
> For full error messages, see full_error_messages.txt in Attachment.
> The user's decision service (kjar) uses classes in another module jar as a library. ContactParam class which is a sub type of IRuleParam interface is in the kjar and IRuleParam interface is in the module jar.
> Also, @JsonTypeInfo(use = Id.CLASS) annotation is given to IRuleParam like below in order for JSON implementation to recognize a given class to Fact1.parameter as a sub type of IRuleParam.
> {code:java}
> @JsonTypeInfo(use = Id.CLASS)
> public interface IRuleParam {
> }
> {code}
> Both classes contained in the module jar and classes in the kjar should be loaded.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (DROOLS-5521) OutOfBound Exception for last DecisionTable cell
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5521?page=com.atlassian.jira.plug... ]
Michael Anstis commented on DROOLS-5521:
----------------------------------------
[~jomarko] Do you think this JIRA relates to this too: https://issues.redhat.com/browse/DROOLS-5543
I found the latter testing Guided Decision Tables for 7.41.
> OutOfBound Exception for last DecisionTable cell
> ------------------------------------------------
>
> Key: DROOLS-5521
> URL: https://issues.redhat.com/browse/DROOLS-5521
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.41.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Priority: Major
> Labels: drools-tools, regression
> Attachments: edit-last-cell-of-row-and-press-tab.webm
>
>
> This issue is caused by DROOLS-5442.
> It can be spotted when user start to edit last cell of DMN Decision table row and finish the edit mode by pressing TAB key. It causes an attempt to select next cell of the row and an exception is thrown. See the attached video.
> h3. Acceptance criteria
> Check pressing TAB when edit mode of last cell is active for:
> - Guided Decision Table
> - Test Scenario
> - DMN Decision Table
> - DMN Relation
> - DMN Context
> - DMN Function
> - DMN Literal Expression
> - DMN List
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months