[JBoss JIRA] Created: (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
7:51 a.m.
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://jira.jboss.org/jira/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Mark Proctor
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1" />
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2" />
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
[
https://jira.jboss.org/jira/browse/JBRULES-2438?page=com.atlassian.jira.p...
]
Tihomir Surdilovic commented on JBRULES-2438:
---------------------------------------------
A workaround currently is not use change set:
....
// load sheet1
DecisionTableConfiguration config1 =
KnowledgeBuilderFactory.newDecisionTableConfiguration();
config1.setInputType(DecisionTableInputType.XLS);
config1.setWorksheetName("sheet1");
kbuilder.add(ResourceFactory.newClassPathResource("Sample.xls"),
ResourceType.DTABLE, config1);
// load sheet2
DecisionTableConfiguration config2 =
KnowledgeBuilderFactory.newDecisionTableConfiguration();
config2.setInputType(DecisionTableInputType.XLS);
config2.setWorksheetName("sheet2");
kbuilder.add(ResourceFactory.newClassPathResource("Sample.xls"),
ResourceType.DTABLE, config2);
....
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://jira.jboss.org/jira/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Mark Proctor
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:07 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet reassigned JBRULES-2438:
-----------------------------------------
Assignee: Geoffrey De Smet (was: Mark Proctor)
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration updated JBRULES-2438:
---------------------------------------------
Bugzilla Update: Perform
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration updated JBRULES-2438:
---------------------------------------------
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=724313
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:44 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Reproduced with a unit test on master too.
loading multiple sheets of single Excel book by one change-set xml
------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:07 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2438:
--------------------------------------
Summary: Loading multiple sheets of single Excel book by one change-set
xml should fail gracefully if multiple sheets use the same RuleTable name (was: loading
multiple sheets of single Excel book by one change-set xml)
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=724313 (was:
https://bugzilla.redhat.com/show_bug.cgi?id=724313)
Actually, it works, as shown here:
https://github.com/droolsjbpm/drools/commit/643fba49913b8e01449981f7298ae...
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:07 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet edited comment on JBRULES-2438 at 8/30/12 8:06 AM:
--------------------------------------------------------------------
Actually, it works, as shown here:
https://github.com/droolsjbpm/drools/commit/643fba49913b8e01449981f7298ae...
But if multiple sheets use the same RuleTable name it should fail gracefully indeed
(changed the issue to this).
was (Author: ge0ffrey):
Actually, it works, as shown here:
https://github.com/droolsjbpm/drools/commit/643fba49913b8e01449981f7298ae...
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
It's possible to do it, here's a unit test on 5.3.x (also on 5.4.x and master):
https://github.com/droolsjbpm/drools/commit/57df74328e2d7e4b41e80bc43beb6...
But if multiple sheets use the same RuleTable name it should fail gracefully.
I 'll take a look at that failing gracefully to fix this issue.
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:46 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Failing gracefully is not possible, because it's specified behavior that newer rules
with the same name overwrite older rules with the same name.
So, I did the next best thing, document the pitfall in the manual (5.3, 5.4 and master):
https://github.com/droolsjbpm/drools/commit/e1165dc908446198c45710ab04c01...
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:46 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> changed the Status of [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313] from ASSIGNED to MODIFIED
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet resolved JBRULES-2438.
---------------------------------------
Fix Version/s: 5.5.0.Beta1
Resolution: Partially Completed
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Re-opening, after talking with Edson, we need to go for a better solution:
<ge0ffrey> Another idea, what if I suffix the sheet name + the row number (instead
of just the row number) to TableName?
<Edson> Geoffrey, I think that prefixing the rule name with the sheet name as you
suggest would be the best solution for this problem.
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> changed the Status of [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313] from MODIFIED to ASSIGNED
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:31 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet reopened JBRULES-2438:
---------------------------------------
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
Geoffrey De Smet resolved JBRULES-2438.
---------------------------------------
Resolution: Done
Fixed decently on master by adding the sheet name to the rule name generation
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:35 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> changed the Status of [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313] from ASSIGNED to MODIFIED
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:35 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Fixed by adding the sheet name into the rule name too.
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:37 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Geoffrey De Smet <gdesmet(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
on 5.3.x (and 5.4 and master):
https://github.com/droolsjbpm/drools/commit/ed6b8c549965a86e81727aba35ec6...
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:07 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Julian Coleman <jcoleman(a)redhat.com> changed the Status of [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313] from MODIFIED to ON_QA
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Tomas Schlosser <tschloss(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Verified in BRMS-5.3.1-ER1.
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 a.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
Tomas Schlosser <tschloss(a)redhat.com> changed the Status of [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313] from ON_QA to VERIFIED
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 p.m.
New subject: [JBoss JIRA] (JBRULES-2438) Loading multiple sheets of single Excel book by one change-set xml should fail gracefully if multiple sheets use the same RuleTable name
[
https://issues.jboss.org/browse/JBRULES-2438?page=com.atlassian.jira.plug...
]
RH Bugzilla Integration commented on JBRULES-2438:
--------------------------------------------------
lcarlon <lcarlon(a)redhat.com> made a comment on [bug
724313|https://bugzilla.redhat.com/show_bug.cgi?id=724313]
Thanks for providing the release notes text, Geoffrey.
Loading multiple sheets of single Excel book by one change-set xml
should fail gracefully if multiple sheets use the same RuleTable name
----------------------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-2438
URL: https://issues.jboss.org/browse/JBRULES-2438
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Toshiya Kobayashi
Assignee: Geoffrey De Smet
Fix For: 5.5.0.Beta1
I'm trying to use rules via DecisionTable using change-set.
I wrote rules in multiple sheets of single Excel book.
Then I configured my change-set xml like:
...
<add>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet1"
/>
</resource>
<resource source='classpath:data/dtable.xls' type="DTABLE">
<decisiontable-conf input-type="XLS" worksheet-name="sheet2"
/>
</resource>
</add>
...
But only rules of sheet1 were loaded.
As far as I observed source codes, KnowledgeAgentImpl.java puts resource into
"Map<Resource, ResourceMapping> resources". But even if multiple resources
are configured in change-set, it appears to me like those resources are considered as the
same resource and eventually only one resource will be registered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4213
days inactive
5180
days old
22 comments
4 participants
participants (4)
-
Geoffrey De Smet (JIRA) -
RH Bugzilla Integration (JIRA)
-
Tihomir Surdilovic (JIRA)
-
Toshiya Kobayashi (JIRA)