[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404368 ] Jan Boboli commented on JBRULES-1525: ------------------------------------- The problem in MVELDateCoercionTest() and MVELCalendarCoercionTest() is a localization problem. The problem is at line 24: String dt = "10-Jul-1974"; On my computer, i have Polish locale, and for me it should be "10-Cze-1974" for the tests to complete succesfully. Probably you have different language settings that US. If you want to build drools without running tests, you can use "mvn install -Dmaven.test.skip=true". Jan -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=all ] Jan Boboli updated JBRULES-1525: -------------------------------- Attachment: MVELCalendarCoercionTest.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404375 ] Jan Boboli commented on JBRULES-1525: ------------------------------------- I've attached patches that should fix the problem. Can anyone from the Drools team look at them? Jan -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=all ] Nicolas Heron updated JBRULES-1525: ----------------------------------- Attachment: DateFactory.java.patch Hello again, in fact the main problem is that you guys are all using US as a country and english as a language. We poor others, don't use it. So all the tests and drl files you are assuming that date is format DD-MM-YYYY To correct this,I modified the class DateFactory in package org.drools.base.evaluators of drools-core. Before, you were initializing the simple parser like this : return new SimpleDateFormat( DateFactory.DATE_FORMAT_MASK ); now I propose : DateFormatSymbols dateSymbol = new DateFormatSymbols( new Locale( DateFactory.DEFINE_LANGUAGE, DateFactory.DEFINE_COUNTRY ) ) SimpleDateFormat dateFormat = new SimpleDateFormat( DateFactory.DATE_FORMAT_MASK, dateSymbol ); return dateFormat; Here I first initialize a DateFormatSymbols and use it when creating the simple parse. By defautl, it is "en" as language and "US" as country and you can modify it by setting two system properties drools.defaultlanguage and drools.defaultcountry Now all tests concerning date format work for whatever coutry you are. And by the way, you don't need the patch submitted by jan Boboli that modifies the test. The present solution is I thing more modular. Regards Nicolas Héron -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404424 ] Nicolas Heron commented on JBRULES-1525: ---------------------------------------- I have no opinion on this. My only concern is that I need for tomorrow evening a running 4.0.x if possible with dynamic rules. If not, I have to return to version 4.0.3 which had no mvel problem & Co but cannot remove or add a rule a run time. (see http://jira.jboss.com/jira/browse/JBRULES-1526 for the MVEL problem) and that I try to find out the problems and I found this present issue which is not my main concern. I am working on a loyalty system here in France for a retail company (that shall make public the use of drools) and the production dead line for the first shop (60 cash machines) is en of end of April. The project leader and the customer are begining to be nervous ! Regards Nicolas Héron -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404427 ] Michael Neale commented on JBRULES-1525: ---------------------------------------- Nicolas - at the moment you can you set the date format explicitly - are you saying it is better to set language and locale and let the DateSymbol work it out based on that? Or should we just let the locale alone work out what symbols are appropriate? (and allow people to tell it to use current local, a specified locale or the default?). Its all very confusing to me ;) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404437 ] Michael Neale commented on JBRULES-1525: ---------------------------------------- I think 4.0.3 should have had this exact same problem - no code for date handling was changed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=comments#action_12404444 ] Michael Neale commented on JBRULES-1525: ---------------------------------------- Leave it to me - need to find a better approach. In summary: we need to allow users to use the "default" local and everything for their platform - I believe in your case that would be ideal - so you could use a totally local format for dates. new SimpleDateFormat() should do that. We then need to allow people to specify a locale (language and country) just for drools, optionally Finally, we also should allow people to set a format string, optionally. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=all ] Michael Neale reassigned JBRULES-1525: -------------------------------------- Assignee: Michael Neale (was: Mark Proctor) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1525?page=all ] Michael Neale closed JBRULES-1525. ---------------------------------- Fix Version/s: 5.0.0-M1 Resolution: Done OK done in trunk (required some footwork as its quite different) and 4.0.x. Thanks so much for this Nicolas (and others) - very very useful. Nicolas - if you get a chance - do you mind jotting down some thoughts on how to best explain that in the manual - so others can benefit from it? (I added some more tests to trunk as well). Thanks ! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira