[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Thomas Diesler commented on AS7-2854: ------------------------------------- I wonder whether it is the correct approach to validate the DDs in the JSR88 layer. It seems more natural/correct to validate the DDs in the subsystem that consumes the deployment. The behaviour I would expect is that the (invalid) deployment reaches the server, fails during deploy and that the deployment failure is communicated back to the jsr88 layer. {code} 16:59:32,801 INFO [org.jboss.as.server.deployment] (MSC service thread 1-1) Starting deployment of "file:/tmp/BadFilterMapping.war" 16:59:35,889 INFO [org.jboss.web] (MSC service thread 1-3) registering web context: /ordering_filter-mapping_bad_war 16:59:36,102 INFO [org.jboss.as.server.controller] (pool-1-thread-1) Deployed "file:/tmp/BadFilterMapping.war" 16:59:36,495 INFO [org.jboss.as.server.deployment] (MSC service thread 1-3) Stopped deployment file:/tmp/BadFilterMapping.war in 123ms 16:59:36,542 INFO [org.jboss.as.server.controller] (pool-1-thread-1) Undeployed "file:/tmp/BadFilterMapping.war" {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Thomas Diesler reassigned AS7-2854: ----------------------------------- Assignee: Remy Maucherat (was: Thomas Diesler) Assigning to Remy for comment -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Remy Maucherat commented on AS7-2854: ------------------------------------- Most, of not all, can be fixed by enabling validation (supposedly on the stax xmlInputFactory, although of course I am not the biggest stax expert). This is the same for all descriptors, although maybe only web is tested with funny XML. Since this is generic, there should be a generic flag (or system property) somewhere to do that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Thomas Diesler commented on AS7-2854: ------------------------------------- I have some code to enable schema validation via woodstox. It catches the error. However it takes 30sec to do so. Half of the time is spend to create the schema object, half for the validation itself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Remy Maucherat commented on AS7-2854: ------------------------------------- This really doesn't look very good. I think it might make sense to not use stax to validate, no ? (essentially, the optional validation, if enabled, would be completely separate from the parsing itself) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2854?page=com.atlassian.jira.plugin.s... ] Thomas Diesler commented on AS7-2854: ------------------------------------- The metadata project should be switched to AS7 code style conventions, IHMO -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira