9:31 a.m.
Drools Planner Divide By Zero Error
-----------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Mark Proctor
In org.drools.palnner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L /
timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:33 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2912) Drools Planner Divide By Zero Error
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
David Faulkner updated JBRULES-2912:
------------------------------------
Description:
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L /
timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
was:
In org.drools.palnner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L /
timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
Drools Planner Divide By Zero Error
-----------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Mark Proctor
Labels: bug
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-2912) Drools Planner Divide By Zero Error
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
Geoffrey De Smet reassigned JBRULES-2912:
-----------------------------------------
Assignee: Geoffrey De Smet (was: Mark Proctor)
Drools Planner Divide By Zero Error
-----------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Geoffrey De Smet
Labels: bug
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2912) Planner: Divide by zero exception on timeMillisSpend on a fast computer
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2912:
--------------------------------------
Summary: Planner: Divide by zero exception on timeMillisSpend on a fast computer
(was: Drools Planner Divide By Zero Error)
Fix Version/s: 5.2.0.M2
Planner: Divide by zero exception on timeMillisSpend on a fast
computer
-----------------------------------------------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Geoffrey De Smet
Labels: bug
Fix For: 5.2.0.M2
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:43 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2912) Planner: Divide by zero exception on timeMillisSpend on a fast computer
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
Geoffrey De Smet resolved JBRULES-2912.
---------------------------------------
Resolution: Done
Nicely found :) Fixed on master like this:
long averageCalculateCountPerSecond = (timeMillisSpend == 0L) ? 0L
: localSearchSolverScope.getCalculateCount() * 1000L / timeMillisSpend;
Not a 100% sure that 0 makes sense in that case, wdyt?
Planner: Divide by zero exception on timeMillisSpend on a fast
computer
-----------------------------------------------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Geoffrey De Smet
Labels: bug
Fix For: 5.2.0.M2
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2912) Planner: Divide by zero exception on timeMillisSpend on a fast computer
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2912:
-------------------------------------------
A night sleep brings wisdom:
I fixed it like this now:
if (timeMillisSpend == 0L) {
// Avoid divide by zero exception on a fast CPU
timeMillisSpend = 1L;
}
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() *
1000L / timeMillisSpend;
If it does a 77 calculations in 0 millisecond, we presume it took 1 millisecond, which
makes 77000 calculations per second on average.
Note: some OS's round their system.millis to 15 ms (most notably winblows XP), so I
wouldn't thrust the average calculations per second on any program that run less then
2 minutes.
Planner: Divide by zero exception on timeMillisSpend on a fast
computer
-----------------------------------------------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Geoffrey De Smet
Labels: bug
Fix For: 5.2.0.M2
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBRULES-2912) Planner: Divide by zero exception on timeMillisSpend on a fast computer
[
https://issues.jboss.org/browse/JBRULES-2912?page=com.atlassian.jira.plug...
]
Geoffrey De Smet edited comment on JBRULES-2912 at 3/2/11 2:47 AM:
-------------------------------------------------------------------
A night sleep brings wisdom:
I fixed it like this now:
if (timeMillisSpend == 0L) {
// Avoid divide by zero exception on a fast CPU
timeMillisSpend = 1L;
}
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() *
1000L / timeMillisSpend;
If it does a 77 calculations in 0 millisecond, we presume it took 1 millisecond, which
makes 77000 calculations per second on average.
Note: some OS's round their system.millis to 15 ms (most notably windows XP), so I
wouldn't thrust the average calculations per second on any program that run less then
2 minutes.
was (Author: ge0ffrey):
A night sleep brings wisdom:
I fixed it like this now:
if (timeMillisSpend == 0L) {
// Avoid divide by zero exception on a fast CPU
timeMillisSpend = 1L;
}
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() *
1000L / timeMillisSpend;
If it does a 77 calculations in 0 millisecond, we presume it took 1 millisecond, which
makes 77000 calculations per second on average.
Note: some OS's round their system.millis to 15 ms (most notably winblows XP), so I
wouldn't thrust the average calculations per second on any program that run less then
2 minutes.
Planner: Divide by zero exception on timeMillisSpend on a fast
computer
-----------------------------------------------------------------------
Key: JBRULES-2912
URL: https://issues.jboss.org/browse/JBRULES-2912
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.1.1.FINAL
Environment: Windows, Intel desktop-class, Java6 (bug is not
environment-specific)
Reporter: David Faulkner
Assignee: Geoffrey De Smet
Labels: bug
Fix For: 5.2.0.M2
In org.drools.planner.core.localsearch.DefaultLocalSearchSolver::solvingEnded, there is
potentially a divide by zero that occurs on the line:
long averageCalculateCountPerSecond = localSearchSolverScope.getCalculateCount() * 1000L
/ timeMillisSpend;
if timeMillisSpend is zero. Although in theory the likelihood of this occurring in
practically nothing, we have actually seen it occur on a POC project with long running
Planner jobs. An appropriate guard should be added to this calculation to ensure that this
error cannot occur.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4818
days inactive
4819
days old
6 comments
2 participants
participants (2)
-
David Faulkner (JIRA) -
Geoffrey De Smet (JIRA)