[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Heiko Braun updated AS7-3992: ----------------------------- Component/s: CLI (was: Console) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Carlo de Wolf updated AS7-3992: ------------------------------- Fix Version/s: (was: Open To Community) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Joe Wertz edited comment on AS7-3992 at 8/23/12 6:23 AM: --------------------------------------------------------- Should this streamlining also affect legacy-to-new command line parameters? Current output: {noformat} -b=<value> Set system property jboss.bind.address to the given value -b <value> Set system property jboss.bind.address to the given value {noformat} Suggested: {noformat} -b=<value>, -b <value> Set system property jboss.bind.address to the given value {noformat} was (Author: Gonthim): Should this streamlining also affect legacy-to-new command line paramters? Current output: {noformat} -b=<value> Set system property jboss.bind.address to the given value -b <value> Set system property jboss.bind.address to the given value {noformat} Suggested: {noformat} -b=<value>, -b <value> Set system property jboss.bind.address to the given value {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Paul Gier commented on AS7-3992: -------------------------------- I don't really have a preference regarding the legacy parameters. IMO, they should be marked in the help as deprecated, but I'm not sure there's a good way to do this in a single line. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-3992: --------------------------------------- I don't see any reason to mark them as deprecated. We should probably change any docs that say that they are. There's nothing particularly wrong with -b <value>. BTW, the formatting of the help text tries to limit the width of each line, so taking more width for the key will require some thinking about that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Paul Gier commented on AS7-3992: -------------------------------- {quote}I don't see any reason to mark them as deprecated.{quote} Isn't one syntax preferred over the other? It seems like we should just pick either with or without the "=" as the recommended syntax, and only list this preferred syntax in the help to make it simpler. The other syntax would still be supported for compatibility, but just not listed in the standard help message if there is no reason to use it other than backwards compatibility. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-3992: --------------------------------------- BTW, IIRC the current limited width format of this output was basically just my simple way of dealing with implementing some sort of reasonable line wrapping of the command descriptions. Assume the console window will have a reasonable minimum width and wrap lines at that width. If there is some better approach, go for it. I also don't think I did any sort of scientific study when I picked the width, so don't assume it's a sacred figure. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-3992: --------------------------------------- +1 on space option first, and I say put --properties on the first line, either by widening or stealing 2 chars from the whitespace on the left. BTW, the jreadline project's Terminal class lets you read the terminal width, thus allowing greater formatting flexibility. But I'm quite leery of adding that dependency to the process-controller module. It would only be used with --help, and the process exits after that completes so it's probably not a problem to add the dependency, but I'm still leery of doing it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Joe Wertz edited comment on AS7-3992 at 8/31/12 5:50 AM: --------------------------------------------------------- Come to find out, we do actually have a case where we need to either expand the width or do something else. There are currently 3 versions of the 'Set domain config file' command. They're just not all next to each other so it slipped under the radar. {noformat} -c <config> Name of the domain configuration file to use (default is "domain.xml") -c=<config> Name of the domain configuration file to use (default is "domain.xml") --domain-config=<config> Name of the domain configuration file to use (default is "domain.xml") {noformat} I figured out a way to handle multiple-lines on the command side of the output and for comparison handled it this way. I'm not sure what standard-practice is for this scenario though. I've never actually seen it anywhere. {noformat} -c <config>, -c=<config>, Name of the domain configuration file --domain-config=<config> to use (default is "domain.xml") {noformat} Thoughts? Edit: Grrr, meant to include this bit. If we extend the width to accommodate this case on a single line, the total would become 95 characters. I think that's on the edge of being too large. For perspective, the jboss-cli help uses 120, which I do think is too large even on my large rez screen. was (Author: Gonthim): Come to find out, we do actually have a case where we need to either expand the width or do something else. There are currently 3 versions of the 'Set domain config file' command. They're just not all next to each other so it slipped under the radar. {noformat} -c <config> Name of the domain configuration file to use (default is "domain.xml") -c=<config> Name of the domain configuration file to use (default is "domain.xml") --domain-config=<config> Name of the domain configuration file to use (default is "domain.xml") {noformat} I figured out a way to handle multiple-lines on the command side of the output and for comparison handled it this way. I'm not sure what standard-practice is for this scenario though. I've never actually seen it anywhere. {noformat} -c <config>, -c=<config>, Name of the domain configuration file --domain-config=<config> to use (default is "domain.xml") {noformat} Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-3992?page=com.atlassian.jira.plugin.s... ] Joe Wertz commented on AS7-3992: -------------------------------- Ah, that's a good point. Hadn't considered the alphabetizing of the commands. I'll add that into the explanation text instead of combing them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira