[ https://jira.jboss.org/browse/JBAS-8455?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8455: ------------------------------------------- Given that the service binding manager is used so heavily for allowing services to get host and port information, it would be nice to use this central point of control in this fix. For example, when URLs are being formed in services, allow the service to obtain from the service biding manager a URL form for the hostname/host IP address. In other words, allow the SBM to fulfill the role of returning the jboss.bind.url.address so that URLs can be correctly formed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8455?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8455: ------------------------------------------- Had a chat with Brian about how to use the ServiceBindingManager to resolve the general issue of beans which need to construct URLs as attributes and how the URLs are being badly formed when IPv6 literals are used as the bind address. This seems to happen in one of two ways: (i) via direct substitution of the system property ${jboss.bind.address} // from hsqldb-sd.xml <connection-url>jdbc:hsqldb:hsql://${jboss.bind.address}:1701</connection-url> (ii) via substitution of an value obtained from the service binding manager, with some string replacement thrown in, as in // from deploy/httpha-invoker.sar/META-INF/jboss-service.xml <mbean code="org.jboss.invocation.http.server.HttpInvoker" name="jboss:service=invoker,type=http"> <attribute name="InvokerURLPrefix">http://</attribute> <attribute name="InvokerURLSuffix"> <!-- To get value, ask the ServiceBindingManager to do a string replacement operation using the HTTP connector port --> <value-factory bean="ServiceBindingManager" method="getStringBinding"> <parameter>jboss.web:service=WebServer</parameter> <parameter>${host}:${port}/invoker/EJBInvokerServlet</parameter> </value-factory> </attribute> <attribute name="UseHostName">true</attribute> </mbean> In this call, the value-factory will call ServiceBindingManager.getStringBinding(String service, String input) method to use the default ServiceBinding (no binding was specified) for the service jboss.web:service=WebServer and use string replacement to replace the ${host} token with the hostname associated with the default ServiceBinding instance for service jboss.web:service=WebServer, and similarly for the ${port} token. The problem is that, at the moment, if we want to use an IPv6 address literal returned by ServiceBindingManager in a URL, we have no easy way of adding the square brackets around the literal which would be required to create a well formed URL. If we had a way to tell the SBM to add brackets to the IP address literal it gives back to us, we could work around this issue I believe with little impact elsewhere. Many of the startup problems for AS 6 at the moment involve this sort of issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8455?page=com.atlassian.jira.plugin.sy... ] Brian Stansberry commented on JBAS-8455: ---------------------------------------- SVCBIND-5 is the JIRA for the SBM implementation of Richard's idea; this JIRA would then be for converting any AS usage of SBM to take advantage of the new feature. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8455?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8455: ------------------------------------------- So, leaving aside the fact that the prefix/suffix approach to specifying URLs would have to be patched, JBAS-8453 and JBAS-8455 (this issue) would be fixed with these changes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8455?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8455: ------------------------------------------- A fix has been created for this issue and applied to the AS 6 IPv6 branch. All that remains is to patch AS 6 trunk with the patch. With the fix, I am applying the method described above where full URLs are passed in as attrubutes and SBM is used to construct the strings. There are addition changes required to fix the Http and HttpHA invokers when URL [prefixes and suffixes are passed in. These were picked up from the EAP 4.3 IPv6 changes and won't be described here. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira