[jboss-remoting-commits] JBoss Remoting SVN: r3457 - in remoting3/trunk: api/src/main/java/org/jboss/cx/remoting/spi/wrapper and 1 other directories.

Author: david.lloyd(a)jboss.com Date: 2008-02-18 22:16:58 -0500 (Mon, 18 Feb 2008) New Revision: 3457 Modified: remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/RequestContext.java remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/spi/wrapper/RequestContextWrapper.java remoting3/trunk/core/src/main/java/org/jboss/cx/remoting/core/CoreInboundRequest.java Log: setCancelHandler -> addCancelHandler Modified: remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/RequestContext.java =================================================================== --- remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/RequestContext.java 2008-02-19 02:42:17 UTC (rev 3456) +++ remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/RequestContext.java 2008-02-19 03:16:58 UTC (rev 3457) @@ -40,18 +40,10 @@ void sendCancelled() throws RemotingException, IllegalStateException; /** - * Set a notifier to be called if a cancel request is received. The notifier may be called from the current thread - * or a different thread. If the request has already been cancelled, the notifier will be called immediately. If there - * was a previous notifier set, it will be overwritten. Calling this method guarantees that the supplied handler - * will be called, unless it is cleared or a new handler is set before the original handler is called. The handler - * may be called at any time after the cancel request is recevied, though implementations should make a reasonable effort - * to ensure that the handler is called in a timely manner. The handler is cleared before it is called. - * <p/> - * Setting a {@code null} value clears any notifier. - * <p/> - * This method returns {@code this} in order to facilitate method call chaining. + * Add a notifier to be called if a cancel request is received. The notifier may be called from the current thread + * or a different thread. If the request has already been cancelled, the notifier will be called immediately. * * @param handler */ - void setCancelHandler(RequestCancelHandler<O> handler); + void addCancelHandler(RequestCancelHandler<O> handler); } Modified: remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/spi/wrapper/RequestContextWrapper.java =================================================================== --- remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/spi/wrapper/RequestContextWrapper.java 2008-02-19 02:42:17 UTC (rev 3456) +++ remoting3/trunk/api/src/main/java/org/jboss/cx/remoting/spi/wrapper/RequestContextWrapper.java 2008-02-19 03:16:58 UTC (rev 3457) @@ -30,8 +30,8 @@ delegate.sendCancelled(); } - public void setCancelHandler(final RequestCancelHandler<O> requestCancelHandler) { - delegate.setCancelHandler(requestCancelHandler); + public void addCancelHandler(final RequestCancelHandler<O> requestCancelHandler) { + delegate.addCancelHandler(requestCancelHandler); } } Modified: remoting3/trunk/core/src/main/java/org/jboss/cx/remoting/core/CoreInboundRequest.java =================================================================== --- remoting3/trunk/core/src/main/java/org/jboss/cx/remoting/core/CoreInboundRequest.java 2008-02-19 02:42:17 UTC (rev 3456) +++ remoting3/trunk/core/src/main/java/org/jboss/cx/remoting/core/CoreInboundRequest.java 2008-02-19 03:16:58 UTC (rev 3457) @@ -87,7 +87,7 @@ context.sendCancelAcknowledge(requestIdentifier); } - public void setCancelHandler(final RequestCancelHandler<O> requestCancelHandler) { + public void addCancelHandler(final RequestCancelHandler<O> requestCancelHandler) { // todo - should be a list } }