Re: [jbosstools-dev] b3 is *requiring* atlassian plugin to be installed !?

I created an issue ( https://issues.jboss.org/browse/JBIDE-11924 ) and rolled back Nick's changes for https://svn.jboss.org/repos/jbosstools/trunk/common/features/org.jboss.to... Nick, please take a look. On 05/21/2012 12:29 AM, Denis Golovin wrote: > Introduced by > > 40682 5/1/12 8:35 AM 3 nickboldt JBDS-2089 add mylyn and > atlassian deps to org.jboss.tools.common.mylyn.feature; add > org.jboss.tools.common.mylyn.feature to JBT Central Discovery > > The issue is actually JBDS-2098 not JBDS-2089. > > o.j.t.c.mylyn has only optional references to mylyn. There is no reason > to have all this stuff in<requires> should be just cleaned up to fix > the issue. > > Denis > > P.S. Here is what was in the commit: > > Index: feature.xml > =================================================================== > --- feature.xml (revision 40681) > +++ feature.xml (revision 40682) > @@ -6,4 +6,78 @@ > <license>%license</license> > > <plugin id="org.jboss.tools.common.mylyn" download-size="0" > install-size="0" version="0.0.0" /> > + > +<!-- JBDS-2098 add required mylyn and atlassian plugins/features; not > sure if we need bamboo, crucible, or fisheye support --> > +<requires> > +<import feature="org.eclipse.mylyn_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.ide_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.commons" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.context_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.bugzilla_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.java_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.pde_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.team_feature" version="3.6.2" > match="greaterOrEqual" /> > +<import feature="org.eclipse.mylyn.versions" version="0.8.2" > match="greaterOrEqual" /> > + > +<plugin id="org.eclipse.mylyn.tasks.ui" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.mylyn.tasks.core" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.mylyn.tasks.bugs" version="0.0.0" > match="greaterOrEqual"/> > + > +<plugin id="com.atlassian.connector.commons" version="0.0.0" > match="greaterOrEqual"/> > +<!--<plugin id="com.atlassian.connector.eclipse.bamboo.core" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.bamboo.ui" version="0.0.0" > match="greaterOrEqual"/> --> > +<plugin id="com.atlassian.connector.eclipse.branding.ui" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.commons.core" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.commons.ui" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.core" version="0.0.0" > match="greaterOrEqual"/> > +<!--<plugin id="com.atlassian.connector.eclipse.crucible.core" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.crucible.ui" > version="0.0.0" match="greaterOrEqual"/> --> > +<plugin id="com.atlassian.connector.eclipse.cvs.core" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.cvs.ui" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.directclickthrough.ui" > version="0.0.0" match="greaterOrEqual"/> > +<!--<plugin id="com.atlassian.connector.eclipse.fisheye.core" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.fisheye.ui" > version="0.0.0" match="greaterOrEqual"/> --> > +<plugin id="com.atlassian.connector.eclipse.help" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.jira.core" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.jira.ui" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.monitor.core" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.monitor.ui" > version="0.0.0" match="greaterOrEqual"/> > +<plugin id="com.atlassian.connector.eclipse.ui" version="0.0.0" > match="greaterOrEqual"/> > + > +<!-- JBDS-1682 dependent 3rd party plugins needed to install Atlassian > JIRA support --> > +<plugin id="com.thoughtworks.xstream" version="1.3.0" > match="greaterOrEqual"/> > + > +<plugin id="org.eclipse.ui" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.core.runtime" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.core.resources" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.ui.ide" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.ui.workbench.texteditor" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.jface.text" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.osgi" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.core.filesystem" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.ui.forms" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.ui.editors" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.team.core" version="0.0.0" > match="greaterOrEqual"/> > +<plugin id="org.eclipse.team.ui" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.jface" version="0.0.0" match="greaterOrEqual"/> > +<plugin id="org.eclipse.compare" version="0.0.0" match="greaterOrEqual"/> > + > +<plugin id="org.apache.axis" version="1.4.0" match="greaterOrEqual"/> > +<plugin id="org.apache.commons.logging" version="1.1.1" > match="greaterOrEqual"/> > +<plugin id="org.apache.commons.io" version="2.0.1" > match="greaterOrEqual"/> > +<plugin id="org.apache.commons.httpclient" version="3.1.0" > match="greaterOrEqual"/> > +<plugin id="org.apache.commons.lang" version="2.4.0" > match="greaterOrEqual"/> > +<plugin id="org.apache.commons.codec" version="1.3.0" > match="greaterOrEqual"/> > + > +<plugin id="org.jdom_jaxen" version="1.0.0" match="greaterOrEqual"/> > +<plugin id="org.mortbay.jetty.server" version="6.1.23" > match="greaterOrEqual"/> > +<plugin id="org.mortbay.jetty.util" version="6.1.23" > match="greaterOrEqual"/> > +<plugin id="org.apache.jasper" version="5.5.17" match="greaterOrEqual"/> > +<plugin id="org.joda.time" version="1.6.0" match="greaterOrEqual"/> > + > +<plugin id="javax.servlet" version="3.0.0" match="greaterOrEqual"/> > +<plugin id="javax.servlet.jsp" version="2.2.0" match="greaterOrEqual"/> > +<plugin id="javax.xml.rpc" version="1.1.0" match="greaterOrEqual"/> > +<plugin id="javax.el" version="2.2.0" match="greaterOrEqual"/> > +</requires> > </feature> > > > On 05/20/2012 11:10 PM, Max Rydahl Andersen wrote: >> Hi guys, >> >> Why is B3 now *requiring* Atlassian connector to be installed when choosing abridged ? >> >> This was deliberately marked as optional earlier to avoid this situation of having to install an mylyn atlassian connector and *all* its dependencies for basic functionality ?! >> >> This is the error i'm getting now when trying to install JBoss Tools Beta3: >> >> "Missing requirement: JBoss Tools Common - Mylyn 3.3.0.v20120510-2001-H58-Beta3 (org.jboss.tools.common.mylyn.feature.feature.group 3.3.0.v20120510-2001-H58-Beta3) requires 'com.atlassian.connector.eclipse.subclipse.core 0.0.0' but it could not be found" >> >> This means users cannot simply go and select "abridged" and install it JBoss Tools into their default eclipse for B3 right now - they need to add the updatesite for Atlassian. >> >> This was not necessary in previous milestone/builds afaics. >> >> /max >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev