Daily QA report
by Anton Klimkovich
Hello Denis,
This is Daily QA report.
27 november
Free testing of Seam features and JBoss AS server features.
Project validation tests.
RichFaces and VPE.
Content Assist.
--
Best regards,
Anton Klimkovich mailto:aklimkovich@exadel.com
17 years, 1 month
Re: [atf-dev] XULRunner / ATF Update site
by Marshall Culpepper
Replies inlined below:
Robert Goodman wrote:
>
> >
> > 1) Why are the URLs for feature JARs and plugins so radically
> different?
> > Shouldn't the features / plugins dirs be in sync with each other?
>
> The URLs are based on history which really doesn't matter at this
> point. This could potentially change.
I guess my main question here was why aren't they in a standard update
site format so users can point Eclipse their independently of ATF (or
any other tools that depend on XULRunner for that matter)
>
>
> > 2) Why is XULRunner packaged as 3 seperate features? This becomes hell
> > for dependency management purposes. It was easier for me to just write
> > one simple feature and put platform/OS conditions on each XULRunner
> > plugin. You can find my feature.xml here:
> > -
> > http://anonsvn.jboss.org/repos/jbosstools/trunk/vpe/features/org.
> > jboss.tools.xulrunner.feature/feature.xml
>
> ATF installs XULRunner two ways, automatically downloaded using
> updated manager and in ATF's platform specific "All-in-one" zip files.
>
> 1. Update manager
>
> The basic requirement when installing ATF by update manager was to
> only download the version of XULRunner for the platform. As I remember
> I couldn't figure out a way to have one feature and not get all
> versions of XULRunner downloaded. XULRunner for all three platforms
> supported today is 33 MB in size. We already have request for a 64 bit
> linux build which would increase the by another 8-10 meg. I'm not a
> feature/update manager expert, so there may be a way around this
> problem when using only one feature.
This is what I was trying to reference in my link above. A single
feature fixes this problem rather elegantly, all you need to do is put
platform/operating system constraints on each plugin, and only the
plugins for the relevant platform will be downloaded when it comes time
to install via update site.
>
>
> 2. "All-in-one"
>
> One of the comments that ATF received was that the download size
> (eclipse, wtp, and dependences) was too big. Working with the WTP and
> other eclipse team changes were made that allows us to create an
> "All-In-One" package for each platform with only the functionality
> needed by Web Developers (no JDT, PDE, etc.). Packaging all platform
> versions of XULRunner in each "All in One" would significantly
> increase the size of the download. Any XULRunner feature layout would
> need to allow ATF to package only the platform version of XULRunner
> needed and not show any errors in the "Manage Configuration" wizard
> when all the versions of not there.
>
Again, see above
> I'm not a feature expert, so there may be a way around my concerns
> when just having one XULRunner feature.
>
> > 3) Why isn't ATF depending on XULRunner feature/plugins like it is with
> > XPCOM? With the feature linked above we were able to have our feature
> > depend on it, and use external plugin/feature jar linking (ala the
> > current ATF update site) to have Eclipse auto-check XULRunner when the
> > user presses "Select Required"
> >
>
> This was done so a person can use ATF with an installed version of
> XULRunner and not use the version packaged in a plugin. This allowed
> the person to install a version of ATF without XULRunner. We probably
> need to relook at the requirement. It may be possible to handle the
> problem using the "optional" option on the feature.
If the user already has XULRunner installed, then there will be no need
for them to check it in the update site. The hard requirement only
affects the user when they _don't_ have XULrunner already installed.
I'll look forward to chatting about it on the call tomorrow =).
17 years, 1 month
Fwd: [jbosstools-commits] JBoss Tools SVN: r4997 - in trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui: internal/project/facet and 1 other directory.
by Max Rydahl Andersen
Denis,
It's great we now don't fixate the facet for our jboss runtime, but why do
we have to do those additional validations ?
Isn't these done automatically by the facet framework ? (e.g. I would
expect the validations agaisnt jst.jsf, jst.web and versions are still
performed as normally by the facet framework)
Or is it simply for pre-validating the facets needed for the possible
ejb/ear projects?
/max
------- Forwarded message -------
From: jbosstools-commits(a)lists.jboss.org
To: jbosstools-commits(a)lists.jboss.org
Cc:
Subject: [jbosstools-commits] JBoss Tools SVN: r4997 - in
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui:
internal/project/facet and 1 other directory.
Date: Wed, 21 Nov 2007 03:40:40 +0100
Author: dgolovin
Date: 2007-11-20 21:40:40 -0500 (Tue, 20 Nov 2007)
New Revision: 4997
Modified:
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/SeamUIMessages.java
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/internal/project/facet/SeamInstallWizardPage.java
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/messages.properties
Log:
http://jira.jboss.org/jira/browse/JBIDE-1320
lock to JBoss AS runtime is removed from plugin.xml,
werification for selected Deployment type is added. If selected runtime
have not supported EJB 3.0 and EAR 5.0 modules errori showed on seam
facet wizard page title.
It was verified on JBoss AS and Tomcat servers
Modified:
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/SeamUIMessages.java
===================================================================
---
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/SeamUIMessages.java 2007-11-21
01:01:12 UTC (rev 4996)
+++
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/SeamUIMessages.java 2007-11-21
02:40:40 UTC (rev 4997)
@@ -115,6 +115,8 @@
public static String SEAM_INSTALL_WIZARD_PAGE_ADD;
+ public static String
SEAM_INSTALL_WIZARD_PAGE_CANNOT_USE_SELECTED_DEPLOYMENT6;
+
public static String SEAM_INSTALL_WIZARD_PAGE_CODE_GENERATION;
public static String
SEAM_INSTALL_WIZARD_PAGE_CONFIGURE_SEAM_FACET_SETTINGS;
Modified:
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/internal/project/facet/SeamInstallWizardPage.java
===================================================================
---
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/internal/project/facet/SeamInstallWizardPage.java 2007-11-21
01:01:12 UTC (rev 4996)
+++
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/internal/project/facet/SeamInstallWizardPage.java 2007-11-21
02:40:40 UTC (rev 4997)
@@ -33,6 +33,7 @@
import org.eclipse.jface.wizard.Wizard;
import org.eclipse.jface.wizard.WizardDialog;
import
org.eclipse.jst.j2ee.project.facet.IJ2EEModuleFacetInstallDataModelProperties;
+import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.SWT;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
@@ -41,10 +42,16 @@
import org.eclipse.swt.widgets.Group;
import org.eclipse.ui.internal.dialogs.PropertyDialog;
import
org.eclipse.wst.common.componentcore.datamodel.properties.IFacetDataModelProperties;
+import
org.eclipse.wst.common.componentcore.internal.util.IModuleConstants;
import org.eclipse.wst.common.frameworks.datamodel.DataModelEvent;
import org.eclipse.wst.common.frameworks.datamodel.IDataModel;
import org.eclipse.wst.common.frameworks.datamodel.IDataModelListener;
import
org.eclipse.wst.common.frameworks.internal.operations.ProjectCreationDataModelProviderNew;
+import org.eclipse.wst.common.project.facet.core.IProjectFacet;
+import org.eclipse.wst.common.project.facet.core.IProjectFacetVersion;
+import org.eclipse.wst.common.project.facet.core.ProjectFacetsManager;
+import org.eclipse.wst.common.project.facet.core.runtime.IRuntime;
+import org.eclipse.wst.common.project.facet.core.runtime.RuntimeManager;
import org.eclipse.wst.common.project.facet.ui.AbstractFacetWizardPage;
import org.eclipse.wst.common.project.facet.ui.IFacetWizardPage;
import
org.eclipse.wst.web.ui.internal.wizards.NewProjectDataModelFacetWizard;
@@ -382,6 +389,11 @@
IFacetDataModelProperties.FACET_PROJECT_NAME,
new ProjectNamesDuplicationValidator(
IFacetDataModelProperties.FACET_PROJECT_NAME));
+ validatorDelegate.addValidatorForProperty(
+ ISeamFacetDataModelProperties.JBOSS_AS_DEPLOY_AS,
+ new DeploymentTypeValidator(
+ ISeamFacetDataModelProperties.JBOSS_AS_DEPLOY_AS,
+ ((NewProjectDataModelFacetWizard)getWizard()).getDataModel()));
}
jBossHibernateDbTypeEditor
@@ -541,7 +553,7 @@
if (visible) {
ITaggedFieldEditor runtimesField =
(ITaggedFieldEditor)((CompositeEditor)jBossSeamHomeEditor).getEditors().get(1);
Object oldValue = runtimesField.getValue();
- Object newValue = "";
+ Object newValue = ""; //$NON-NLS-1$
List<String> runtimes =
getRuntimeNames(model.getProperty(IFacetDataModelProperties.FACET_VERSION_STR).toString());
if(oldValue==null || !runtimes.contains(oldValue)) {
Object defaultRnt = getSeamRuntimeDefaultValue();
@@ -612,12 +624,10 @@
*/
public Map<String, String> validate(Object value, Object context) {
final String projectName = (String)value;
-
- IDataModel model = (IDataModel)context;
final String deployAs = model.getStringProperty(
ISeamFacetDataModelProperties.JBOSS_AS_DEPLOY_AS);
- final String testProjectName = projectName + "-test";
+ final String testProjectName = projectName + "-test"; //$NON-NLS-1$
IStatus status =
ProjectCreationDataModelProviderNew.validateName(testProjectName);
if (!status.isOK())
return ValidatorFactory.createErrormessage(propertyName,
@@ -626,7 +636,7 @@
SeamUIMessages.VALIDATOR_FACTORY_PROJECT_ALREADY_EXISTS);
if (ISeamFacetDataModelProperties.DEPLOY_AS_EAR.equals(deployAs)) {
- final String earProjectName = projectName + "-ear";
+ final String earProjectName = projectName + "-ear"; //$NON-NLS-1$
status =
ProjectCreationDataModelProviderNew.validateName(earProjectName);
if (!status.isOK())
return ValidatorFactory.createErrormessage(propertyName,
@@ -634,7 +644,7 @@
earProjectName +
SeamUIMessages.VALIDATOR_FACTORY_PROJECT_ALREADY_EXISTS);
- final String ejbProjectName = projectName + "-ejb";
+ final String ejbProjectName = projectName + "-ejb"; //$NON-NLS-1$
status =
ProjectCreationDataModelProviderNew.validateName(ejbProjectName);
if (!status.isOK())
return ValidatorFactory.createErrormessage(propertyName,
@@ -646,6 +656,46 @@
}
}
+ static class DeploymentTypeValidator implements IValidator {
+
+ String propertyName;
+
+ IDataModel model;
+
+ static final IProjectFacet EJB_FACET =
ProjectFacetsManager.getProjectFacet(IModuleConstants.JST_EJB_MODULE);
+
+ static final IProjectFacetVersion EJB_30 = EJB_FACET.getVersion("3.0");
//$NON-NLS-1$
+
+ static final IProjectFacet EAR_FACET =
ProjectFacetsManager.getProjectFacet(IModuleConstants.JST_EAR_MODULE);
+
+ static final IProjectFacetVersion EAR_50 = EAR_FACET.getVersion("5.0");
//$NON-NLS-1$
+
+ /**
+ */
+ public DeploymentTypeValidator (String propertyName, IDataModel model) {
+ this.propertyName = propertyName;
+ this.model = model;
+ }
+
+ /**
+ * @see IValidator#validate(Object, Object)
+ */
+ public Map<String, String> validate(Object value, Object context) {
+
+ final String deploymentType = value.toString();
+ if(!ISeamFacetDataModelProperties.DEPLOY_AS_WAR.equals(deploymentType))
{
+ String runtimeName =
model.getProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME).toString();
+ IRuntime rt = RuntimeManager.getRuntime(runtimeName);
+ if(!rt.supports(EJB_30) || !rt.supports(EAR_50)) {
+ return ValidatorFactory.createErrormessage(
+ propertyName,
+ NLS.bind(SeamUIMessages.SEAM_INSTALL_WIZARD_PAGE_CANNOT_USE_SELECTED_DEPLOYMENT6
, new String[]{deploymentType.toUpperCase(),runtimeName}));
+ }
+ }
+ return ValidatorFactory.NO_ERRORS;
+ }
+ }
+
public class NewSeamRuntimeAction extends
ButtonFieldEditor.ButtonPressedAction {
/**
Modified:
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/messages.properties
===================================================================
---
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/messages.properties 2007-11-21
01:01:12 UTC (rev 4996)
+++
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/messages.properties 2007-11-21
02:40:40 UTC (rev 4997)
@@ -8,6 +8,7 @@
GENERATE_SEAM_ENTITIES_WIZARD_REVERSE_ENGINEER_LABEL = Reverse engineer
from database
GENERATE_SEAM_ENTITIES_WIZARD_EXISTING_ENTITIES_LABEL = Use existing
entities
SEAM_INSTALL_WIZARD_PAGE_CONFIGURE_SEAM_FACET_SETTINGS=Configure Seam
Facet Settings
+SEAM_INSTALL_WIZARD_PAGE_CANNOT_USE_SELECTED_DEPLOYMENT6=''{0}''
deployment cannot be used, because selected Server Runtime ''{1}'' doesn't
support EJB 3.0 and EAR 5.0 modules
SEAM_PROJECT_WIZARD_PAGE1_FILE_NAME_MUST_BE_SPECIFIED=File name must be
specified
SEAM_PROJECT_SELECTION_DIALOG_SELECT_SEAM_WEB_PROJECT=Select Seam Web
Project
SEAM_PROJECT_WIZARD_CREATE_STANDALONE_SEAM_WEB_PROJECT=Create standalone
Seam Web Project
_______________________________________________
jbosstools-commits mailing list
jbosstools-commits(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-commits
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
17 years, 1 month
XULRunner / ATF Update site
by Marshall Culpepper
Hey everyone..
Recently I was looking over ATF's update site format to get a clue for
how dependency on Mozilla's XPCOM and XULRunner plugins was handled. I
found that the main ATF feature itself does depend on org.mozilla.xpcom,
but not any of the XULRunner features/plugins. I also ran into another
interesting problem. XULRunner has been bundled as a seperate feature
for each platform implementation, and the plugins themselves live at a
different URL than the features that I found.
The 3 platform-dependent XULRunner plugins live at the following URL:
-
http://releases.mozilla.org/pub/mozilla.org/xulrunner/releases/1.8.1.3/co...
And the 3 platform-dependent XULRunner features live at the following URL:
- http://ftp.mozilla.org/pub/mozilla.org/xulrunner/eclipse/features/
But the plugins listed at the corresponding "plugins" dir are outdated!
- http://ftp.mozilla.org/pub/mozilla.org/xulrunner/eclipse/plugins/
I have a few questions since this was rather confusing..
1) Why are the URLs for feature JARs and plugins so radically different?
Shouldn't the features / plugins dirs be in sync with each other?
2) Why is XULRunner packaged as 3 seperate features? This becomes hell
for dependency management purposes. It was easier for me to just write
one simple feature and put platform/OS conditions on each XULRunner
plugin. You can find my feature.xml here:
-
http://anonsvn.jboss.org/repos/jbosstools/trunk/vpe/features/org.jboss.to...
3) Why isn't ATF depending on XULRunner feature/plugins like it is with
XPCOM? With the feature linked above we were able to have our feature
depend on it, and use external plugin/feature jar linking (ala the
current ATF update site) to have Eclipse auto-check XULRunner when the
user presses "Select Required"
Just hoping to get some clarity on how ATF depends on XULRunner and
how/if we can reuse that knowledge for our project =).
Thanks!
--
Marshall Culpepper
Red Hat Developer Studio, JBoss Tools
marshall(a)jboss.org
17 years, 1 month
