Should we use @Ignore in non-runnable JUnit test classes, instead of <include> in pom? (was: JUnit Tests)
by Nick Boldt
No, because then AbstractTest* and TemplateTest* classes would run, and
they shouldn't be.
You can set your own <include> entries in your root pom. Then all your
projects' tests will inherit those new rules.
--
We may also have some older JUnit 3 tests (from the JDK 1.4 era?) that
might still be set to run with older JRE environments, where
@annotations are not supported.
If I'm wrong on that, and we no longer support running tests w/ old
runtimes, then yes, we could consider adding @Ignores to all the tests
which shouldn't be run, instead of using the "All" and "Suite" naming
conventions.
--
I've cc:'d the jbosstools-dev list because a wider audience might be
able to comment better on if it's time to move to using @ignore instead
of using restrictive patterns when running JUnits w/ Surefire in
Tycho/Maven builds.
N
On 01/22/2015 02:08 PM, Daniel Florian wrote:
> Guys,
>
> We currently have to add each JUnit test class to a test suite file called AllTests.java. If a test does not get added to this test suite it does not get run.
>
> I think the pom has this:
>
> <includes>
> <include>**/AllTests.class</include>
> <include>**/*AllTests*.class</include>
> <include>**/*AllBotTests*.class</include>
> <include>**/*TestSuite*.class</include>
> </includes>
>
> Could we add:
>
> <include>**/Test*.class</include>
> <include>**/*Test.class</include>
>
> So that we wouldn't need an AllTests.java. Other projects can keep using the test suite approach.
>
> With JUnit's @Ignore it is easy to stop a test from being run.
>
> wdyt?
>
> Thanks,
>
> Dan
>
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
11 years, 1 month
4.2.x is now open for 4.2.3 (that will be included in Developer Studio 8.1)
by Max Rydahl Andersen
Hi,
Just a heads up that now that we have tagged and released 4.2.2, the
jbosstools-4.2.x branch
are open for issues related to 4.2.3.
This 4.2.3 is planned to be what is included in JBoss Developer Studio
8.1.
Please be aware that this version is intended to backwards compatible
with the 4.2 releases;
especially consideration is to be sure we do not break Integration stack
in context of
changed dependencies or any API they use.
Thus as always, take care in what changes you do, have a jira for each
work so QE/docs are aware
and don't be afraid to ask for more than one review of PRs if any
doubts.
Happy 8.1!
/max
http://about.me/maxandersen
11 years, 1 month
Security for in TP 4.41.2.CR1-SNAPSHOT: JGit
by Mickael Istria
Hi,
Some of you may be aware that a vulnerability was found in most Git
clients (including JGit):
https://bugs.eclipse.org/bugs/show_bug.cgi?id=456947
In order to not propagate this vulnerability, we've updated the target
platform 4.41.2.CR1-SNAPSHOT to ship a fixed version of EGit/JGit.
Parent pom 4.2.2-SNAPSHOT will be updated to consume the modified
4.41.2.CR1-SNAPSHOT target-platform.
Jobs for jbosstools-4.2.x branch will be updated to consume and ship the
modified 4.41.2.CR1-SNAPSHOT target-platform.
Then, when we have made the necessary test to validate that our change
has the expected effect on JBoss Tools and JBoss Developer Studio, we'll
release this 4.41.2.CR1-SNAPSHOT target-platform as a 4.41.2.Final,
re-update parent pom and jobs, and we'll be able to proceed with staging
of JBT 4.2.2/JBDS 8.0.2.
Cheers,
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
11 years, 2 months