Re: [jbosstools-dev] Memory Leak in Docker Containers View
by Alexey Kazakov
Moving to jbosstools-dev.
OK. This memory leak seems to be bad. Please continue to work on proper
bug fix and update for the Linux/Docker Tools for Neon but I'm afraid we
don't have time to change anything in our Target Platform for devstudio
10 GA / JBoss Tools 4.4.0.Final at this point.
Thanks.
On 06/10/2016 12:56 PM, Jeff Johnston wrote:
> Should be Neon only as status icons were added for Neon M1 milestone. There
> may be other image leaks in Mars, but they are minor and no errors have shown
> in our testing or customer usage.
>
> -- Jeff J.
>
> ----- Original Message -----
>> Is this bug in Neon branch only? What about Mars releases?
>>
>>
>> On 06/10/2016 12:38 PM, Jeff Johnston wrote:
>>> It appears that the issue I found has been around since Aug 2015 (Neon M1).
>>> I have a fix
>>> and there appears to be another possible leak in the DockerExplorerView
>>> which I
>>> am pushing a fix for currently.
>>>
>>> I noticed the memory leak the other day and during my testing I saw that
>>> images
>>> were being left behind to the point that the Eclipse MAT tool took notice
>>> over a
>>> short period and flagged it as a suspected memory leak. Docker Containers
>>> get refreshed every 15 seconds so Views
>>> that show them (Docker Containers View and Docker Explorer View) that use
>>> icons need
>>> to dispose of them properly. For the Docker Containers View, all
>>> containers were being
>>> given a new image each refresh period. The Explorer View isn't much of a
>>> problem because
>>> it is node-based and doesn't always show the full list of Containers. A
>>> short list of Containers
>>> will slow down the leak as will closing the View.
>>>
>>> My intention was to do a quick rebuild of the stable-5.0 branch and save it
>>> as RC4a repo. If desired,
>>> I can do a point release, but this requires more changes to all features
>>> and pom files to renumber
>>> them. Let me know if a point release is required.
>>>
>>> I will continue with the task of building an RC4a repo that will be saved
>>> in the Linux Tools download
>>> area. Neon users will have to use the updates-nightly-neon repo which will
>>> have
>>> the fix (same git branch is used to create the RC4a repo).
>>>
>>> -- Jeff J.
>>>
>>> ----- Original Message -----
>>>> When did it happen? How long do you have it in Docker Tools.
>>>>
>>>> Have you already fixed it? Released the updated 2.0.1?
>>>>
>>>> On 06/10/2016 11:19 AM, Jeff Johnston wrote:
>>>>> This issue was introduced with a change to adding status icons in the
>>>>> Containers View. It wasn't noticed because it requires a long time to
>>>>> show (small image icons not being disposed of).
>>>>>
>>>>> -- Jeff J.
>>>>>
>>>>> ----- Original Message -----
>>>>>> We will conceder to include any updated in respin-b besides branding
>>>>>> only if we have to fix some very bad issues. Real blocker.
>>>>>> Is this issue is old or some new regression?
>>>>>>
>>>>>> On 06/10/2016 10:57 AM, Xavier Coulon wrote:
>>>>>>> From my understanding, Jeff noticed the issue after letting Eclipse
>>>>>>> run
>>>>>>> all night long, but I don't remember if Eclipse was then unusable or
>>>>>>> crashed.
>>>>>>> Anyway, it could be serious enough it users have the Docker tooling
>>>>>>> views
>>>>>>> open in their workspace.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Xavier
>>>>>>>> On 10 Jun 2016, at 12:37, Alexey Kazakov <alkazako(a)redhat.com> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> How bad is that leak?
>>>>>>>>
>>>>>>>>
>>>>>>>>> On Jun 10, 2016, at 4:33 AM, Xavier Coulon <xcoulon(a)redhat.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Fred, Alexey,
>>>>>>>>>
>>>>>>>>> Jeff J. found a memory leak in the Docker tooling. It's too late for
>>>>>>>>> Neon.0 RC4/Final, but he proposes that we cut a Linux Tools 5.0.1 /
>>>>>>>>> Docker Tooling 2.0.1 to address this specific issue.
>>>>>>>>> Is this something that can be included in the upcoming "respin-b"
>>>>>>>>> build
>>>>>>>>> along with the branding updates ? I understand that Alexey initially
>>>>>>>>> said that this ultimate build would not include any other bug fix,
>>>>>>>>> but
>>>>>>>>> nonetheless, I'm asking the question ;-)
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>> /Xavier
>>>>>>>>>
>>>>>>>>>> Hi Xavier,
>>>>>>>>>>
>>>>>>>>>> Jeff here. I found a memory leak in the Docker Containers View. I
>>>>>>>>>> believe it is fixed with my gerrit patch. If JBoss wants, I can
>>>>>>>>>> create
>>>>>>>>>> a
>>>>>>>>>> special repo for them to use to remove this bug. The fix is too
>>>>>>>>>> late
>>>>>>>>>> for
>>>>>>>>>> Neon, but we can cut a point release if necessary or wait until 5.1
>>>>>>>>>> and
>>>>>>>>>> fix it in the updates-nightly-neon.
>>>>>>>>>>
>>>>>>>>>> The problem was with the images used for status in the Table. They
>>>>>>>>>> were
>>>>>>>>>> constantly being created via createImage() but never stored any
>>>>>>>>>> where
>>>>>>>>>> and
>>>>>>>>>> never disposed. I simply created 3 images for status and return one
>>>>>>>>>> of
>>>>>>>>>> 3
>>>>>>>>>> for each table entry, then dispose of them in the Containers View
>>>>>>>>>> dispose
>>>>>>>>>> method.
>>>>>>>>>>
>>>>>>>>>> -- Jeff J.
>>
8 years, 6 months
Eclipse Neon.0.RC4b respin today
by Nick Boldt
Eclipse Neon.0.RC4 will be respun today.
This only affects Integration Stack (new BPMN2 modeler) afaiu.
We could chose to change our target platform today as well to pick up
the Docker Tooling fix, if we want.
@alexey, please advise.
---------- Forwarded message ----------
From: David M Williams <david_williams(a)us.ibm.com>
Date: Mon, Jun 13, 2016 at 12:07 PM
Subject: [cross-project-issues-dev] Respin of SimRel Repository required
To: cross-project-issues-dev(a)eclipse.org
Extended team,
I am beginning a re-spin of the Sim. Release repository.
Two major changes: SOA-BPN2 modeler removed and Window Builder removed.
The former removed because they didn't finish the normal release
requirements. The later was removed because it has not been tested
with the Neon candidate release. (It did recently, after RC4, get a
build which "removed one line of code" which prevented it from running
on Neon ... but, our goal is not for projects to "join at the last
minute" but to be part of the train for many milestones so it can be
adequately tested).
It is my understanding both projects plan to "rejoin the train" in the
September release.
A minor change: Linux Tools found a major memory leak which would
normally not be "respin worthy", but I told them if we had to respin
for other reasons they could include a fix for that.
The EPP packages will need to be rebuilt of course -- first because
they always are if the repository changes, but more so this time
because Window Builder was included in two EPP packages and of course
will have to be removed from those packages.
I will update this list once both steps are complete.
Thanks,
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev(a)eclipse.org
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
--
Nick Boldt :: Productization Lead :: JBoss Tools & Dev Studio :: Red Hat, Inc.
http://nick.divbyzero.com
8 years, 6 months
No respin-a today; hope to have something on Monday or Tuesday
by Nick Boldt
Due to build issues last night and today brought on by branching & updating
master to 4.4.1.Alpha1 (and having those bits "leak" into the 4.4.0.x
builds), respin-a for 10.0.0.GA <http://10.0.0.ga/> & 4.4.0.Final will not
be ready in time today.
I plan to start the process up again Sunday night (assuming I survive my
climbing trip to Bon Echo) and will hopefully have something QE can use on
Monday or Tuesday.
Apologies, but too much change too fast at the last minute (target platform
move to RC4, master updates to Alpha1, time lost to discussion and vetting
of branding changes) have conspired to break the build.
With the saddest of trombones,
Nick
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
8 years, 6 months
Docker connections in Docker Tooling - request for feedback
by Martin Malina
Hi all,
We are looking into ways to improve the Docker Tooling UI in Eclipse and would like to ask for help.
Xavier and I discussed one scenario which is currently quite confusing, it is described here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=495600
In short, this is the use case:
1. Start CDK
2. Connect to Docker
3. Stop CDK
4. Start CDK
5. Connect to Docker
- here I was failing for a long time until Xavier told me I needed to click this "Enable Connection" button, to make the connection work again.
This issue was previously discussed here: https://issues.jboss.org/browse/JBDS-3739
We would appreciate if any of you had any suggestions how to improve this.
Thanks
Martin
--
Martin Malina
JBoss QA Engineer
Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno, Czech Republic
Tel.: +420 532 294 265
8 years, 6 months
ACTION REQUIRED: Code Freeze for Sprint 115 :: prepare for this week's staging build
by Nick Boldt
* Target platform will be updated ASAP to move to *Neon.0.RC2*. Watch for
email updates.
* Task JIRAs will be sent out tomorrow, and you will *create a branch &
update your root poms* to use the latest parent pom.
* Code freeze for all projects' jbosstools-4.4.x branches will start *Thursday
at 2pm PST / 5pm EST / 11pm CST*.
(We're back to the old way of branching and updating root & parent poms.
Did you enjoy the lightweight approach? Tell us!)
* *build will run Thursday night* and be copied to /staging/ on Friday
morning EST.
* *From Fri until the end of the sprint, you should *NOT* push anything
into the jbosstools-4.4.x stable branch unless it's a blocker fix approved
by Alexey*
** *master branch is open for new work once you've created your
jbosstools-4.4.x branch.
----
Looking ahead...
We will be moving from Neon.0.RC2 to RC4 next week as soon as the *RC4 bits
are available, starting on Jun 8 or 9*.
There will be a *respin on Jun 10* to move up to RC4. This will hopefully
the LAST build before *GA on June 14.*
I hope to go rock climbing at a place call Bon Echo the weekend of June
11-12. So... please, if you need to cause/find/fix blockers, please do so
before Jun 8 so they can be fixed at the same time as the TP update on Jun
9 -- thanks!
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
8 years, 6 months
