Re: [jbosstools-dev] parent pom variable jbosstools-site-stream has been renamed to jbosstools_stream in master branch

I never suggested we rename EVERYTHING. Just the variables we use both in Maven commandline and Jenkins. So far, the only one that I've seen in both which also can be used in bash scripts which handle publishing (the new simpler rsync.sh) is the variable for the stream (master vs. 4.3.mars). Yes, we could rename all the vars that are affected, but many of them are only needed by Maven, and need not be reused when publishing / running shell scripts.

On 03/13/2015 11:03 AM, Max Rydahl Andersen wrote: > Also, this is not just one variable that has this form so it's a much > bigger change that just a single property. > > On a loose count I saw over 24. > > /max > http://about.me/maxandersen > > >> On 13 Mar 2015, at 05:33, Nick Boldt <nboldt(a)redhat.com&gt; wrote: >> >> You can't do shell expansion of variables with dashes in the name. >> >> $ jbosstools-site-stream=4.3.mars >> bash: jbosstools-site-stream=4.3.mars: command not found >> >> $ set jbosstools-site-stream=4.3.mars >> $ echo ${jbosstools-site-stream} >> site-stream >> >> $ export jbosstools-site-stream=4.3.mars >> bash: export: `jbosstools-site-stream=4.3.mars': not a valid >> identifier >> >> More: >> http://unix.stackexchange.com/questions/23659/can-shell-variable-include-... >> >> So... it doesn't work. >> >> But if you prefer I can use jbosstools_site_stream instead of >> jbosstools_stream. Either way the old one is set to the new one [1] >> so that old jobs can keep using the deprecated one. >> >> [1] >> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... >> >> >>> On 03/12/2015 10:56 PM, Max Rydahl Andersen wrote: >>> I just tried and I don't see any problems using x-y-z in neither >>> Jenkins or scripts. >>> >>> Can you elaborate more please ? >>> >>> /max >>> http://about.me/maxandersen >>> >>> >>>> On 12 Mar 2015, at 14:20, Nick Boldt <nboldt(a)redhat.com&gt; wrote: >>>> >>>> TL;DR: >>>> >>>> jbosstools-site-stream is now jbosstools_stream; if you use >>>> jbosstools-site-stream, please update your poms/jobs for JBT >>>> 4.3/JBDS 9. >>>> >>>> --- >>>> >>>> I've had to rename the parent pom Maven variable >>>> <jbosstools-site-stream> in order to reuse it in Jenkins job >>>> configs. >>>> This allows us to override it in Jenkins AND use the same value in >>>> shell >>>> scripts to define where content is published on the server, as per >>>> the >>>> new reorg going on for JBT 4.3 / JBDS 9 [1]. >>>> >>>> The new variable is jbosstools_stream; I intentionally renamed it >>>> rather >>>> than just swapping dashes (not allowed in bash variables) for >>>> underscores (allowed) so it would be more obvious. >>>> >>>> [1] https://issues.jboss.org/browse/JBDS-3208 >>>> >>>> As far as I can tell, the only affected projects are: >>>> >>>> jbosstools-build [2] >>>> jbosstools-central [3] >>>> jbosstools-integration-tests [4] >>>> jbdevstudio-product [5] >>>> >>>> [2] https://github.com/jbosstools/jbosstools-build/pull/178 >>>> [3] https://github.com/jbosstools/jbosstools-central/pull/325 >>>> [4] >>>> https://github.com/jbosstools/jbosstools-integration-tests/pull/884 >>>> [5] https://github.com/jbdevstudio/jbdevstudio-product/pull/280 >>>> >>>> Note that the old variable is *still in the parent pom*, but it is >>>> now >>>> deprecated & derived from the the new one [6]. >>>> >>>> [6] >>>> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... >>>> >>>> -- >>>> Nick Boldt :: JBoss by Red Hat >>>> Productization Lead :: JBoss Tools & Dev Studio >>>> http://nick.divbyzero.com >>>> _______________________________________________ >>>> jbosstools-dev mailing list >>>> jbosstools-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >> >> -- >> Nick Boldt :: JBoss by Red Hat >> Productization Lead :: JBoss Tools & Dev Studio >> http://nick.divbyzero.com -- Nick Boldt :: JBoss by Red Hat Productization Lead :: JBoss Tools & Dev Studio http://nick.divbyzero.com