1:30 p.m.
Hey all:
I've made a comment over on https://issues.jboss.org/browse/JBIDE-18709
investigating the issue of anonymous downloads as it pertains to alpha
releases, stacks, and JBT as a group.
It'd be good if those addressed directly above (david, rafael) had a
look just so that everyone's aware of the issues of adding any Alpha
release to JBoss Stacks.
The tl;dr of it is: if we do add alpha releases to stacks, we must
still use the jdf URL, and we must still set requiresCredentials=true,
even though it's not accurate. Otherwise we risk breaking older releases
of JBT.
Any questions or comments are welcome and encouraged on the jira issue
directly.
Thanks in advance.
- Rob Stryker
1:40 p.m.
Hi Rob,
using the /jdf links is the right way to do on your side. However I do not understand the
requiresCredentials issue is. Is it a problem on your side or does the service return you
something unexcpected? If so, have you checked you saved the changes?
David
----- Original Message -----
From: "Rob Stryker" <rstryker(a)redhat.com>
To: "jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>,
"Rafael Benevides" <benevides(a)redhat.com>, "David Hladky"
<dhladky(a)redhat.com>
Sent: Friday, 6 February, 2015 1:30:10 PM
Subject: Anonymous Downloads for Alpha release, JBT, and Stacks
Hey all:
I've made a comment over on https://issues.jboss.org/browse/JBIDE-18709
investigating the issue of anonymous downloads as it pertains to alpha
releases, stacks, and JBT as a group.
It'd be good if those addressed directly above (david, rafael) had a
look just so that everyone's aware of the issues of adding any Alpha
release to JBoss Stacks.
The tl;dr of it is: if we do add alpha releases to stacks, we must
still use the jdf URL, and we must still set requiresCredentials=true,
even though it's not accurate. Otherwise we risk breaking older releases
of JBT.
Any questions or comments are welcome and encouraged on the jira issue
directly.
Thanks in advance.
- Rob Stryker
2:04 p.m.
On 02/06/2015 08:40 PM, David Hladky wrote:
Hi Rob,
using the /jdf links is the right way to do on your side. However I do not understand the
requiresCredentials issue is. Is it a problem on your side or does the service return you
something unexcpected? If so, have you checked you saved the changes?
David
Stacks.yaml has various labels we can add to their list of runtimes. One
of the labels we added was 'requiresCredentials". Past (and current)
versions of jbosstools interpret this flag to mean 'go through the jboss
download-manager workflow', where we set the custom request headers.
Otherwise, if requiresCredentials is set to false, we basically do a
generic wget / curl request with no xml headers at all. We treat it the
same way as we would a zip file on sourceforge or any web server.
So if we set that to false, we would do a generic request to the jdf url
with no request headers at all, and this in turn downloads what is an
html page.
Does that make sense?
----- Original Message -----
From: "Rob Stryker" <rstryker(a)redhat.com>
To: "jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>,
"Rafael Benevides" <benevides(a)redhat.com>, "David Hladky"
<dhladky(a)redhat.com>
Sent: Friday, 6 February, 2015 1:30:10 PM
Subject: Anonymous Downloads for Alpha release, JBT, and Stacks
Hey all:
I've made a comment over on https://issues.jboss.org/browse/JBIDE-18709
investigating the issue of anonymous downloads as it pertains to alpha
releases, stacks, and JBT as a group.
It'd be good if those addressed directly above (david, rafael) had a
look just so that everyone's aware of the issues of adding any Alpha
release to JBoss Stacks.
The tl;dr of it is: if we do add alpha releases to stacks, we must
still use the jdf URL, and we must still set requiresCredentials=true,
even though it's not accurate. Otherwise we risk breaking older releases
of JBT.
Any questions or comments are welcome and encouraged on the jira issue
directly.
Thanks in advance.
- Rob Stryker
4:21 p.m.
OK David:
So after discussion with Max, having the stacks.yaml say
requiresCredentials=true when it doesn't, just to work around the
existing workflow, is wrong and we shouldn't do that.
Is there any chance we can get the JDF url on download manager to do the
following?
1) Check if the requested file is set to Anonymous Download
2) If yes,
a) Check if it looks like we're coming from a browser (either by
checking user agent or response flags)
b) if yes, do the website stuff, else
c) just return the file as if it was a normal wget
Basically, what we're requesting is that a wget
http://www.jboss.org/download-manager/jdf/file/jboss-eap-6.4.0.Alpha.zip
just downloads the file if it looks like we're not a browser.
- Rob Stryker
On 02/06/2015 08:40 PM, David Hladky wrote:
Hi Rob,
using the /jdf links is the right way to do on your side. However I do not understand the
requiresCredentials issue is. Is it a problem on your side or does the service return you
something unexcpected? If so, have you checked you saved the changes?
David
----- Original Message -----
From: "Rob Stryker" <rstryker(a)redhat.com>
To: "jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>,
"Rafael Benevides" <benevides(a)redhat.com>, "David Hladky"
<dhladky(a)redhat.com>
Sent: Friday, 6 February, 2015 1:30:10 PM
Subject: Anonymous Downloads for Alpha release, JBT, and Stacks
Hey all:
I've made a comment over on https://issues.jboss.org/browse/JBIDE-18709
investigating the issue of anonymous downloads as it pertains to alpha
releases, stacks, and JBT as a group.
It'd be good if those addressed directly above (david, rafael) had a
look just so that everyone's aware of the issues of adding any Alpha
release to JBoss Stacks.
The tl;dr of it is: if we do add alpha releases to stacks, we must
still use the jdf URL, and we must still set requiresCredentials=true,
even though it's not accurate. Otherwise we risk breaking older releases
of JBT.
Any questions or comments are welcome and encouraged on the jira issue
directly.
Thanks in advance.
- Rob Stryker
10:45 a.m.
On 6 Feb 2015, at 16:21, Rob Stryker wrote:
OK David:
So after discussion with Max, having the stacks.yaml say
requiresCredentials=true when it doesn't, just to work around the
existing workflow, is wrong and we shouldn't do that.
To be clear - since the intent of the Alpha releases are to be available
to everyone with or without jboss.org username requiring credentials
would be wrong.
Of course if we can't actually get the server side to behave like it is
really anonymous then
we could be forced to do this.
Is there any chance we can get the JDF url on download manager to do
the
following?
1) Check if the requested file is set to Anonymous Download
2) If yes,
a) Check if it looks like we're coming from a browser (either by
checking user agent or response flags)
b) if yes, do the website stuff, else
c) just return the file as if it was a normal wget
Basically, what we're requesting is that a wget
http://www.jboss.org/download-manager/jdf/file/jboss-eap-6.4.0.Alpha.zip
just downloads the file if it looks like we're not a browser.
+1, if the content is anonymously available might just as well hand it
out directly without
showing the html page when the one requesting it is not a browser.
/max
- Rob Stryker
On 02/06/2015 08:40 PM, David Hladky wrote:
> Hi Rob,
>
> using the /jdf links is the right way to do on your side. However I
> do not understand the requiresCredentials issue is. Is it a problem
> on your side or does the service return you something unexcpected? If
> so, have you checked you saved the changes?
>
> David
>
> ----- Original Message -----
> From: "Rob Stryker" <rstryker(a)redhat.com>
> To: "jbosstools-dev jbosstools-dev" <jbosstools-dev(a)lists.jboss.org>,
> "Rafael Benevides" <benevides(a)redhat.com>, "David Hladky"
> <dhladky(a)redhat.com>
> Sent: Friday, 6 February, 2015 1:30:10 PM
> Subject: Anonymous Downloads for Alpha release, JBT, and Stacks
>
> Hey all:
>
> I've made a comment over on
> https://issues.jboss.org/browse/JBIDE-18709
> investigating the issue of anonymous downloads as it pertains to
> alpha
> releases, stacks, and JBT as a group.
>
> It'd be good if those addressed directly above (david, rafael) had a
> look just so that everyone's aware of the issues of adding any Alpha
> release to JBoss Stacks.
>
> The tl;dr of it is: if we do add alpha releases to stacks, we must
> still use the jdf URL, and we must still set
> requiresCredentials=true,
> even though it's not accurate. Otherwise we risk breaking older
> releases
> of JBT.
>
> Any questions or comments are welcome and encouraged on the jira
> issue
> directly.
>
> Thanks in advance.
>
> - Rob Stryker
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
/max
http://about.me/maxandersen
3364
days inactive
3367
days old
jbosstools-dev@lists.jboss.org
4 comments
3 participants
participants (3)
-
David Hladky -
Max Rydahl Andersen -
Rob Stryker