Any mention of "merging" content from Early Access TP worries me ;)

What is the actual resulting diff here ? your p2diff shows zero differences so that is worrisome.

trying to grok the PR changes but i'm honestly not following the actual change ;/

What is the "merge" you want to do ? Earlyaccess should have *zero* overlap with the core TP and should not *add* new things to it to begin with so there must be something i'm not grokking here...?

Yes, did you verify we end up only publishing the "partial" target platforms ? (i.e. non-merged ones)

On 11 Jun 2014, at 14:43, Nick Boldt wrote: >> Any mention of "merging" content from Early Access TP worries me ;) > > The idea is to remove IUs that are already in the JBT and JBT Central > TPs, so that Early Access can simply be the things not already in the > other ones. > > As it stands, I was required to add a big pile of IUs to the > earlyaccess .target file just to get it to resolve... 100s of IUs > later it still wouldn't completely work unless you'd already installed > the JBT TP first. sure. got it. >> What is the actual resulting diff here ? your p2diff shows zero >> differences so >> that is worrisome. > > My diff shows 3 IUs changed - from 4.0.2 to 4.0.3. Please look again. I meant it showed zero differences in context of "removal of duplicate content". But now that you explained that is just in the .target files and not the generated update sites then this should be fine. > Because we can't just assume they're previously installed, we have to > include them and make sure the EA site works for both JBT and JBDS. > Hence, .target file merging. Yes, did you verify we end up only publishing the "partial" target platforms ? (i.e. non-merged ones) /max http://about.me/maxandersen

Here is a proposal for a change to the JBoss Central 4.40.0.Beta3-SNAPSHOT target platform: 1. https://github.com/jbosstools/jbosstools-download.jboss.org/pull/368 2. https://github.com/jbosstools/jbosstools-discovery/pull/168 It consists in the following change: * JBIDE-14971 Generate Abstract Syntax Tree fails - so update to PMD 4.0.3 I would also like to push this PR, which resolves missing upstream dependencies by merging the Central (and new Central Early Access TP) with the JBT TP. https://github.com/jbosstools/jbosstools-discovery/pull/167 It consists of the following change: * JBIDE-17560 use JBTIS style of TP merging for JBT Central and Early Access TPs, in order to reduce dupe entries in the TPs -- p2diff report: < net.sourceforge.pmd.eclipse.feature.group [4.0.2.v20131031-1124] < net.sourceforge.pmd.eclipse.feature.jar [4.0.2.v20131031-1124] < net.sourceforge.pmd.eclipse.plugin [4.0.2.v20131031-1124] > net.sourceforge.pmd.eclipse.feature.group [4.0.3.v20140427-0831] > net.sourceforge.pmd.eclipse.plugin [4.0.3.v20140427-0831] > net.sourceforge.pmd.eclipse.feature.jar [4.0.3.v20140427-0831] -- Please review the above PR(s), as it will be applied in the next *2 days*. (If there are no objections to the above PRs, I will push in PR 169, which combines both into a single merged PR.) https://github.com/jbosstools/jbosstools-discovery/pull/169 You can use the following to build & test the TP locally against your component(s). Build target-platform: $ cd jbosstools-discovery $ git fetch nickboldt JBIDE-14971_merged $ git checkout FETCH_HEAD To build and verify, perform these steps: https://github.com/jbosstools/jbosstools-devdoc/blob/master/building/targ... Or use this script: https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/verify... -- Once you've built the target platform you can use it as the back end to Central like this: https://github.com/jbosstools/jbosstools-discovery/blob/master/README.dis... (Or you can just install from the target platform site directly into Eclipse / JBDS, which is much easier but the same UI experience.) -- If you want to perform a scripted install of the entire target platform into your local Eclipse or JBDS instance, you can now do so with this script: https://github.com/jbosstools/jbosstools-build-ci/blob/master/util/verify... Usage is documented in the above script, and in this README: https://github.com/jbosstools/jbosstools-devdoc/blob/master/building/targ...