11:50 a.m.
Hi guys,
I just noticed that CorePlugin now has a hard branded version id and
custom version comparison in it ?
May I ask why ?
...and what is wrong with using the versioning in the plugin.xml etc.
instead of a new concept ?
If it is just to get a "release name" why not just put it in the resource
bundle ?
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
4:20 p.m.
The purpose of adding that was so that plugin providers can add update
wizards from version x to version y with relative ease via an extension
point.
They can now do something like, from version 1.5.* to version 2.0.0.*, use
<insert class> as a wizard page.
I probably just didn't see the versioning in the plugin.xml and hard-coded
it. I suppose I figured that we'd have to change something, either in a
plugin.xml, or text resource, or class file, and it didn't seem to matter
much to me which we did. I realize changing that in two places is bad, so I
just wasn't aware that it was already somewhere.
So... ... ... where was the version stored previously? I can change it to
just use that.
- Rob
On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
Hi guys,
I just noticed that CorePlugin now has a hard branded version id and
custom version comparison in it ?
May I ask why ?
...and what is wrong with using the versioning in the plugin.xml etc.
instead of a new concept ?
If it is just to get a "release name" why not just put it in the resource
bundle ?
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
_______________________________________________
jbosside-dev mailing list
jbosside-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosside-dev
6:41 p.m.
So... ... ... where was the version stored previously? I can change
it to
just use that.
eh ? You do know that eclipse has a very strict system with versioning
right ? :)
Just use the plugin version number...how you get I actually don't know but
the updatemanager
must be getting it from somewhere.
/max
- Rob
On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
>
> Hi guys,
>
> I just noticed that CorePlugin now has a hard branded version id and
> custom version comparison in it ?
>
> May I ask why ?
>
> ...and what is wrong with using the versioning in the plugin.xml etc.
> instead of a new concept ?
>
> If it is just to get a "release name" why not just put it in the
> resource
> bundle ?
>
> --
> --
> Max Rydahl Andersen
> callto://max.rydahl.andersen
>
> Hibernate
> max(a)hibernate.org
> http://hibernate.org
>
> JBoss a division of Red Hat
> max.andersen(a)jboss.com
> _______________________________________________
> jbosside-dev mailing list
> jbosside-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosside-dev
>
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
7:04 p.m.
I'm not trying to make this a plug-in version number, but rather a JBoss IDE
release.
The wizard wont be used to upgrade from Hibernate tools x.y.c to Hibernate
Tools x.y.z, but rather from one version of JBoss IDE (as an entire product)
to another.
I really didn't want to make it go for each plugin based on plugin version,
because obviously some parts of the IDE (like yours) have multiple plug-ins,
and that could get hairy...
Of course further input is always welcomed.
(And no... I know you guys have mentioned several times the versioning of
plug-ins is very strict but I never really had to deal with it personally so
it all seemed kind of abstract to me)
- Rob
On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
> So... ... ... where was the version stored previously? I can change it
to
> just use that.
eh ? You do know that eclipse has a very strict system with versioning
right ? :)
Just use the plugin version number...how you get I actually don't know but
the updatemanager
must be getting it from somewhere.
/max
>
> - Rob
>
> On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
>>
>> Hi guys,
>>
>> I just noticed that CorePlugin now has a hard branded version id and
>> custom version comparison in it ?
>>
>> May I ask why ?
>>
>> ...and what is wrong with using the versioning in the plugin.xml etc.
>> instead of a new concept ?
>>
>> If it is just to get a "release name" why not just put it in the
>> resource
>> bundle ?
>>
>> --
>> --
>> Max Rydahl Andersen
>> callto://max.rydahl.andersen
>>
>> Hibernate
>> max(a)hibernate.org
>> http://hibernate.org
>>
>> JBoss a division of Red Hat
>> max.andersen(a)jboss.com
>> _______________________________________________
>> jbosside-dev mailing list
>> jbosside-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosside-dev
>>
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
9:45 p.m.
FYI: The plugin version _is_ the JBossIDE release (as long asyou're looking
at one of the core plugins like org.jboss.ide.eclipse.core). We are using
OSGi version standards for our release versioning so they should be
identical i.e... for Beta1 org.jboss.ide.eclipse.core should be 2.0.0.Beta1.
On 9/13/06, Robert Stryker <rob.stryker(a)jboss.com> wrote:
I'm not trying to make this a plug-in version number, but rather a JBoss
IDE release.
The wizard wont be used to upgrade from Hibernate tools x.y.c to Hibernate
Tools x.y.z, but rather from one version of JBoss IDE (as an entire
product) to another.
I really didn't want to make it go for each plugin based on plugin
version, because obviously some parts of the IDE (like yours) have multiple
plug-ins, and that could get hairy...
Of course further input is always welcomed.
(And no... I know you guys have mentioned several times the versioning of
plug-ins is very strict but I never really had to deal with it personally so
it all seemed kind of abstract to me)
- Rob
On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
>
>
> > So... ... ... where was the version stored previously? I can change it
> to
> > just use that.
>
> eh ? You do know that eclipse has a very strict system with versioning
> right ? :)
>
> Just use the plugin version number...how you get I actually don't know
> but
> the updatemanager
> must be getting it from somewhere.
>
> /max
>
> >
> > - Rob
> >
> > On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
> >>
> >> Hi guys,
> >>
> >> I just noticed that CorePlugin now has a hard branded version id and
> >> custom version comparison in it ?
> >>
> >> May I ask why ?
> >>
> >> ...and what is wrong with using the versioning in the plugin.xml etc.
> >> instead of a new concept ?
> >>
> >> If it is just to get a "release name" why not just put it in the
> >> resource
> >> bundle ?
> >>
> >> --
> >> --
> >> Max Rydahl Andersen
> >> callto://max.rydahl.andersen
> >>
> >> Hibernate
> >> max(a)hibernate.org
> >> http://hibernate.org
> >>
> >> JBoss a division of Red Hat
> >> max.andersen(a)jboss.com
> >> _______________________________________________
> >> jbosside-dev mailing list
> >> jbosside-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/jbosside-dev
> >>
>
>
>
> --
> --
> Max Rydahl Andersen
> callto://max.rydahl.andersen
>
> Hibernate
> max(a)hibernate.org
> http://hibernate.org
>
> JBoss a division of Red Hat
> max.andersen(a)jboss.com
>
_______________________________________________
jbosside-dev mailing list
jbosside-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosside-dev
--
Marshall Culpepper
marshall.culpepper(a)jboss.com
JBossIDE Team Lead
JBoss, a division of Red Hat
10:28 p.m.
I'm not trying to make this a plug-in version number, but rather
a JBoss
IDE release.
what is upgrade about ?
i'm pretty sure it is something that is bound to some plugin(s) and thus
the
plugin version is the best thing (not the brand version).
so use the relevant plugin version to decide if the upgrade is relevant.
/max
The wizard wont be used to upgrade from Hibernate tools x.y.c to
Hibernate
Tools x.y.z, but rather from one version of JBoss IDE (as an entire
product)
to another.
I really didn't want to make it go for each plugin based on plugin
version,
because obviously some parts of the IDE (like yours) have multiple
plug-ins,
and that could get hairy...
Of course further input is always welcomed.
(And no... I know you guys have mentioned several times the versioning of
plug-ins is very strict but I never really had to deal with it
personally so
it all seemed kind of abstract to me)
- Rob
On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
>
>
> > So... ... ... where was the version stored previously? I can change it
> to
> > just use that.
>
> eh ? You do know that eclipse has a very strict system with versioning
> right ? :)
>
> Just use the plugin version number...how you get I actually don't know
> but
> the updatemanager
> must be getting it from somewhere.
>
> /max
>
> >
> > - Rob
> >
> > On 9/13/06, Max Rydahl Andersen <max.andersen(a)jboss.com> wrote:
> >>
> >> Hi guys,
> >>
> >> I just noticed that CorePlugin now has a hard branded version id and
> >> custom version comparison in it ?
> >>
> >> May I ask why ?
> >>
> >> ...and what is wrong with using the versioning in the plugin.xml etc.
> >> instead of a new concept ?
> >>
> >> If it is just to get a "release name" why not just put it in the
> >> resource
> >> bundle ?
> >>
> >> --
> >> --
> >> Max Rydahl Andersen
> >> callto://max.rydahl.andersen
> >>
> >> Hibernate
> >> max(a)hibernate.org
> >> http://hibernate.org
> >>
> >> JBoss a division of Red Hat
> >> max.andersen(a)jboss.com
> >> _______________________________________________
> >> jbosside-dev mailing list
> >> jbosside-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/jbosside-dev
> >>
>
>
>
> --
> --
> Max Rydahl Andersen
> callto://max.rydahl.andersen
>
> Hibernate
> max(a)hibernate.org
> http://hibernate.org
>
> JBoss a division of Red Hat
> max.andersen(a)jboss.com
>
--
--
Max Rydahl Andersen
callto://max.rydahl.andersen
Hibernate
max(a)hibernate.org
http://hibernate.org
JBoss a division of Red Hat
max.andersen(a)jboss.com
6435
days inactive
6435
days old
jbosstools-dev@lists.jboss.org
5 comments
3 participants
participants (3)
-
Marshall Culpepper -
Max Rydahl Andersen -
Robert Stryker