[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Burr Sutter updated JBIDE-10711: -------------------------------- Attachment: Screen Shot 2012-01-25 at 11.25.59 AM.png Screen Shot 2012-01-25 at 11.25.49 AM.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10711: --------------------------------------------- I disagree that we should simply remove the error/info. If we do that you actually don't know there is a problem. Note, this can also happen on an OS where it actually should be possible to load it. Suggestions for alternative means of informing is welcome. I'm thinking simply force the default tab to source if neither can't load. then you only see it if you go to the other tabs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10711: --------------------------------------------- Yahor - so can we simply default to source tab when there are loading problems ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Yahor Radtsevich commented on JBIDE-10711: ------------------------------------------ Yes, we can and will do this. On the other hand, if users would like to use VPE, they may read FAQ and download 32-bit version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10711: ------------------------------------------- The patch should be tested and committed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10711: --------------------------------------------- Denis - if a user installs VPE on 64-bit osx then if we dont show anything he has zero idea that he could actually get it by running 32-bit. By having default tab be source and have error info on the visual page (showing the two possible errors: either "Cannot load libraries with error info" or "Visual Page Editor not available on this platform") seems to be the least intrusive way of informing the user. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10711: --------------------------------------------- You do realize the errors will not show up with the suggested fix unless you actively click on the visual pages ? Earlier on we actually "reverted" to only one page editor and we had to explain/respond to why it was missing very often. Now we add a link to the FAQ and that seem to have made these questions go away and users now know what to do to shift between them. Thus i'm fine on improving this, but making it even harder to figure out what went wrong is IMO not a good way. What do you suggest as a "nice way" ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Golovin edited comment on JBIDE-10711 at 3/5/12 4:23 PM: --------------------------------------------------------------- @Max, my point is user should not be able to install VPE on unsupported platforms, it means he/she would not expected to see any tabs in visual editor if it is not installed at all. They would be visible only when VPE is installed and only on supported platforms. There could be the problems when update deals with VPE already installed on unsupported platforms, but in this case I guess message looks logical, it just should say the same it does now and in addition it can suggest "if you don't want see all those extra tabs, just uninstall VPE". was (Author: dgolovin): @Max, my point is user should not be able to install VPE on unsupported platforms, it means he/she would not expected to see any tabs in visual editor if it is not installed at all. They would be visible only when VPE is installed and only on supported platforms. There could be the problems when update deal with VPE already installed on unsupported platforms, but in this case I guess message is also looks logical, it just should say the same is it does now and in addition it can suggest "if you don't want see all those extra tabs, just uninstall VPE". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-10711: --------------------------------------- I'll check what we can do here. My major concern that there could be functionality not related to visual representation in VPE plugin and it should be separated before we make VPE plugin optional. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10711: ------------------------------------------- The approach of not installing visual editor on the platforms where it's not supported -- seems reasonable to me also. As Yahor wrote, when vpe pluging is disabled, "JBoss Editor" still will be installed, but there will be only source part of it. "jbide10711.patch" sets up the "Source Tab" as a default when vpe plugin is started on not supported platform. So it could be applied in the scope of the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10711: ------------------------------------------- patch2 has been applied: when xulrunner is not supported -- source tab will be loaded by default. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Golovin updated JBIDE-10711: ---------------------------------- Fix Version/s: 3.3.0.CR1 (was: 3.3.0.Beta3) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10711: ------------------------------------------- Currently all three tabs of JBoss Tools Editor are available. On not supported platforms "Source Tab" is shown as a default,after user switches to "source/visual" tab -- error message is displayed. After disabling VPE only src tab should be available, like in JBIDE-7058: !https://issues.jboss.org/secure/attachment/12337037/VPE_EclipseSDK.png! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Burr Sutter commented on JBIDE-10711: ------------------------------------- Can the error message at least be end-user friendly? Like "This editor only works on 32-bit JVMs". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10711?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10711: --------------------------------------------- that message would be wrong Burr, since it does work on Linux 64 bit. No sure how to have a short, concise and correct error message covering that range. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira