[ https://jira.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin.s... ] Libor Zoubek commented on JBIDE-7822: ------------------------------------- We've done some deeper testing about this issue. Scenario A: 1. create clean workspace in path without spaces 2. start JBDS with bundled EAP 3 create simple WAR and deploy 4. go to server configuration and set deploy dir to be in your workspace Scenario B: 1. create clean workspace with space in path 2. start JBDS with bundled EAP 3 create simple WAR and deploy 4. go to server configuration and set deploy dir to be in your workspace Results A: 3.0.2-GA | 4.0.0.b1 | 4.0.0.b2 | true | true | true | - archive was deployed true | true | true | - archive was deployed after step 4 true | true | true | - deploy dir was used as set by server configuration in JBDS (checked by 'Explore' menu item on deployed archive) false | false | true | - default server configuration points deployment to workspace Results B: 3.0.2-GA | 4.0.0.b1 | 4.0.0.b2 | true | false | false | - archive was deployed true | false | false | - archive was deployed after step 4 false | true | true | - deploy dir was used as set by server configuration in JBDS (checked by 'Explore' menu item on deployed archive) false | false | true | - default server configuration points deployment to workspace That means : * 3.0.2 contains some detection of deploy dir and if it contains spaces it fallbacks to other dir (the servers default) * deployment to path with spaces never worked * in beta2 default values for creating new server changed (deploydir set to workspace) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin.s... ] Snjezana Peco commented on JBIDE-7822: -------------------------------------- The problem is caused by the change of the default deploy directory type for JBoss Server (commit 26456 Nov, 15, JBossServer.setDefaults(...) ) That change sets the DEPLOY_DIRECTORY_TYPE attribute for JBoss AS 5 to "server" and to "metadata" for the remaining servers. Before that change, the DEPLOY_DIRECTORY_TYPE attribute was "custom" The runtime plugin uses DEPLOY_DIRECTORY that is ignored when the DEPLOY_DIRECTORY_TYPE attribute is different from "custom". -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin.s... ] Rob Stryker commented on JBIDE-7822: ------------------------------------ this issue should be in JBDS jira and not JBIDE. Is there any way for the installer to warn or block when people use spaces in their JBDS install directory? Snjezana: the runtime plugin / installer should only be setting DEPLOY_DIRECTORY_TYPE to "server" for jboss 5.0. JBossAS 5.1 or better should have it set to metadata. I'll try to isolate whether the problem is in tooling or JBoss-AS's deployment scanner. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin.s... ] Snjezana Peco commented on JBIDE-7822: -------------------------------------- This is an URL encoding problem. Attached is a patch that fixes the problem. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Rob Stryker resolved JBIDE-7822. -------------------------------- Resolution: Done I've committed this fix for JBoss 5 and below... however, it still does not seem to work at all for JBoss 6. 14:52:54,927 INFO [org.jboss.web.tomcat.service.deployers.TomcatDeployment] deploy, ctxPath=/Dyn888 14:52:54,930 ERROR [org.jboss.kernel.plugins.dependency.AbstractKernelController] Error installing to Start: name=jboss.web.deployment:war=/Dyn888 state=Create mode=Manual requiredState=Installed: java.net.URISyntaxException: Illegal character in path at index 56: file:/home/rob/apps/eclipse/workspaces/main_code/runtime space workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/ at java.net.URI$Parser.fail(URI.java:2809) [:1.6.0_14] I'll open a new bug to track that and assign it upstream to AS. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Rob Stryker resolved JBIDE-7822. -------------------------------- Resolution: Done As previously mentioned, URLEncode is not an appropriate solution here. The problem with AS-6 is that the same style paths which work in AS-5.x and below do not work in AS-6 and so this is a regression of behaviour. The above bug was opened to track that issue. The final behaviour is that AS-5 and below work fine with spaces in workspace urls, but due to a regression in AS-6, AS-6 still cannot properly deploy to workspaces with spaces in the path. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] David Lloyd commented on JBIDE-7822: ------------------------------------ URLEncoder is only for HTTP query parameters, so that should be permanently excised from this discussion. :-) Passing in a URI string containing a space is an error. If tools is generating such a URI, and AS5 accepted this, then you were just lucky. You cannot expect garbage to always work. The space should be encoded as %20 to be a valid URI, and URI path separators should be used. The easiest fix would seem to be to construct URIs using the constructor which has a discrete path name argument, and thus does this encoding for you. You should never assemble a URI as a string. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-7822: -------------------------------------- I have created a patch that fixes JBAS-8734. To test it copy https://issues.jboss.org/secure/attachment/12339696/jboss-vfs.jar to $JBOSS_HOME/lib of JBoss AS 6.0CR1 and try to reproduce this issue. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Snjezana Peco updated JBIDE-7822: --------------------------------- Affects: [Release Notes] -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-7822: -------------------------------------- This is an upstream issue and I am not sure if it will be fixed in JBoss Tools 3.2.1. JBAS-8734 is targeted at JBoss AS 6.1.0. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Snjezana Peco updated JBIDE-7822: --------------------------------- Fix Version/s: (was: 3.2.1) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-7822: -------------------------------------- The issue can't be reproduced using JBoss AS 7.0.0.CR1. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7822?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen resolved JBIDE-7822. ---------------------------------------- Resolution: Won't Fix This is a problem in AS 6 which has broken api when it comes to handling spaces in deployment paths. Thus marking as won't fix as long as AS6 isn't a priority nor have the needed fix for us to fix it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira