[JBoss JIRA] (MODCLUSTER-621) maxbufsize doesn't include JVMROUTESZ
by Jean-Frederic Clere (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-621?page=com.atlassian.jira.pl... ]
Jean-Frederic Clere commented on MODCLUSTER-621:
------------------------------------------------
Yes good catch the code is obviously brokenI don't think a CONFIG message would cause a problem but ENABLE-APP for a webapp with multi alias might fail...
> maxbufsize doesn't include JVMROUTESZ
> -------------------------------------
>
> Key: MODCLUSTER-621
> URL: https://issues.jboss.org/browse/MODCLUSTER-621
> Project: mod_cluster
> Issue Type: Bug
> Components: Native (httpd modules)
> Reporter: Robert Bost
> Assignee: Jean-Frederic Clere
>
> https://github.com/modcluster/mod_proxy_cluster/blob/master/native/mod_ma...
> {code}
> if (mconf->maxmesssize)
> maxbufsiz = mconf->maxmesssize;
> else {
> /* we calculate it */
> maxbufsiz = 9 + JVMROUTESZ;
> maxbufsiz = bufsiz + (mconf->maxhost * HOSTALIASZ) + 7;
> maxbufsiz = bufsiz + (mconf->maxcontext * CONTEXTSZ) + 8;
> }
> if (maxbufsiz< MAXMESSSIZE)
> maxbufsiz = MAXMESSSIZE;
> buff = apr_pcalloc(r->pool, maxbufsiz);
> {code}
> It looks like {{maxbufsize}} will never include the {{9+JVMROUTESZ}} since it overwritten with new value in following line. Is this a problem?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (MODCLUSTER-622) segfault in process_info
by Hisanobu Okuda (JIRA)
Hisanobu Okuda created MODCLUSTER-622:
-----------------------------------------
Summary: segfault in process_info
Key: MODCLUSTER-622
URL: https://issues.jboss.org/browse/MODCLUSTER-622
Project: mod_cluster
Issue Type: Bug
Components: Native (httpd modules)
Affects Versions: 1.2.13.Final
Environment: see the private comment
Reporter: Hisanobu Okuda
Assignee: Jean-Frederic Clere
Segfault occured at process_info.
{code}
(gdb) bt
#0 process_info (r=0x7f01039b7088, errtype=<value optimized out>) at mod_manager.c:1150
#1 0x00007f00fd15b44a in manager_handler (r=0x7f01039b7088) at mod_manager.c:2705
#2 0x00007f0102927640 in ap_run_handler (r=0x7f01039b7088) at /usr/src/debug/httpd-2.2.15/server/config.c:158
#3 0x00007f010292aefe in ap_invoke_handler (r=0x7f01039b7088) at /usr/src/debug/httpd-2.2.15/server/config.c:376
#4 0x00007f0102936300 in ap_process_request (r=0x7f01039b7088) at /usr/src/debug/httpd-2.2.15/modules/http/http_request.c:282
#5 0x00007f0102933178 in ap_process_http_connection (c=0x7f00f00ebba0) at /usr/src/debug/httpd-2.2.15/modules/http/http_core.c:190
#6 0x00007f010292f148 in ap_run_process_connection (c=0x7f00f00ebba0) at /usr/src/debug/httpd-2.2.15/server/connection.c:43
#7 0x00007f010293c052 in process_socket (thd=0x7f010393a1b0, dummy=<value optimized out>) at /usr/src/debug/httpd-2.2.15/server/mpm/worker/worker.c:544
#8 worker_thread (thd=0x7f010393a1b0, dummy=<value optimized out>) at /usr/src/debug/httpd-2.2.15/server/mpm/worker/worker.c:894
#9 0x00007f01011d19d1 in ?? ()
#10 0x00007f00d8dda700 in ?? ()
#11 0x0000000000000000 in ?? ()
{code}
{code}
(gdb) disassemble
...
0x00007f00fd1558f4 <+452>: mov 0x58(%rsp),%rax
0x00007f00fd1558f9 <+457>: lea 0x82f0(%rip),%rsi # 0x7f00fd15dbf0
0x00007f00fd155900 <+464>: mov %r13,%rdi
0x00007f00fd155903 <+467>: add 0x138(%rax),%rax
=> 0x00007f00fd15590a <+474>: mov 0xc0(%rax),%r9
{code}
{code}
(gdb) x/gx $rsp+0x58
0x7f00d8dd9b98: 0x00007f01028d4e60
(gdb) x/gx 0x00007f01028d4e60+0x138
0x7f01028d4f98: 0x0000000000000140
(gdb) print/x 0x00007f01028d4e60+0x140
$1 = 0x7f01028d4fa0
(gdb) # therefore, rax should be 0x7f01028d4fa0, but in fact:
(gdb) info registers rax
rax 0xfe01a299c750 279282976409424
(gdb)
{code}
It looks occurring under race condition.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (MODCLUSTER-621) maxbufsize doesn't include JVMROUTESZ
by Robert Bost (JIRA)
Robert Bost created MODCLUSTER-621:
--------------------------------------
Summary: maxbufsize doesn't include JVMROUTESZ
Key: MODCLUSTER-621
URL: https://issues.jboss.org/browse/MODCLUSTER-621
Project: mod_cluster
Issue Type: Bug
Components: Native (httpd modules)
Reporter: Robert Bost
Assignee: Jean-Frederic Clere
Priority: Minor
https://github.com/modcluster/mod_proxy_cluster/blob/master/native/mod_ma...
{code}
if (mconf->maxmesssize)
maxbufsiz = mconf->maxmesssize;
else {
/* we calculate it */
maxbufsiz = 9 + JVMROUTESZ;
maxbufsiz = bufsiz + (mconf->maxhost * HOSTALIASZ) + 7;
maxbufsiz = bufsiz + (mconf->maxcontext * CONTEXTSZ) + 8;
}
if (maxbufsiz< MAXMESSSIZE)
maxbufsiz = MAXMESSSIZE;
buff = apr_pcalloc(r->pool, maxbufsiz);
{code}
It looks like {{maxbufsize}} will never include the {{9+JVMROUTESZ}} since it overwritten with new value in following line. Is this a problem?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (MODCLUSTER-503) Write balancer's address to Azure Blob Storage via its REST api, libcurl
by Michal Karm Babacek (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-503?page=com.atlassian.jira.pl... ]
Michal Karm Babacek commented on MODCLUSTER-503:
------------------------------------------------
The API I'm slowly putting together in my library is CRUD on BLOBs. Pretty general I would say. I'll add support for *etcd* and Kubernetes environment too.
Definitely want to be interoperable with tomcat-in-the-cloud.
Step by step to cloud born httpd and cloud born Tomcat. Not only on OpenShift/Kubernetes, but also with Rancher, Swarm...
> Write balancer's address to Azure Blob Storage via its REST api, libcurl
> ------------------------------------------------------------------------
>
> Key: MODCLUSTER-503
> URL: https://issues.jboss.org/browse/MODCLUSTER-503
> Project: mod_cluster
> Issue Type: Feature Request
> Components: Native (httpd modules)
> Environment: Azure
> Reporter: Michal Karm Babacek
> Assignee: Michal Karm Babacek
>
> * the Azure Storage C++ lib depends on Casablanca, it's bloatware, too heavy
> * we can do with simple libcurl + openssl for generating proper REST requests
> * could be done in C without much overhead
> Progress: http://modcloudstorage.net/
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months
[JBoss JIRA] (MODCLUSTER-620) Travis CI: workaround dropping openjdk6/oraclejdk7 on stable/trusty
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-620?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-620:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.3.8.Final
1.4.0.Alpha2
2.0.0.Alpha1
Resolution: Done
> Travis CI: workaround dropping openjdk6/oraclejdk7 on stable/trusty
> -------------------------------------------------------------------
>
> Key: MODCLUSTER-620
> URL: https://issues.jboss.org/browse/MODCLUSTER-620
> Project: mod_cluster
> Issue Type: Bug
> Components: CI & Packaging
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 1.3.8.Final, 1.4.0.Alpha2, 2.0.0.Alpha1
>
>
> Sigh.
> {noformat}
> $ jdk_switcher use oraclejdk7
> Switching to Oracle JDK7 (java-7-oracle), JAVA_HOME will be set to /usr/lib/jvm/java-7-oracle
> update-java-alternatives: directory does not exist: /usr/lib/jvm/java-7-oracle
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 3 months