October 2013 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-13235) Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree)

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13235?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13235: ---------------------------- Sprint: 5.0.0.Alpha2 - Sprint 2 > Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree) > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: RF-13235 > URL: https://issues.jboss.org/browse/RF-13235 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tree > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > The row key generation for Tree stopped to work: > *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > ---- > The cause was that rowKeyConverter resolves to null, so plain toString on rowKey is used. > I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the problem is that CDK generates this attribute and thus its implementation in AbstractTree (which is the correct way of rowKeyResolution) isn't used at all. > I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: > https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... > However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: > https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... > Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: > https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. > ---- > This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13237) Showcase: enable debugging tools (ui:debug, r:log) when in development mode

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13237?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-13237. ----------------------------- Resolution: Done > Showcase: enable debugging tools (ui:debug, r:log) when in development mode > --------------------------------------------------------------------------- > > Key: RF-13237 > URL: https://issues.jboss.org/browse/RF-13237 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: showcase > Affects Versions: 5.0.0.Alpha1 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 5.0.0.Alpha2 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13236) Remove left-overs of getting rid of props.xml

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13236?page=com.atlassian.jira.plugin.s... ] Brian Leathem resolved RF-13236. -------------------------------- Resolution: Rejected > Remove left-overs of getting rid of props.xml > --------------------------------------------- > > Key: RF-13236 > URL: https://issues.jboss.org/browse/RF-13236 > Project: RichFaces > Issue Type: Task > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Brian Leathem > > https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... > The two remaining props.xml files are: > * tree-model-props.xml > * validator-props.xml -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13236) Remove left-overs of getting rid of props.xml

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13236?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13236: ------------------------------------ tree-model.props.xml is still used by: * UITreeModelRecursiveAdaptor * UITreeModelAdaptor validator-props.xml is still used by: * ClientValidatorImpl These classes are not generated by the CDK, rather the xml files are used to define the attributes via faces-config.xml entries at runtime. > Remove left-overs of getting rid of props.xml > --------------------------------------------- > > Key: RF-13236 > URL: https://issues.jboss.org/browse/RF-13236 > Project: RichFaces > Issue Type: Task > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Brian Leathem > > https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... > The two remaining props.xml files are: > * tree-model-props.xml > * validator-props.xml -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13236) Remove left-overs of getting rid of props.xml

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13236?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-13236: ------------------------------- Description: https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... The two remaining props.xml files are: * tree-model-props.xml * validator-props.xml was: https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... > Remove left-overs of getting rid of props.xml > --------------------------------------------- > > Key: RF-13236 > URL: https://issues.jboss.org/browse/RF-13236 > Project: RichFaces > Issue Type: Task > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Brian Leathem > > https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... > The two remaining props.xml files are: > * tree-model-props.xml > * validator-props.xml -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13237) Showcase: enable debugging tools (ui:debug, r:log) when in development mode

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13237?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13237: ---------------------------- Sprint: 5.0.0.Alpha2 - Sprint 2 > Showcase: enable debugging tools (ui:debug, r:log) when in development mode > --------------------------------------------------------------------------- > > Key: RF-13237 > URL: https://issues.jboss.org/browse/RF-13237 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: showcase > Affects Versions: 5.0.0.Alpha1 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 5.0.0.Alpha2 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13237) Showcase: enable debugging tools (ui:debug, r:log) when in development mode

by Lukáš Fryč (JIRA)

Lukáš Fryč created RF-13237: ------------------------------- Summary: Showcase: enable debugging tools (ui:debug, r:log) when in development mode Key: RF-13237 URL: https://issues.jboss.org/browse/RF-13237 Project: RichFaces Issue Type: Enhancement Security Level: Public (Everyone can see) Components: showcase Affects Versions: 5.0.0.Alpha1 Reporter: Lukáš Fryč Assignee: Lukáš Fryč Fix For: 5.0.0.Alpha2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13236) Remove left-overs of getting rid of props.xml

by Lukáš Fryč (JIRA)

Lukáš Fryč created RF-13236: ------------------------------- Summary: Remove left-overs of getting rid of props.xml Key: RF-13236 URL: https://issues.jboss.org/browse/RF-13236 Project: RichFaces Issue Type: Task Security Level: Public (Everyone can see) Components: component Affects Versions: 5.0.0.Alpha2 Reporter: Lukáš Fryč Assignee: Brian Leathem https://github.com/richfaces/richfaces/tree/b8bdd6f5d2568da356e5103c9419f... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13235) Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree)

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13235?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13235: ---------------------------- Description: The row key generation for Tree stopped to work: *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> ---- The cause was that rowKeyConverter resolves to null, so plain toString on rowKey is used. I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the problem is that CDK generates this attribute and thus its implementation in AbstractTree (which is the correct way of rowKeyResolution) isn't used at all. I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. ---- This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. was: The row key generation for Tree stopped to work: *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> ---- I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the cause is that CDK generated this attribute and thus its implementation in AbstractTree isn't used at all. I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. ---- This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. > Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree) > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: RF-13235 > URL: https://issues.jboss.org/browse/RF-13235 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tree > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > The row key generation for Tree stopped to work: > *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > ---- > The cause was that rowKeyConverter resolves to null, so plain toString on rowKey is used. > I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the problem is that CDK generates this attribute and thus its implementation in AbstractTree (which is the correct way of rowKeyResolution) isn't used at all. > I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: > https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... > However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: > https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... > Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: > https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. > ---- > This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

[JBoss JIRA] (RF-13235) Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree)

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13235?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13235: ---------------------------- Description: The row key generation for Tree stopped to work: *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> ---- I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the cause is that CDK generated this attribute and thus its implementation in AbstractTree isn't used at all. I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. ---- This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. was: The row key generation for Tree stopped to work: *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the cause is that CDK generated this attribute and thus its implementation in AbstractTree isn't used at all. I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. ---- This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. > Tree - Row key conversion fails (UITree should not have generated @rowKeyConverter, since it is fully implemented in AbstractTree) > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: RF-13235 > URL: https://issues.jboss.org/browse/RF-13235 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-tree > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > The row key generation for Tree stopped to work: > *got:* <div id="j_idt106:tree:org.richfaces.model.SequenceRowKey[0, 0, 0]:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > *expected:* <div id="j_idt106:tree:0.0.0:j_idt111" class="rf-tr-nd rf-tr-nd-lf"> > ---- > I was wondering why rowKeyConverter isn't resolved for Tree in Showcase - the cause is that CDK generated this attribute and thus its implementation in AbstractTree isn't used at all. > I'm pretty sure this is caused by refactoring from tree-model-props.xml to use Java interfaces TreeProps and TreeCommonProps: > https://github.com/richfaces/richfaces/commit/62ab0fe3f00b44a166b522ecb71... > However it's not clear why the rowKeyConverter wasn't generated in RF 4.3 when it wasn't marked as generate=false: > https://github.com/richfaces4/components/blob/master/iteration/ui/src/mai... > Note that in RF 5 it is generated because UIAdaptor has @Attribute which defaults to generate=false: > https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > Workaround is marking rowKeyConverter as generate=false in AbstracTree (or maybe RowKeyConverter), but we should rather investigate why this issue happens. > ---- > This issue has bigger potential since during refactoring of properties, [~bleathem] could work with the same assumption as I did ^. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues October 2013