[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13233:
------------------------------------
QE: this change is meant to be idempotent, and no existing functionality should change.
[~lfryc] please perform a sanity check on the commits to the richfaces and cdk repositories.
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
> Key: RF-13233
> URL: https://issues.jboss.org/browse/RF-13233
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Labels: needs-qe
> Fix For: cdk-4.5.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-13233.
--------------------------------
Resolution: Done
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
> Key: RF-13233
> URL: https://issues.jboss.org/browse/RF-13233
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13233:
-------------------------------
Labels: needs-qe (was: )
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
> Key: RF-13233
> URL: https://issues.jboss.org/browse/RF-13233
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Labels: needs-qe
> Fix For: cdk-4.5.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13233:
------------------------------------
The change required to the CDK to enable this feature is rather innocuous. The _AddAttributesToScriptHashStatement_ class uses the _PassThrough_ to parse and hold the attribute names, which already has support for the "html" attribute name, and the "component" attribute name. In the current implementation they are just set to the same value. As such, introducing a split operation on the ":" character, and then falling back to setting the attribute names to be the same when no split is performed will leave the change idempotent for all existing use cases.
However, to make this work a change is required in the RenderkitUtils#addToScriptHash method, where the componentAttributeName is used instead of the htmlAttributeName. This has worked fine until now as the values have been the same for all scriptOptions. The change introduced to the CDK in this issue however allows for them to be different, and so the correct attribute name has to be used.
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
> Key: RF-13233
> URL: https://issues.jboss.org/browse/RF-13233
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13233?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13233:
-------------------------------
Description:
The syntax for cdk:passThrough attributes supports attribute mapping:
{code}
cdk:passThrough="onclick:onlistclick ..."
{code}
It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
{code}
<cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
{code}
was:
The syntax for cdk:passThrough attributes supports attribute mapping:
{code}
cdk:passThrough="onclick:onlistclick ..."
{code}
It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
{code}
<cdk:scriptOption wrapper="eventHandler" attributes="onchange:change ..." />
{code}
> Support attribute mapping for cdk:scriptOption
> ----------------------------------------------
>
> Key: RF-13233
> URL: https://issues.jboss.org/browse/RF-13233
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: cdk
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: cdk-4.5.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The syntax for cdk:passThrough attributes supports attribute mapping:
> {code}
> cdk:passThrough="onclick:onlistclick ..."
> {code}
> It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
> {code}
> <cdk:scriptOption wrapper="eventHandler" attributes="change:onchange ..." />
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13233) Support attribute mapping for cdk:scriptOption
by Brian Leathem (JIRA)
Brian Leathem created RF-13233:
----------------------------------
Summary: Support attribute mapping for cdk:scriptOption
Key: RF-13233
URL: https://issues.jboss.org/browse/RF-13233
Project: RichFaces
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: cdk
Reporter: Brian Leathem
Assignee: Brian Leathem
Fix For: cdk-4.5.0.Alpha2
The syntax for cdk:passThrough attributes supports attribute mapping:
{code}
cdk:passThrough="onclick:onlistclick ..."
{code}
It would be nice if the cdk:scriptOption supported similar attribute mapping, as in:
{code}
<cdk:scriptOption wrapper="eventHandler" attributes="onchange:change ..." />
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13230) Resetting table state on extendedDataTable does not reset table when using ajax re-render
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13230?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13230:
-------------------------------
Labels: regression (was: )
> Resetting table state on extendedDataTable does not reset table when using ajax re-render
> -----------------------------------------------------------------------------------------
>
> Key: RF-13230
> URL: https://issues.jboss.org/browse/RF-13230
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4
> Reporter: Immo Benjes
> Labels: regression
>
> On a extendedDataTable resetting the table state and then re-rendering the table via ajax does not work, the table still shows the custom column ordering and column width. Only when reloading the complete page, the table is displayed in its default form.
> To reproduce:
> rich:extendedDataTable with tableState help in a (e.g. Seam conversation scoped bean). Change the column ordering, now call an ajax method that resets the table state to null or an empty string. Re-render the table after completion. The column ordering stays the same.
> This used to work on RF 4.3.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13230) Resetting table state on extendedDataTable does not reset table when using ajax re-render
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13230?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-13230:
----------------------------------
Assignee: Pavol Pitonak
Pavol, can you create some tests to check if this is indeed a regression?
> Resetting table state on extendedDataTable does not reset table when using ajax re-render
> -----------------------------------------------------------------------------------------
>
> Key: RF-13230
> URL: https://issues.jboss.org/browse/RF-13230
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4
> Reporter: Immo Benjes
> Assignee: Pavol Pitonak
> Labels: regression
> Fix For: 4.3.5
>
>
> On a extendedDataTable resetting the table state and then re-rendering the table via ajax does not work, the table still shows the custom column ordering and column width. Only when reloading the complete page, the table is displayed in its default form.
> To reproduce:
> rich:extendedDataTable with tableState help in a (e.g. Seam conversation scoped bean). Change the column ordering, now call an ajax method that resets the table state to null or an empty string. Re-render the table after completion. The column ordering stays the same.
> This used to work on RF 4.3.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13230) Resetting table state on extendedDataTable does not reset table when using ajax re-render
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13230?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13230:
-------------------------------
Fix Version/s: 4.3.5
> Resetting table state on extendedDataTable does not reset table when using ajax re-render
> -----------------------------------------------------------------------------------------
>
> Key: RF-13230
> URL: https://issues.jboss.org/browse/RF-13230
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4
> Reporter: Immo Benjes
> Labels: regression
> Fix For: 4.3.5
>
>
> On a extendedDataTable resetting the table state and then re-rendering the table via ajax does not work, the table still shows the custom column ordering and column width. Only when reloading the complete page, the table is displayed in its default form.
> To reproduce:
> rich:extendedDataTable with tableState help in a (e.g. Seam conversation scoped bean). Change the column ordering, now call an ajax method that resets the table state to null or an empty string. Re-render the table after completion. The column ordering stays the same.
> This used to work on RF 4.3.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month