[JBoss JIRA] (RF-13652) Forward port the 4.3.7 fixes into the 4.5.x branch
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13652?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13652:
------------------------------------
Performing a spot check on the RF 4.3.x component fixes to see if they are included in RF 4.5 indicates that some fixes have net been applied.
For example:
* {{[869ab8|https://github.com/richfaces4/components/commit/869ab8cf75f464d0d8f83b34d7fe17ed50a3f7ae}} (for RF-13531, 4.3.6) is not applied to the 4.5.x branch
and yet the later commits
* {{[1bdc53|https://github.com/richfaces4/components/commit/1bdc53be93b1e3e84070e1f22abc54d42783277a]}}, {{[5931f8|https://github.com/richfaces4/components/commit/5931f8c3a475d39bc746dad6893da7f1e32b6241]}}, {{[150d76|https://github.com/richfaces4/components/commit/150d76e53c088f9700532b9d89390e60931546b5]}} (for RF-11736, 4.3.7) _have_ been applied to the 4.5.x branch
It seems that resolution of this issue will involve backporting more than just the 4.3.7 fixes. The challenge will be in doing so in a systematic way.
> Forward port the 4.3.7 fixes into the 4.5.x branch
> --------------------------------------------------
>
> Key: RF-13652
> URL: https://issues.jboss.org/browse/RF-13652
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: 4.5.0.Alpha3
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13648) Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
by Tony Cramer (JIRA)
[ https://issues.jboss.org/browse/RF-13648?page=com.atlassian.jira.plugin.s... ]
Tony Cramer commented on RF-13648:
----------------------------------
No chance.
> Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
> --------------------------------------------------------------------------
>
> Key: RF-13648
> URL: https://issues.jboss.org/browse/RF-13648
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.7
> Environment: Tomcat 8.0.8, OpenJDK 7, OpenSuse 13.1 x64
> Reporter: Tony Cramer
> Assignee: Juraj Húska
>
> {{javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL}} is ignored during Graph validating.
> Some debugging info:
> Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
> Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
> This causes validation to not pass.
> Something has changed in _jasper-el_ in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace _jasper-el.jar_ from Tomcat 8.0.5, everything works.
> Tomcat bug or RF bug?
> Edit:
> It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by santhosh siravuri (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
santhosh siravuri commented on RF-13647:
----------------------------------------
Thank you. Appreciate the quick response.
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Fix For: 4.3.8
>
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13647:
------------------------------------
Interesting. Thanks for digging in [~santoshvarma]. This issue is likely caused by RF-13018 (backported to RF 4.3.6 in RF-13559).
[~michpetrov] can you investigate? Re-open RF-13018 is required (but please do not re-open RF-13559).
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Fix For: 4.3.8
>
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13647:
-------------------------------
Fix Version/s: 4.3.8
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Fix For: 4.3.8
>
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13647:
------------------------------------
[~jstefek]: QE confirmation would still be appreciated.
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Fix For: 4.3.8
>
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by santhosh siravuri (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
santhosh siravuri commented on RF-13647:
----------------------------------------
Looking at the Release notes of 4.3.6, I wonder if it is because of the change done to RF-13018/RF-13559
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Fix For: 4.3.8
>
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13647) File Download throws exception
by santhosh siravuri (JIRA)
[ https://issues.jboss.org/browse/RF-13647?page=com.atlassian.jira.plugin.s... ]
santhosh siravuri commented on RF-13647:
----------------------------------------
Ok, After testing it some more, I could reproduce the issue. It is being caused by a4j:commandButton with type="button" anywhere in the page.
In the attached project edit index.xhtml and add a line and it throws the above mentioned exception.
{code}
h:commandLink: <h:commandLink action="#{campaignBean.campaignDownload()}" value="File to download"/>
<a4j:commandButton execute="@this" value="hello" type="button"/>
{code}
Basically if you have a commandButton with type anything other than submit, it fails.
It happens only with RF 4.3.6 and 4.3.7. on 4.3.5 it works fine.
> File Download throws exception
> ------------------------------
>
> Key: RF-13647
> URL: https://issues.jboss.org/browse/RF-13647
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input
> Affects Versions: 4.3.6
> Environment: Richfaces 4.3.6 Final.
> Mojarra - 2.1.28
> Weblogic 12.1.2
> Windows 7
> Reporter: santhosh siravuri
> Assignee: Jiří Štefek
> Priority: Critical
> Labels: waiting_on_user
> Attachments: RF-13647.zip
>
>
> File download action throws below exception.
> {code}
> ]] Root cause of ServletException.
> java.lang.NullPointerException
> at org.richfaces.renderkit.AjaxCommandRendererBase.isSubmitted(AjaxCommandRendererBase.java:83)
> at org.richfaces.renderkit.AjaxCommandRendererBase.doDecode(AjaxCommandRendererBase.java:59)
> at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80)
> at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789)
> at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1183)
> Truncated. see log file for complete stacktrace
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13648) Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13648?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13648:
------------------------------------
thanks for digging in [~tony.cramer]. Any chance you want to formulate a Pull Request for RichFaces addressing the required behaviour change?
> Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
> --------------------------------------------------------------------------
>
> Key: RF-13648
> URL: https://issues.jboss.org/browse/RF-13648
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.7
> Environment: Tomcat 8.0.8, OpenJDK 7, OpenSuse 13.1 x64
> Reporter: Tony Cramer
> Assignee: Juraj Húska
>
> {{javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL}} is ignored during Graph validating.
> Some debugging info:
> Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
> Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
> This causes validation to not pass.
> Something has changed in _jasper-el_ in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace _jasper-el.jar_ from Tomcat 8.0.5, everything works.
> Tomcat bug or RF bug?
> Edit:
> It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13648) Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13648?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-13648 at 5/29/14 12:05 PM:
--------------------------------------------------------------
Thanks for digging in [~tony.cramer]. Any chance you want to formulate a Pull Request for RichFaces addressing the required behaviour change?
was (Author: bleathem):
thanks for digging in [~tony.cramer]. Any chance you want to formulate a Pull Request for RichFaces addressing the required behaviour change?
> Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
> --------------------------------------------------------------------------
>
> Key: RF-13648
> URL: https://issues.jboss.org/browse/RF-13648
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.7
> Environment: Tomcat 8.0.8, OpenJDK 7, OpenSuse 13.1 x64
> Reporter: Tony Cramer
> Assignee: Juraj Húska
>
> {{javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL}} is ignored during Graph validating.
> Some debugging info:
> Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
> Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
> This causes validation to not pass.
> Something has changed in _jasper-el_ in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace _jasper-el.jar_ from Tomcat 8.0.5, everything works.
> Tomcat bug or RF bug?
> Edit:
> It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months