[JBoss JIRA] (RF-13648) Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13648?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13648:
-------------------------------
Description:
{{javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL}} is ignored during Graph validating.
Some debugging info:
Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
This causes validation to not pass.
Something has changed in _jasper-el_ in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace _jasper-el.jar_ from Tomcat 8.0.5, everything works.
Tomcat bug or RF bug?
Edit:
It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
was:
javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL is ignored during Graph validating.
Some debugging info:
Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
This causes validation to not pass.
Something has changed in jasper-el in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace jasper-el.jar from Tomcat 8.0.5, everything works.
Tomcat bug or RF bug?
Edit:
It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
> Graph Validator + Tomcat 8.0.8: interpret empty strings as null is ignored
> --------------------------------------------------------------------------
>
> Key: RF-13648
> URL: https://issues.jboss.org/browse/RF-13648
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.7
> Environment: Tomcat 8.0.8, OpenJDK 7, OpenSuse 13.1 x64
> Reporter: Tony Cramer
> Assignee: Juraj Húska
>
> {{javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL}} is ignored during Graph validating.
> Some debugging info:
> Object being validated ({{value}} argument) in method {{org.richfaces.validator.BeanValidatorServiceImpl.validateObject}} contains empty strings ("").
> Expected behavior: There should be nulls in properties, because interpreting empty strings as null is enabled.
> This causes validation to not pass.
> Something has changed in _jasper-el_ in Tomcat 8.0.8 which I updated recently from 8.0.5. If I replace _jasper-el.jar_ from Tomcat 8.0.5, everything works.
> Tomcat bug or RF bug?
> Edit:
> It's definitely JSF/RF's issue. Tomcat EL has changed to meet EL spec.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56522
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13645) contextMenu for extendedDataTable breaks after ajax render of contextMenu
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13645?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13645:
-------------------------------
Fix Version/s: 4.3.8
> contextMenu for extendedDataTable breaks after ajax render of contextMenu
> -------------------------------------------------------------------------
>
> Key: RF-13645
> URL: https://issues.jboss.org/browse/RF-13645
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.5, 4.3.6
> Environment: WIN7 / JBOSS AS 7.1.1
> Reporter: Steffen Michel
> Labels: regression
> Fix For: 4.3.8
>
>
> Anything that causes an ajax re-render of a contextMenu which is attached to an extendedDataTable causes the contextMenu to subsequently be broken, triggering a JavaScript error instead of displaying the menu. The error seems to be this:
> {quote}
> Cannot call method 'show' of null in menu-base.js (at line 108 there is a call to this.popup, but popup is null)
> {quote}
> The reason I need to ajax re-render the context menu is because in my situtation it's held within a tab panel, and if it doesn't get re-rendered then it stops working after switching tabs using ajax mode (though it also breaks if the contextMenu is held outside of the tab panel, so that isn't a potential solution).
>
> I created a stripped down example of my specific situation, with two extended data tables, each held in a different tab within a tab panel, and one context menu for each table. Changing tabs will cause the context menu to break without it explicitly being called in a render list. The same kind of break occurs if the contextMenu is called as part of any ajax render list:
> {code}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" xmlns:rich="http://richfaces.org/rich">
> <h:head></h:head>
> <h:body>
> <h:form id="testForm">
> <rich:tabPanel>
> <rich:tab id="tab1" header="Tab 1">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar" id="table1">
> <rich:column id="col1"> <h:outputText value="#{beanVar}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu1" target="table1">
> <rich:menuItem render="table1,contextMenu1" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 1 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> <rich:tab id="tab2" header="Tab 2">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar2" id="table2">
> <rich:column id="col2">
> <h:outputText value="#{beanVar2}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu2" target="table2">
> <rich:menuItem render="table2,contextMenu2" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 2 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> </rich:tabPanel>
> </h:form>
> </h:body>
> </html>
> {code}
> And a simple test bean:
> {code}
> import org.apache.myfaces.extensions.cdi.core.api.scope.conversation.ViewAccessScoped;
> import javax.inject.Named;
> import java.io.Serializable;
> import java.util.ArrayList;import java.util.List;
> @Named
> @ViewAccessScoped
> public class TestBean implements Serializable {
> List<String> items = new ArrayList<>();
> public TestBean() {
> items.add("one");
> items.add("two");
> items.add("three");
> }
> public void addItem(){
> items.add("another");
> }
> public List<String> getItems() {
> return items;
> }
> }
> {code}
> The above test situation works fine in richfaces 4.3.1, 4.3.2, 4.3.3 and 4.3.4, but breaks when upgraded to 4.3.5.Final.
>
>
> There was a different bug fixed in 4.3.5 which seems highly related to this, but opposite, making me wonder if whatever was done there caused this bug instead (but it's just a guess): RF-11973
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13645) contextMenu for extendedDataTable breaks after ajax render of contextMenu
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13645?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13645:
-------------------------------
Priority: Major (was: Blocker)
> contextMenu for extendedDataTable breaks after ajax render of contextMenu
> -------------------------------------------------------------------------
>
> Key: RF-13645
> URL: https://issues.jboss.org/browse/RF-13645
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.5, 4.3.6
> Environment: WIN7 / JBOSS AS 7.1.1
> Reporter: Steffen Michel
> Labels: regression
>
> Anything that causes an ajax re-render of a contextMenu which is attached to an extendedDataTable causes the contextMenu to subsequently be broken, triggering a JavaScript error instead of displaying the menu. The error seems to be this:
> {quote}
> Cannot call method 'show' of null in menu-base.js (at line 108 there is a call to this.popup, but popup is null)
> {quote}
> The reason I need to ajax re-render the context menu is because in my situtation it's held within a tab panel, and if it doesn't get re-rendered then it stops working after switching tabs using ajax mode (though it also breaks if the contextMenu is held outside of the tab panel, so that isn't a potential solution).
>
> I created a stripped down example of my specific situation, with two extended data tables, each held in a different tab within a tab panel, and one context menu for each table. Changing tabs will cause the context menu to break without it explicitly being called in a render list. The same kind of break occurs if the contextMenu is called as part of any ajax render list:
> {code}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" xmlns:rich="http://richfaces.org/rich">
> <h:head></h:head>
> <h:body>
> <h:form id="testForm">
> <rich:tabPanel>
> <rich:tab id="tab1" header="Tab 1">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar" id="table1">
> <rich:column id="col1"> <h:outputText value="#{beanVar}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu1" target="table1">
> <rich:menuItem render="table1,contextMenu1" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 1 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> <rich:tab id="tab2" header="Tab 2">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar2" id="table2">
> <rich:column id="col2">
> <h:outputText value="#{beanVar2}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu2" target="table2">
> <rich:menuItem render="table2,contextMenu2" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 2 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> </rich:tabPanel>
> </h:form>
> </h:body>
> </html>
> {code}
> And a simple test bean:
> {code}
> import org.apache.myfaces.extensions.cdi.core.api.scope.conversation.ViewAccessScoped;
> import javax.inject.Named;
> import java.io.Serializable;
> import java.util.ArrayList;import java.util.List;
> @Named
> @ViewAccessScoped
> public class TestBean implements Serializable {
> List<String> items = new ArrayList<>();
> public TestBean() {
> items.add("one");
> items.add("two");
> items.add("three");
> }
> public void addItem(){
> items.add("another");
> }
> public List<String> getItems() {
> return items;
> }
> }
> {code}
> The above test situation works fine in richfaces 4.3.1, 4.3.2, 4.3.3 and 4.3.4, but breaks when upgraded to 4.3.5.Final.
>
>
> There was a different bug fixed in 4.3.5 which seems highly related to this, but opposite, making me wonder if whatever was done there caused this bug instead (but it's just a guess): RF-11973
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-12132) Richfaces queue not cleared after js error in oncomplete attribute
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-12132?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-12132:
-------------------------------
Fix Version/s: 4.5.0.Alpha3
5.0.0.Alpha4
> Richfaces queue not cleared after js error in oncomplete attribute
> ------------------------------------------------------------------
>
> Key: RF-12132
> URL: https://issues.jboss.org/browse/RF-12132
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.2.0.Final, 4.3.7
> Environment: Myfaces 2.1.6
> Tomcat 6.0.35
> Reporter: Michael Heinen
> Assignee: Michal Petrov
> Labels: gss
> Fix For: 4.3.8, 4.5.0.Alpha3, 5.0.0.Alpha4
>
>
> Richfaces queue not cleared after js-error in oncomplete attribute
> Submit a <a4j:commandButton> with oncomplete="myNotExistingFuncrtion();"
> The ajax response arrives but the queue is not cleaned up after this due to the javascript error
> Starting from now no further ajax requests are possible because richfaces waits for previous submit results.
> Sample from the richfaces log:
> {code}
> debug[17:10:10.587]: New request added to queue. Queue requestGroupingId changed to j_id_5:j_id_b
> debug[17:10:10.615]: Queue will wait 0ms before submit
> debug[17:10:10.644]: richfaces.queue: will submit request NOW
> info [17:10:10.671]: Received 'begin' event from <input id=j_id_5:j_id_b ...>
> info [17:10:10.707]: Received 'beforedomupdate' event from <input id=j_id_5:j_id_b ...>
> debug[17:10:10.729]: Server returned responseText: <?xml version="1.0" encoding="utf-8"?><partial-response><changes><update id="j_id_5:details"><![CDATA[<span id="j_id_5:details"> Content List: []</span>]]></update><update id="javax.faces.ViewState"><![CDATA[Ks5ELN5RlWC9cOr14o5TwKjJIsvsN15m6RRwvmJhzzDPVRu0CANZgn6X/WbW2yDmQr2WO23dULmn wieWEZBuLjpr9cB6Sh1pkPwozKCTGwOuq4ArOM3fSIO8zbDCP7orMXRzfA== ]]></update><extension id="org.richfaces.extension"><complete>myNotExistingFuncrtion();;</complete></extension></changes></partial-response>
> info [17:10:10.758]: Listing content of response changes element:
> Element update for id=j_id_5:details
> <update id="j_id_5:details"><![CDATA[<span id="j_id_5:details"> Content List: []</span>]]></update>
> Element update for id=javax.faces.ViewState
> <update id="javax.faces.ViewState"><![CDATA[Ks5ELN5RlWC9cOr14o5TwKjJIsvsN15m6RRwvmJhzzDPVRu0CANZgn6X/WbW2yDmQr2WO23dULmn wieWEZBuLjpr9cB6Sh1pkPwozKCTGwOuq4ArOM3fSIO8zbDCP7orMXRzfA== ]]></update>
> Element extension for id=org.richfaces.extension
> <extension id="org.richfaces.extension"><complete>myNotExistingFuncrtion();;</complete></extension>
> debug[17:10:19.143]: New request added to queue. Queue requestGroupingId changed to j_id_5:j_id_a
> debug[17:10:19.171]: Queue will wait 0ms before submit
> debug[17:10:19.201]: richfaces.queue: Waiting for previous submit results
> {code}
> A request without javascript error ends with:
> {code}
> debug[17:20:22.033]: richfaces.queue: ajax submit successfull
> debug[17:20:22.075]: richfaces.queue: Nothing to submit
> info [17:20:22.117]: Received 'success' event from <input id=j_id_5:j_id_b ...>
> info [17:20:22.155]: Received 'complete' event from <input id=j_id_5:j_id_b ...>
> {code}
> I expect that the queue is cleaned up independent of javascript errors during oncomplete.
> Otherwise applications are not useable anymore.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13646) Fix resource optimization
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13646?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-13646:
-------------------------------
Description:
# There are some resource files that are not being generated (e.g. gradientA.png). It's either a generation or optimization issue.
# -The optimization settings need to be updated, core files are currently not being packed (legacy of RF 4.5/RF 5 source collision avoidance)-
was:
# There are some resource files that are not being generated (e.g. gradientA.png). It's either a generation or optimization issue.
# The optimization settings need to be updated, core files are currently not being packed (legacy of RF 4.5/RF 5 source collision avoidance)
> Fix resource optimization
> -------------------------
>
> Key: RF-13646
> URL: https://issues.jboss.org/browse/RF-13646
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.5.0.Alpha3
> Reporter: Michal Petrov
> Assignee: Michal Petrov
> Fix For: 4.5.0.Alpha3
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> # There are some resource files that are not being generated (e.g. gradientA.png). It's either a generation or optimization issue.
> # -The optimization settings need to be updated, core files are currently not being packed (legacy of RF 4.5/RF 5 source collision avoidance)-
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13018) a4j:commandButton wrong actions performed
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13018?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-13018:
-------------------------------
Fix Version/s: 4.5.0.Alpha3
> a4j:commandButton wrong actions performed
> -----------------------------------------
>
> Key: RF-13018
> URL: https://issues.jboss.org/browse/RF-13018
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.2.3.Final, 4.3.2
> Environment: Server: Fedora 17, Jboss AS 7.1.1.Final, Jboss EAP 6.1.0.Beta, Java 1.7.0_15
> Browsers: Chrome 26 and Chrome 27 on (Linux & Windows 7), Firefox 20.0 (Linux & Windows 7), IE 9
> Reporter: Rob Hare
> Assignee: Michal Petrov
> Labels: 45x
> Fix For: 4.5.0.Alpha3, 5.0.0.Alpha4
>
> Attachments: RF-13018.zip
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> When an a4j commponent (a4j:commandButton, a4j:jsFunction) is activated, actions of other a4j:commandButtons on the page with type=button will be fired.
> For example, pressing either button in the following code will cause both richBean.function1() and richBean.function2() actions.
> {noformat}
> <h:form id="testForm">
> <a4j:commandButton id="button1" type="button" value="Button 1"
> action="#{richBean.function1}" />
> <a4j:commandButton id="button2" type="button" value="Button 2"
> action="#{richBean.function2}" />
> </h:form>
> {noformat}
> Note, if one of the a4j:commandButton is marked immediate, then only one action (possibly the wrong action) will be performed and block others. For instance if an a4j:jsFunction action was being triggered, the a4j:commandButton action may occur making appear that the a4j:jsFunction failed.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13645) contextMenu for extendedDataTable breaks after ajax render of contextMenu
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-13645?page=com.atlassian.jira.plugin.s... ]
Juraj Húska commented on RF-13645:
----------------------------------
Labeling as regression.
Note that I have reproduced it with Mojarra (the original issues seems to use MyFaces).
> contextMenu for extendedDataTable breaks after ajax render of contextMenu
> -------------------------------------------------------------------------
>
> Key: RF-13645
> URL: https://issues.jboss.org/browse/RF-13645
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.5, 4.3.6
> Environment: WIN7 / JBOSS AS 7.1.1
> Reporter: Steffen Michel
> Priority: Blocker
> Labels: regression
>
> Anything that causes an ajax re-render of a contextMenu which is attached to an extendedDataTable causes the contextMenu to subsequently be broken, triggering a JavaScript error instead of displaying the menu. The error seems to be this:
> {quote}
> Cannot call method 'show' of null in menu-base.js (at line 108 there is a call to this.popup, but popup is null)
> {quote}
> The reason I need to ajax re-render the context menu is because in my situtation it's held within a tab panel, and if it doesn't get re-rendered then it stops working after switching tabs using ajax mode (though it also breaks if the contextMenu is held outside of the tab panel, so that isn't a potential solution).
>
> I created a stripped down example of my specific situation, with two extended data tables, each held in a different tab within a tab panel, and one context menu for each table. Changing tabs will cause the context menu to break without it explicitly being called in a render list. The same kind of break occurs if the contextMenu is called as part of any ajax render list:
> {code}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" xmlns:rich="http://richfaces.org/rich">
> <h:head></h:head>
> <h:body>
> <h:form id="testForm">
> <rich:tabPanel>
> <rich:tab id="tab1" header="Tab 1">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar" id="table1">
> <rich:column id="col1"> <h:outputText value="#{beanVar}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu1" target="table1">
> <rich:menuItem render="table1,contextMenu1" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 1 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> <rich:tab id="tab2" header="Tab 2">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar2" id="table2">
> <rich:column id="col2">
> <h:outputText value="#{beanVar2}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu2" target="table2">
> <rich:menuItem render="table2,contextMenu2" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 2 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> </rich:tabPanel>
> </h:form>
> </h:body>
> </html>
> {code}
> And a simple test bean:
> {code}
> import org.apache.myfaces.extensions.cdi.core.api.scope.conversation.ViewAccessScoped;
> import javax.inject.Named;
> import java.io.Serializable;
> import java.util.ArrayList;import java.util.List;
> @Named
> @ViewAccessScoped
> public class TestBean implements Serializable {
> List<String> items = new ArrayList<>();
> public TestBean() {
> items.add("one");
> items.add("two");
> items.add("three");
> }
> public void addItem(){
> items.add("another");
> }
> public List<String> getItems() {
> return items;
> }
> }
> {code}
> The above test situation works fine in richfaces 4.3.1, 4.3.2, 4.3.3 and 4.3.4, but breaks when upgraded to 4.3.5.Final.
>
>
> There was a different bug fixed in 4.3.5 which seems highly related to this, but opposite, making me wonder if whatever was done there caused this bug instead (but it's just a guess): RF-11973
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months
[JBoss JIRA] (RF-13645) contextMenu for extendedDataTable breaks after ajax render of contextMenu
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-13645?page=com.atlassian.jira.plugin.s... ]
Juraj Húska updated RF-13645:
-----------------------------
Labels: regression (was: )
> contextMenu for extendedDataTable breaks after ajax render of contextMenu
> -------------------------------------------------------------------------
>
> Key: RF-13645
> URL: https://issues.jboss.org/browse/RF-13645
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.5, 4.3.6
> Environment: WIN7 / JBOSS AS 7.1.1
> Reporter: Steffen Michel
> Priority: Blocker
> Labels: regression
>
> Anything that causes an ajax re-render of a contextMenu which is attached to an extendedDataTable causes the contextMenu to subsequently be broken, triggering a JavaScript error instead of displaying the menu. The error seems to be this:
> {quote}
> Cannot call method 'show' of null in menu-base.js (at line 108 there is a call to this.popup, but popup is null)
> {quote}
> The reason I need to ajax re-render the context menu is because in my situtation it's held within a tab panel, and if it doesn't get re-rendered then it stops working after switching tabs using ajax mode (though it also breaks if the contextMenu is held outside of the tab panel, so that isn't a potential solution).
>
> I created a stripped down example of my specific situation, with two extended data tables, each held in a different tab within a tab panel, and one context menu for each table. Changing tabs will cause the context menu to break without it explicitly being called in a render list. The same kind of break occurs if the contextMenu is called as part of any ajax render list:
> {code}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" xmlns:rich="http://richfaces.org/rich">
> <h:head></h:head>
> <h:body>
> <h:form id="testForm">
> <rich:tabPanel>
> <rich:tab id="tab1" header="Tab 1">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar" id="table1">
> <rich:column id="col1"> <h:outputText value="#{beanVar}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu1" target="table1">
> <rich:menuItem render="table1,contextMenu1" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 1 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> <rich:tab id="tab2" header="Tab 2">
> <rich:extendedDataTable value="#{testBean.items}" var="beanVar2" id="table2">
> <rich:column id="col2">
> <h:outputText value="#{beanVar2}"/>
> </rich:column>
> </rich:extendedDataTable>
> <rich:contextMenu id="contextMenu2" target="table2">
> <rich:menuItem render="table2,contextMenu2" mode="ajax"
> actionListener="#{testBean.addItem}">Context Menu 2 Item</rich:menuItem>
> </rich:contextMenu>
> </rich:tab>
> </rich:tabPanel>
> </h:form>
> </h:body>
> </html>
> {code}
> And a simple test bean:
> {code}
> import org.apache.myfaces.extensions.cdi.core.api.scope.conversation.ViewAccessScoped;
> import javax.inject.Named;
> import java.io.Serializable;
> import java.util.ArrayList;import java.util.List;
> @Named
> @ViewAccessScoped
> public class TestBean implements Serializable {
> List<String> items = new ArrayList<>();
> public TestBean() {
> items.add("one");
> items.add("two");
> items.add("three");
> }
> public void addItem(){
> items.add("another");
> }
> public List<String> getItems() {
> return items;
> }
> }
> {code}
> The above test situation works fine in richfaces 4.3.1, 4.3.2, 4.3.3 and 4.3.4, but breaks when upgraded to 4.3.5.Final.
>
>
> There was a different bug fixed in 4.3.5 which seems highly related to this, but opposite, making me wonder if whatever was done there caused this bug instead (but it's just a guess): RF-11973
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
10 years, 6 months