[JBoss JIRA] (RF-12303) Customer topiclistener not working on richfaces push component of verion 4.2.2-Final and older
by Daniel Yang (JIRA)
Daniel Yang created RF-12303:
--------------------------------
Summary: Customer topiclistener not working on richfaces push component of verion 4.2.2-Final and older
Key: RF-12303
URL: https://issues.jboss.org/browse/RF-12303
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-a4j-core, component-push/poll
Affects Versions: 4.2.2.Final
Environment: No deponds on what environment.
Reporter: Daniel Yang
See description here:
https://community.jboss.org/message/736651#736651
Copy it again:
I use it like following lines:
TopicsContext topicsContext = TopicsContext.lookup();
Topic topic = topicsContext.getOrCreateTopic(new TopicKey("test"));
topic.setMessageDataSerializer(DefaultMessageDataSerializer.instance());
topic.addTopicListener(new SessionTopicListener2() {
@Override
public void processPreSubscriptionEvent(SessionPreSubscriptionEvent event) throws SubscriptionFailureException {
//TODO
}
@Override
public void processSubscriptionEvent(SessionSubscriptionEvent event) {
//TODO
}
@Override
public void processUnsubscriptionEvent(SessionUnsubscriptionEvent event) {
//TODO
}
});
I noted that listeners in TopicImpl are all the SessionTopicListener2 type, because add method is:
public void addTopicListener(TopicListener topicListener) {
TopicListener listener = topicListener;
if (listener instanceof SessionTopicListener) {
listener = new SessionTopicListenerWrapper((SessionTopicListener) listener);
}
listeners.add(listener);
}
All SessionTopicListeners are wrapped to type SessionTopicListener2, and when event publish in TopicImpl, it check it if it is appropriate listener like this:
public void publishEvent(TopicEvent event) {
for (TopicListener listener : listeners) {
if (event.isAppropriateListener(listener)) {
try {
event.invokeListener(listener);
} catch (Exception e) {
logError(e);
}
}
}
}
But event type SessionPreSubscriptionEvent, SessionSubscriptionEvent or SessionUnsubscriptionEvent does not override the mothed isAppropriateListener, so when checking, it use the method of its parent SessionTopicEvent, its parent method is like this:
@Override
public boolean isAppropriateListener(EventListener listener) {
return (listener instanceof SessionTopicListener);
}
Then it always returns false for above three SessionTopicEvent , and the custom listeners will never be called. I think it may be changed from " return (listener instanceof SessionTopicListener);" to return (listener instanceof SessionTopicListener2); or override it in seperator implement of type SessionTopicEvent .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (RF-12493) Add option to not filter rich:select onlistshow
by Bernard Labno (JIRA)
Bernard Labno created RF-12493:
----------------------------------
Summary: Add option to not filter rich:select onlistshow
Key: RF-12493
URL: https://issues.jboss.org/browse/RF-12493
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: component-input
Affects Versions: 4.2.2.Final
Reporter: Bernard Labno
Priority: Minor
Currently if we want to show all options in rich:select list despite there is already some value typed in the input we have to add this:
onlistshow="this.rf.component.input.val('');this.rf.component.__updateItems()"
But this is usage of private method that may be subject on unexpected changes in future releases of RF.
Add attribute to rich:select that would not filter list onlistshow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (RF-12189) Risk of duplicate ID on Tab header with facet ?
by Jean ANDRE (JIRA)
Jean ANDRE created RF-12189:
-------------------------------
Summary: Risk of duplicate ID on Tab header with facet ?
Key: RF-12189
URL: https://issues.jboss.org/browse/RF-12189
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.2.0.Final
Environment: GlasshFish 3.1.2 - JSF Mojorra 2.1.7 - Spring 3.0.6 Final - CDI Annotation- Firefox 10 - Windows 7 (6.1 sp1)
Reporter: Jean ANDRE
Attachments: Duplicate_ID_html_output.txt
Please, evaluate the risk of duplicate ID. We have check the HTML ouptup with w3c validator and we got following error message:
Line 81, Column 19: ID "desktopForm:TAB_ITEM-02-2-tabTitle" already defined
<span id="desktopForm:TAB_ITEM-02-2-tabTitle" title="Liste # (2)">Liste
Line 79, Column 19: ID "desktopForm:TAB_ITEM-02-2-tabTitle" first defined here
<span id="desktopForm:TAB_ITEM-02-2-tabTitle" title="Liste # (2)">Liste...
Line 82, Column 18: ID "desktopForm:TAB_ITEM-02-2-closeTabButton" already defined
<img id="desktopForm:TAB_ITEM-02-2-closeTabButton" src="/NestedWeb/imag...
Line 80, Column 18: ID "desktopForm:TAB_ITEM-02-2-closeTabButton" first defined here
<img id="desktopForm:TAB_ITEM-02-2-closeTabButton" src="/NestedWeb/imag...
For the following dynamic tab fragment.
{code}
<rich:tab id="#{tab.id}" onenter="enterTab('#{tab.id}');" headerClass="tab-header">
<!-- -->
<!-- DYNAMIC TABS -->
<!-- -->
<f:facet name="header">
 <h:outputText id="#{tab.id}-tabTitle" value="#{desktopController.getTabHeader(tab.id)}" title="#{desktopController.getTabHeader(tab.id)}" />
 <h:graphicImage id="#{tab.id}-closeTabButton" value="/images/closeButton.png"
styleClass="closeButton"
onclick="closeTab('#{tab.id}');stopPropagation(event);"
alt="" />
</f:facet>
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (RF-12212) Accordion - Javascript error - "this.getTogglePanel() is undefined" with ui:repeat
by Jean ANDRE (JIRA)
Jean ANDRE created RF-12212:
-------------------------------
Summary: Accordion - Javascript error - "this.getTogglePanel() is undefined" with ui:repeat
Key: RF-12212
URL: https://issues.jboss.org/browse/RF-12212
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Environment: WAS/RAD - Firefox 12 - JSF 2.1.7 - commons-lang-2.4 - commons-logging-1.1.1 - cssparser-0.9.6 - guava-11.0.1 - hibernate-validator-4.2.0.Final - junit-4.10 - log4j-1.2.16 - org.springframework 3.0.6 - sac-1.3
Reporter: Jean ANDRE
Fix For: 4.2.1.Final, 4.2.0.Final
When we use accordion inside an ui:repeat we got a javascript exception - The accordion does not work at all.
Error is : togglePanelItem.js.jsf?ln=org.richfaces (ligne 43)
{code}
this.getTogglePanel() is undefined
[Stopper sur une erreur]
>>>>>>> this.getTogglePanel().getItems()[this.index] = this;
this.disabled = this.options.disabled || false;
this.index = options["index"];
this.getTogglePanel().getItems()[this.index] = this;
this.__addUserEventHandler("enter");
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (RF-12160) rich:validator does not validate on the client side the @Pattern constraint
by Juraj Huska (JIRA)
Juraj Huska created RF-12160:
--------------------------------
Summary: rich:validator does not validate on the client side the @Pattern constraint
Key: RF-12160
URL: https://issues.jboss.org/browse/RF-12160
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-validators
Affects Versions: 4.2.1.Final
Environment: application: generated project from richfaces-kitchensink-archetype 4.2.1-SNAPSHOT
browser: Chrome, Firefox
Reporter: Juraj Huska
When trying to validate input which has annotation based constraint @Pattern, validation for this constraint is triggered only after the submitting of the form. The other constraints (@NotNull, @Size) are triggered as expected, after the BLUR event fired on that input.
The issue is noticeable on the project generated by the kitchensink archetype with RichFaces 4.2.1-SNAPSHOT libraries.
The facelet for the input validation with pattern annotation-based constraints looks like:
{code:xml}
<h:panelGrid columns="3" columnClasses="titleCell">
<h:outputLabel for="name" value="Name:"/>
<h:inputText id="name" value="#{cc.attrs.member.name}">
<rich:validator/>
</h:inputText>
<rich:message for="name" errorClass="invalid"/>
</h:panelGrid>
{code}
The model entity field which is validated in the above mentioned input:
{code}
@NotNull
@Size(min = 1, max = 25)
@Pattern(regexp = "[A-Za-z ]*", message = "must contain only letters and spaces")
private String name;
{code}
Note that I have tried to reproduce this issue on metamer and I was not successful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years