November 2012 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-12281) rich:tree is iterated multiple times when item is selected

by Alex Vb (JIRA)

Alex Vb created RF-12281: ---------------------------- Summary: rich:tree is iterated multiple times when item is selected Key: RF-12281 URL: https://issues.jboss.org/browse/RF-12281 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-tree Affects Versions: 4.2.2.Final Reporter: Alex Vb I have a decently sized tree and I'm using the selectionChangeListener in combination with toggleType="client" selectionType="ajax" render="node" to trigger a selection event on the server. The panelGroup "node" is re-rendered afterwards but it takes 1-2 seconds for each request. After enabling some debug logging I noticed that the entire tree is iterated 4 times for each request. Note a small test-tree exhibiting the same behavior: 2012-05-22 08:39:29.287 DEBUG CustomPhaseListener - Before phase: APPLY_REQUEST_VALUES 2 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChildrenKeysIterator(0) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(1) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChildrenKeysIterator(1) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.287 DEBUG Bean - selectionChanged() 2012-05-22 08:39:29.287 DEBUG CustomPhaseListener - After phase: APPLY_REQUEST_VALUES 2 2012-05-22 08:39:29.287 DEBUG CustomPhaseListener - Before phase: PROCESS_VALIDATIONS 3 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChildrenKeysIterator(0) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(1) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChildrenKeysIterator(1) 2012-05-22 08:39:29.287 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - After phase: PROCESS_VALIDATIONS 3 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - Before phase: UPDATE_MODEL_VALUES 4 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChildrenKeysIterator(0) 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChild(1) 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChildrenKeysIterator(1) 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - After phase: UPDATE_MODEL_VALUES 4 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - Before phase: INVOKE_APPLICATION 5 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - After phase: INVOKE_APPLICATION 5 2012-05-22 08:39:29.302 DEBUG CustomPhaseListener - Before phase: RENDER_RESPONSE 6 2012-05-22 08:39:29.302 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.318 DEBUG TreeNodeBase - getChildrenKeysIterator(0) 2012-05-22 08:39:29.318 DEBUG TreeNodeBase - getChild(1) 2012-05-22 08:39:29.318 DEBUG TreeNodeBase - getChildrenKeysIterator(1) 2012-05-22 08:39:29.318 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.318 DEBUG TreeNodeBase - getChild(2) 2012-05-22 08:39:29.318 DEBUG CustomPhaseListener - After phase: RENDER_RESPONSE 6 On the rather large tree each iteration takes 300-500 ms which explains the slow behavior. I have played around with every setting I could find, if selectionType is set to "client" the tree is iterated only once (during the render response phase) but the selection event does not seem to be triggered. If toggleType is set to ajax, only the "expanded" parts of the tree are iterated. I have no idea why the iteration is necessary for all these phases but I "fixed" it in my implementation by recompiling the org.richfaces.component.TreeRange class with an updated method: public boolean shouldIterateChildren() { if (tree.isLeaf()) return false; else { char separatorChar = UINamingContainer.getSeparatorChar(FacesContext.getCurrentInstance()); String clientId = tree.getClientId(); boolean render = false; for (String idToRender : FacesContext.getCurrentInstance().getPartialViewContext().getRenderIds()) { // render the tree if you explicitly mention either the client id (e.g. "menuForm:tree") or the parent component client id (e.g. "menuForm") // note that when clicking on an object in the tree, the following render target is requested: menuForm:tree@selection if (clientId.equals(idToRender) || clientId.matches(idToRender + separatorChar + ".*")) { render = true; break; } } // always render if it's not a postback return render || !FacesContext.getCurrentInstance().isPostback(); } } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
8
0 / 0

[JBoss JIRA] (RF-12560) showcase - drag and drop - demo with drag indicator throws JS errors when dragging an item

by Juraj Húska (JIRA)

Juraj Húska created RF-12560: -------------------------------- Summary: showcase - drag and drop - demo with drag indicator throws JS errors when dragging an item Key: RF-12560 URL: https://issues.jboss.org/browse/RF-12560 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-drag/drop, showcase Affects Versions: 4.3.0.M1 Environment: Firefox, Chrome JBoss AS 7.1.1.Final, Tomcat Reporter: Juraj Húska When attempting to drag an item with support of drag indicators, JS errors are thrown to the console. Please see the attachments for the errors. The errors are thrown after successfully dragging one item. Then dragging is not working at all. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
13
0 / 0

[JBoss JIRA] (RF-12438) Tree: Icon-Attribute does not show any effect

by Martin Maier (JIRA)

Martin Maier created RF-12438: --------------------------------- Summary: Tree: Icon-Attribute does not show any effect Key: RF-12438 URL: https://issues.jboss.org/browse/RF-12438 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-tree Affects Versions: 4.2.2.Final Environment: Java7, Tomcat7 Reporter: Martin Maier The 'icon' Attribute of rich:treeNode does have any effect. Whatever value you use, always the default icon is displayed. It even shows incorrectly in the Richfaces Showcase (http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=tree&sk...). In the showcase, companies and songs are supposed to have different icons (disc.gif and song.gif). They show as default folder/document icons. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
9
0 / 0

[JBoss JIRA] (RF-12445) Autocomplete: wrong output for suggestions with 2 or more words

by Pavol Pitonak (JIRA)

Pavol Pitonak created RF-12445: ---------------------------------- Summary: Autocomplete: wrong output for suggestions with 2 or more words Key: RF-12445 URL: https://issues.jboss.org/browse/RF-12445 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-input Affects Versions: 4.3.0.Milestone1 Environment: RichFaces 4.3.0.M1 all browsers Reporter: Pavol Pitonak # open autocomplete sample in Showcase http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=autocom... # type "no" to the third input on the page # select "North Carolina" either using keyboard or using mouse result: * input contains "North Carolina Carolina" * the behavior is probably caused by *selectFirst* attribute because the first two samples work -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

4
10
0 / 0

[JBoss JIRA] (RF-12574) rich:accordion height of first element is wrongly computed

by Jiří Štefek (JIRA)

Jiří Štefek created RF-12574: -------------------------------- Summary: rich:accordion height of first element is wrongly computed Key: RF-12574 URL: https://issues.jboss.org/browse/RF-12574 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-output Affects Versions: 4.3.0.M2 Environment: RichFaces 4.3.0.20121024-M2 Metamer 4.3.0.20121024-M2 JBoss AS 7.1.1.Final OpenJDK Runtime Environment 1.6.0_24-b24 @ Linux Firefox 16.0 @ Linux x86_64 / Chrome 21.0.1180.89 @ Linux x86_64 / IE9 Reporter: Jiří Štefek Priority: Minor When some other item than first of the rich:accordion is selected and then the first item is selected, the height of the content of the first item is wrongly computed and its height is as big as whole accordion height. In 4.2.3 CR1 it works correctly. Problem only occurs when @switchType is ajax. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
10
0 / 0

[JBoss JIRA] (RF-12570) Re-create the kitchensink archetype from the kitchensink quickstart

by Brian Leathem (JIRA)

Brian Leathem created RF-12570: ---------------------------------- Summary: Re-create the kitchensink archetype from the kitchensink quickstart Key: RF-12570 URL: https://issues.jboss.org/browse/RF-12570 Project: RichFaces Issue Type: Task Security Level: Public (Everyone can see) Reporter: Brian Leathem Priority: Blocker Fix For: 4.3.0.M3 Making this a blocker, as the release should not proceed without out this step being performed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

1
4
0 / 0

[JBoss JIRA] (RF-12398) UIDataAdaptor keepSaved method returns true when maximum severity is NOT greater than SEVERITY_ERROR

by Tomasz Kurpios (JIRA)

Tomasz Kurpios created RF-12398: ----------------------------------- Summary: UIDataAdaptor keepSaved method returns true when maximum severity is NOT greater than SEVERITY_ERROR Key: RF-12398 URL: https://issues.jboss.org/browse/RF-12398 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Affects Versions: 4.0.0.Final Reporter: Tomasz Kurpios According to the description in [RF-8586] UIDataAdaptor should reset child state when severity is at least ERROR. However it does the opposite - when it is at most ERROR. That's what is checked: {code} FacesMessage.SEVERITY_ERROR.compareTo(sev) >= 0 {code} And that's what should be checked: {code} {code} FacesMessage.SEVERITY_ERROR.compareTo(sev) <= 0 {code} {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
9
0 / 0

[JBoss JIRA] (RF-12516) Kitchensink Archetype: the "Documentation" link isn't up to date

by Jan Papousek (JIRA)

Jan Papousek created RF-12516: --------------------------------- Summary: Kitchensink Archetype: the "Documentation" link isn't up to date Key: RF-12516 URL: https://issues.jboss.org/browse/RF-12516 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: archetype Affects Versions: 4.2.3.CR1 Reporter: Jan Papousek After clicking on "Documentation" link on the right side the "Not Found" page is displayed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

2
6
0 / 0

[JBoss JIRA] Created: (RF-8586) UIDataAdaptor: keepSaved attribute

by Nick Belaevski (JIRA)

UIDataAdaptor: keepSaved attribute ---------------------------------- Key: RF-8586 URL: https://jira.jboss.org/jira/browse/RF-8586 Project: RichFaces Issue Type: Feature Request Security Level: Public (Everyone can see) Components: component Affects Versions: 4.0.0.ALPHA2 Reporter: Nick Belaevski Assignee: Nick Belaevski Fix For: 4.0.0.ALPHA2 Boolean attribute that defines whether this iteration component will reset saved children's state before rendering. By default state is reset if there are no faces messages with severity error or higher. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

2
3
0 / 0

[JBoss JIRA] (RF-12606) rich:calendar bad Html syntaxe a table is under span, wich is not allowed (cause ajax error?('error@malformedXML'))

by Adrien Adrien (JIRA)

Adrien Adrien created RF-12606: ---------------------------------- Summary: rich:calendar bad Html syntaxe a table is under span, wich is not allowed (cause ajax error?('error@malformedXML')) Key: RF-12606 URL: https://issues.jboss.org/browse/RF-12606 Project: RichFaces Issue Type: Feature Request Security Level: Public (Everyone can see) Components: component-input Affects Versions: 4.3.0.M2 Environment: http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=calenda... Reporter: Adrien Adrien Fix For: 4.3.0.M2 In html code rich:calendar has table under span. Seem to cause error (a4j:log) in my code during ajax refresh : -------------------------------------------------------------- error[20:47:12.191]: Received 'error@malformedXML' event from <input ... error[20:47:12.192]: [200] undefined: undefined Example ------------- http://showcase.richfaces.org/richfaces/component-sample.jsf?demo=calenda... W3c don't detect error , but it's visible with firebug when you inspect rich:calendar Use firefox plugin HTML Validor http://users.skynet.be/mgueury/mozilla/ ---------------------------------------------------------------------- validate page after javascript excecution line 101 column 986 - Erreur: document type does not allow element "TABLE" here; missing one of "APPLET", "OBJECT", "MAP", "IFRAME", "BUTTON" start-tag code: <span style="width:200px" id="j_idt1578:calendar"> <span style="white-space: nowrap;" id="j_idt1578:calendarPopup"><input type="text" style="vertical-align: middle; " readonly="readonly" name="j_idt1578:calendarInputDate" id="j_idt1578:calendarInputDate" class="rf-cal-inp "><img style="vertical-align: middle" src="/org.richfaces.resources/javax.faces.resource/org.richfaces.staticResource/4.2.3.Final/PackedCompressed/blueSky/org.richfaces.images/calendarIcon.png" id="j_idt1578:calendarPopupButton" class="rf-cal-btn " alt=""><input type="hidden" value="11/2012" style="display:none" name="j_idt1578:calendarInputCurrentDate" id="j_idt1578:calendarInputCurrentDate" autocomplete="off"></span> <table cellspacing="0" cellpadding="0" border="0" onclick="RichFaces.$('j_idt1578:calendar').skipEventOnCollapse=true;" style="display:none; position:absolute;z-index: 3" class="rf-cal-extr rf-cal-popup undefined" id="j_idt1578:calendarContent"><tbody><tr><td ...blablabla </table> </span> -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
7
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues November 2012