November 2013 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-13365) push: cannot be disabled with ajax request

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13365?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13365: ---------------------------- Labels: regression (was: ) > push: cannot be disabled with ajax request > ------------------------------------------ > > Key: RF-13365 > URL: https://issues.jboss.org/browse/RF-13365 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 5.0.0.Alpha2 > Environment: EAP 6.1, Glassfish 3.1.2.2 > FF 25, Chrome 31 > Reporter: Jiří Štefek > Assignee: Lukáš Fryč > Labels: regression > Fix For: 5.0.0.Alpha2 > > Original Estimate: 1 hour > Remaining Estimate: 1 hour > > Worked in 4.3.4.Final. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13375) Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13375?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč reassigned RF-13375: ------------------------------- Assignee: Brian Leathem (was: Lukáš Fryč) Wdyt [~bleathem] ? > Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom > ----------------------------------------------------------------------------------------------- > > Key: RF-13375 > URL: https://issues.jboss.org/browse/RF-13375 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Brian Leathem > Fix For: 5.0.0.Alpha2 > > > richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13375) Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13375?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-13375: --------------------------------- During debugging I haven't found our event handlers in [bridge-base|https://github.com/richfaces/richfaces/blob/0bf739c81460686c8...] aren't fired, even though the _destroy for Widget Factory are called. The reason is that richfaces.js calls {{$.cleanData}}: https://github.com/richfaces/richfaces/blob/master/framework/src/main/res... Then jquery.ui.widget.js fires {{remove}} event when cleanData is called: https://github.com/jquery/jquery-ui/blob/1.10.3/ui/jquery.ui.widget.js#L19 Then this event is observed and this.destroy() method is fired which calls _destroy() method in widget impls: https://github.com/jquery/jquery-ui/blob/1.10.3/ui/jquery.ui.widget.js#L241 ---- We could depend on this Widget Factory cleaning logic or, in order to make sure the method is called, we could introduce own one. > Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom > ----------------------------------------------------------------------------------------------- > > Key: RF-13375 > URL: https://issues.jboss.org/browse/RF-13375 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 5.0.0.Alpha2 > > > richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13371) Clarify and fix Push destroy logic

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13371?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-13371. ----------------------------- Resolution: Done > Clarify and fix Push destroy logic > ---------------------------------- > > Key: RF-13371 > URL: https://issues.jboss.org/browse/RF-13371 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > I need to commend on the approach I take for destroying Push component which follows approximately what Widget Factory does. > I have also found that the widget _destro method isn't called at all, because there is no such event as {{cleanDom}}. > richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13375) Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13375?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13375: ---------------------------- Sprint: 5.0.0.Alpha2 - Sprint 6 > Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom > ----------------------------------------------------------------------------------------------- > > Key: RF-13375 > URL: https://issues.jboss.org/browse/RF-13375 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 5.0.0.Alpha2 > > > richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13371) Clarify and fix Push destroy logic

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13371?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13371: ---------------------------- Summary: Clarify and fix Push destroy logic (was: Refactored Push destroy logic is too aggresive and causes ProgressBar to fail) Description: I need to commend on the approach I take for destroying Push component which follows approximately what Widget Factory does. I have also found that the widget _destro method isn't called at all, because there is no such event as {{cleanDom}}. richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. was: >From RF-13359: {quote} It took a while, but I isolated the single offending line: https://github.com/richfaces/richfaces/blob/master/framework/src/main/res... {code} $(document).on('cleanDom.RICH', function(event, ui) { if ($.contains(ui.target, widget.element)) { widget._destroy(); } }); {code} [~lfryc] It's not clear to me what you are trying to achieve here, but the end result seems to be that the destroy call is too aggressive. Can you re-visit this please? {panel:title=Note:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#FFFFCE} The isolation was difficult, as the file in question should have nothing to do with the progressBar component. Hence why the effect was observed only had an effect when included via resource packaging. {panel} {quote} > Clarify and fix Push destroy logic > ---------------------------------- > > Key: RF-13371 > URL: https://issues.jboss.org/browse/RF-13371 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > I need to commend on the approach I take for destroying Push component which follows approximately what Widget Factory does. > I have also found that the widget _destro method isn't called at all, because there is no such event as {{cleanDom}}. > richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13375) Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom

by Lukáš Fryč (JIRA)

Lukáš Fryč created RF-13375: ------------------------------- Summary: Bridge Base: components can't be destroyed because they listens for non-existing event cleanDom Key: RF-13375 URL: https://issues.jboss.org/browse/RF-13375 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component Affects Versions: 5.0.0.Alpha2 Reporter: Lukáš Fryč Assignee: Lukáš Fryč Fix For: 5.0.0.Alpha2 richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right event to listen for for component cleanup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-6678) RichFaces Select components: implement disabled state support for selectItem

by J W (JIRA)

[ https://issues.jboss.org/browse/RF-6678?page=com.atlassian.jira.plugin.sy... ] J W commented on RF-6678: ------------------------- Shouldnt this have be done in this issue already? https://issues.jboss.org/browse/RF-10131 > RichFaces Select components: implement disabled state support for selectItem > ---------------------------------------------------------------------------- > > Key: RF-6678 > URL: https://issues.jboss.org/browse/RF-6678 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) > Components: component-selects > Affects Versions: 4.0.0.Milestone5 > Reporter: Ilya Shaikovsky > Fix For: 5-Tracking > > > components: > inplaceSelect > select > In future we should support the same in: > listShuttle > orderingList > note: s:selectItems disabled attribute should also works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-10131) Improve SelectItem(s) handling compatibility with JSF 2.0

by J W (JIRA)

[ https://issues.jboss.org/browse/RF-10131?page=com.atlassian.jira.plugin.s... ] J W edited comment on RF-10131 at 11/22/13 4:49 AM: ---------------------------------------------------- Is this already finished? Whenever i try to add an Item with f:selectItem with itemDisabled="true", the item will be always treated like every other item. I am using RF 4.3.1 was (Author: jigg4): Is this already finished? Whenever i try to add an Item with f:selectItem with itemDisabled="true", the item will be always treated like every other item. > Improve SelectItem(s) handling compatibility with JSF 2.0 > --------------------------------------------------------- > > Key: RF-10131 > URL: https://issues.jboss.org/browse/RF-10131 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: compatibility > Environment: myfaces 2.0.3, richfaces 4.0 trunk rev. 20883 > Reporter: Martin Kočí > Assignee: Gleb Galkin > Fix For: 4.0.0.Milestone6 > > > 1) JSF 2.0 specifies new attributes itemLabel, itemDescription and itemDisabled for f:selectItem(s). Unfortunately those attributes are not part of public API but every renderkit must reimplement it again in own code base. RichFaces org.richfaces.component.util.SelectUtils.getSelectItems(FacesContext, UIComponent) currently support only old JSF 1.2 style (SelectItem instances are obtained from value="#{}"). > Implement support for f:selectItems value="#{}" var="variable" > itemLabel="#{...}" itemValue="#{...}"/> > 2) null or empty SelectItems handling: o.j.rf.SelectUtils throws an exception if no SelectItem(s) are available. If think this is too agressive and not very useful for user. I suggest to use myfaces-like solution: a warning in development stage like: > WARNING: ValueExpression #{de.bier.humpen} of UISelectItems with component-path {Component-Path : [Class: javax.faces.component.UIViewRoot,ViewId: /X500Form.xhtml][Class: javax.faces.component.html.HtmlBody, ... ][Class: javax.faces.component.UISelectItems,Id: selectItemsId} does not reference an Object of type SelectItem, array, Iterable or Map, but of type: null -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-10131) Improve SelectItem(s) handling compatibility with JSF 2.0

by J W (JIRA)

[ https://issues.jboss.org/browse/RF-10131?page=com.atlassian.jira.plugin.s... ] J W commented on RF-10131: -------------------------- Is this already finished? Whenever i try to add an Item with f:selectItem with itemDisabled="true", the item will be always treated like every other item. > Improve SelectItem(s) handling compatibility with JSF 2.0 > --------------------------------------------------------- > > Key: RF-10131 > URL: https://issues.jboss.org/browse/RF-10131 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: compatibility > Environment: myfaces 2.0.3, richfaces 4.0 trunk rev. 20883 > Reporter: Martin Kočí > Assignee: Gleb Galkin > Fix For: 4.0.0.Milestone6 > > > 1) JSF 2.0 specifies new attributes itemLabel, itemDescription and itemDisabled for f:selectItem(s). Unfortunately those attributes are not part of public API but every renderkit must reimplement it again in own code base. RichFaces org.richfaces.component.util.SelectUtils.getSelectItems(FacesContext, UIComponent) currently support only old JSF 1.2 style (SelectItem instances are obtained from value="#{}"). > Implement support for f:selectItems value="#{}" var="variable" > itemLabel="#{...}" itemValue="#{...}"/> > 2) null or empty SelectItems handling: o.j.rf.SelectUtils throws an exception if no SelectItem(s) are available. If think this is too agressive and not very useful for user. I suggest to use myfaces-like solution: a warning in development stage like: > WARNING: ValueExpression #{de.bier.humpen} of UISelectItems with component-path {Component-Path : [Class: javax.faces.component.UIViewRoot,ViewId: /X500Form.xhtml][Class: javax.faces.component.html.HtmlBody, ... ][Class: javax.faces.component.UISelectItems,Id: selectItemsId} does not reference an Object of type SelectItem, array, Iterable or Map, but of type: null -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues November 2013