November 2013 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-13371) Refactored Push destroy logic is too aggresive and causes ProgressBar to fail

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13371?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-13371: --------------------------------- I have put a breakpoint into debugger and I can't see this component destroyed more than once or any other issues with the logic. But I will double-check and make sure that the code is properly documented as it's not obvious. > Refactored Push destroy logic is too aggresive and causes ProgressBar to fail > ----------------------------------------------------------------------------- > > Key: RF-13371 > URL: https://issues.jboss.org/browse/RF-13371 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Priority: Critical > Fix For: 5.0.0.Alpha2 > > > From RF-13359: > {quote} > It took a while, but I isolated the single offending line: > https://github.com/richfaces/richfaces/blob/master/framework/src/main/res... > {code} > $(document).on('cleanDom.RICH', function(event, ui) { > if ($.contains(ui.target, widget.element)) { > widget._destroy(); > } > }); > {code} > [~lfryc] It's not clear to me what you are trying to achieve here, but the end result seems to be that the destroy call is too aggressive. Can you re-visit this please? > {panel:title=Note:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#FFFFCE} > The isolation was difficult, as the file in question should have nothing to do with the progressBar component. Hence why the effect was observed only had an effect when included via resource packaging. > {panel} > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13354) Autocomplete: suggestions stay visible after input is cleared

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13354?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-13354: --------------------------------- As we have discussed offline with Brian and Pavol, Autocomplete specifies default value of {{minChars=1}}. This satisfies a behavior that doesn't show suggestion list when {{input.value.length < 1}}. However in Pavol's case, he used {{minChars = 0}} that makes sure auto-completion works even for {{0}} characters in an input. I believe the behavior is correct and compatible with RF 4.3 implementation. > Autocomplete: suggestions stay visible after input is cleared > ------------------------------------------------------------- > > Key: RF-13354 > URL: https://issues.jboss.org/browse/RF-13354 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-input, regression > Affects Versions: 5.0.0.Alpha2 > Environment: RichFaces 5.0.0-SNAPSHOT > Metamer 5.0.0-SNAPSHOT > EAP 6.1.1 > Mojarra 2.1.19 > Java(TM) SE Runtime Environment 1.7.0_04-b20 @ Linux > Chrome 31.0.1650.57 @ Linux x86_64 > Reporter: Pavol Pitonak > Assignee: Lukáš Fryč > Fix For: 5.0.0.Alpha2 > > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > # deploy Metamer and open http://localhost:8080/metamer/faces/components/richAutocomplete/autocompl... > # type "ala" into input (several suggestions will appear) > # clear input, e.g. by using backspace key > result: > * the list with all available suggestions is displayed > * in 4.3.4.Final, the suggestions are *not* displayed when input is empty -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13354) Autocomplete: suggestions stay visible after input is cleared

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13354?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-13354. ----------------------------- Fix Version/s: (was: 5.0.0.Alpha2) Resolution: Rejected > Autocomplete: suggestions stay visible after input is cleared > ------------------------------------------------------------- > > Key: RF-13354 > URL: https://issues.jboss.org/browse/RF-13354 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-input, regression > Affects Versions: 5.0.0.Alpha2 > Environment: RichFaces 5.0.0-SNAPSHOT > Metamer 5.0.0-SNAPSHOT > EAP 6.1.1 > Mojarra 2.1.19 > Java(TM) SE Runtime Environment 1.7.0_04-b20 @ Linux > Chrome 31.0.1650.57 @ Linux x86_64 > Reporter: Pavol Pitonak > Assignee: Lukáš Fryč > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > # deploy Metamer and open http://localhost:8080/metamer/faces/components/richAutocomplete/autocompl... > # type "ala" into input (several suggestions will appear) > # clear input, e.g. by using backspace key > result: > * the list with all available suggestions is displayed > * in 4.3.4.Final, the suggestions are *not* displayed when input is empty -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13374) RichFaces push registered as $.fn.push overrides jQuery function

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13374?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč reassigned RF-13374: ------------------------------- Assignee: Lukáš Fryč > RichFaces push registered as $.fn.push overrides jQuery function > ---------------------------------------------------------------- > > Key: RF-13374 > URL: https://issues.jboss.org/browse/RF-13374 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-push/poll > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Priority: Blocker > Fix For: 5.0.0.Alpha2 > > > The real cause of an issue mentioned in RF-13359 isn't an invalid implementation of _destroy method (RF-13371), but rather conflict caused by registering $.fn.push function. > The solution is to rename that jQuery function, e.g. {{$.fn.richfacespush}} or namespace it in other way (e.g. {{$.fn.rf.push}} - question is how it would be called then). Let's investigate further how we can namespace our jQuery plugins. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13374) RichFaces push registered as $.fn.push overrides jQuery function

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13374?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13374: ---------------------------- Sprint: 5.0.0.Alpha2 - Sprint 6 > RichFaces push registered as $.fn.push overrides jQuery function > ---------------------------------------------------------------- > > Key: RF-13374 > URL: https://issues.jboss.org/browse/RF-13374 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-push/poll > Affects Versions: 5.0.0.Alpha2 > Reporter: Lukáš Fryč > Priority: Blocker > Fix For: 5.0.0.Alpha2 > > > The real cause of an issue mentioned in RF-13359 isn't an invalid implementation of _destroy method (RF-13371), but rather conflict caused by registering $.fn.push function. > The solution is to rename that jQuery function, e.g. {{$.fn.richfacespush}} or namespace it in other way (e.g. {{$.fn.rf.push}} - question is how it would be called then). Let's investigate further how we can namespace our jQuery plugins. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13374) RichFaces push registered as $.fn.push overrides jQuery function

by Lukáš Fryč (JIRA)

Lukáš Fryč created RF-13374: ------------------------------- Summary: RichFaces push registered as $.fn.push overrides jQuery function Key: RF-13374 URL: https://issues.jboss.org/browse/RF-13374 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: component-push/poll Affects Versions: 5.0.0.Alpha2 Reporter: Lukáš Fryč Priority: Blocker Fix For: 5.0.0.Alpha2 The real cause of an issue mentioned in RF-13359 isn't an invalid implementation of _destroy method (RF-13371), but rather conflict caused by registering $.fn.push function. The solution is to rename that jQuery function, e.g. {{$.fn.richfacespush}} or namespace it in other way (e.g. {{$.fn.rf.push}} - question is how it would be called then). Let's investigate further how we can namespace our jQuery plugins. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13359) Showcase: several components don't work

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13359?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on RF-13359: ------------------------------------ With the resolution of RF-13373 the togglePanel now works, but only for the first 2 toggles. On the third toggle a javascript error is thrown: {quote} Uncaught TypeError: Cannot read property 'disabled' of undefined {quote} This error is not present when resource optimisation is disabled. > Showcase: several components don't work > --------------------------------------- > > Key: RF-13359 > URL: https://issues.jboss.org/browse/RF-13359 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Affects Versions: 5.0.0.Alpha2 > Environment: Showcase 5.0.0-SNAPSHOT > Reporter: Pavol Pitonak > Assignee: Brian Leathem > Priority: Blocker > Fix For: 5.0.0.Alpha2 > > Original Estimate: 2 days > Remaining Estimate: 2 days > > # deploy Showcase and open http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=progre... > # open browser console > # click on "Start Process" button > result: > * this message appears in browser console > {quote} > event.returnValue is deprecated. Please use the standard event.preventDefault() instead. > {quote} > * progress bar is rendered wrongly > * the same message is displayed on these pages (and these components are broken too) > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=toggle... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=tabPan... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=accord... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=panelM... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=dragDr... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=hotKey... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=focus&... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13359) Showcase: several components don't work

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13359?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-13359: ------------------------------- Original Estimate: 2 days (was: 1 hour) Remaining Estimate: 2 days (was: 1 hour) > Showcase: several components don't work > --------------------------------------- > > Key: RF-13359 > URL: https://issues.jboss.org/browse/RF-13359 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Affects Versions: 5.0.0.Alpha2 > Environment: Showcase 5.0.0-SNAPSHOT > Reporter: Pavol Pitonak > Assignee: Brian Leathem > Priority: Blocker > Fix For: 5.0.0.Alpha2 > > Original Estimate: 2 days > Remaining Estimate: 2 days > > # deploy Showcase and open http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=progre... > # open browser console > # click on "Start Process" button > result: > * this message appears in browser console > {quote} > event.returnValue is deprecated. Please use the standard event.preventDefault() instead. > {quote} > * progress bar is rendered wrongly > * the same message is displayed on these pages (and these components are broken too) > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=toggle... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=tabPan... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=accord... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=panelM... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=dragDr... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=hotKey... > ** http://localhost:8080/showcase/richfaces/component-sample.jsf?demo=focus&... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13373) The toggle control renderer is not invoked

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13373?page=com.atlassian.jira.plugin.s... ] Brian Leathem resolved RF-13373. -------------------------------- Resolution: Done > The toggle control renderer is not invoked > ------------------------------------------ > > Key: RF-13373 > URL: https://issues.jboss.org/browse/RF-13373 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-output > Affects Versions: 5.0.0.Alpha2 > Reporter: Brian Leathem > Assignee: Brian Leathem > Fix For: 5.0.0.Alpha2 > > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > The toggle control broke because the value returned by the [ToggleControl#getRendererType|https://github.com/richfaces/richfaces/blob...] method does not match the renderer defined in the [@JsfBehavior annotation|https://github.com/richfaces/richfaces/blob/master/framework/s...]. > This descrepency was introduced with this commit: [42fc56|https://github.com/richfaces/richfaces/commit/42fc5626a02a1826e29c...] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

[JBoss JIRA] (RF-13373) The toggle control renderer is not invoked

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-13373?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-13373: ------------------------------- Sprint: 5.0.0.Alpha2 - Sprint 6 > The toggle control renderer is not invoked > ------------------------------------------ > > Key: RF-13373 > URL: https://issues.jboss.org/browse/RF-13373 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-output > Affects Versions: 5.0.0.Alpha2 > Reporter: Brian Leathem > Assignee: Brian Leathem > Fix For: 5.0.0.Alpha2 > > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > The toggle control broke because the value returned by the [ToggleControl#getRendererType|https://github.com/richfaces/richfaces/blob...] method does not match the renderer defined in the [@JsfBehavior annotation|https://github.com/richfaces/richfaces/blob/master/framework/s...]. > This descrepency was introduced with this commit: [42fc56|https://github.com/richfaces/richfaces/commit/42fc5626a02a1826e29c...] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues November 2013