[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12976:
----------------------------
Workaround Description: Use {{@ViewScoped}}
Workaround: Workaround Exists
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-12976:
------------------------------------
This only happens when the tabPanel is using component @binding?
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12976:
---------------------------------
So we have two issues here:
* the use case doesn't work on **Mojarra >={{2.1.18}}**
* the use case doesn't work with **session scope**
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12976:
---------------------------------
The use case in framework tests follows the axis above ^:
however the problem comes when you are switching scope of the bean:
* with RF 4.3.2.Final
** on Mojarra 2.1.17
*** *works* in the view scope (JSF's {{@ManagedBean @ViewScoped}})
*** *doesn't work:* in the session scope (JSF's {{@ManagedBean @SessionScoped}} or CDI's {{@Named @SessionScoped}})
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12977) a4j:queue breaks tabPanel
by Bernard Labno (JIRA)
Bernard Labno created RF-12977:
----------------------------------
Summary: a4j:queue breaks tabPanel
Key: RF-12977
URL: https://issues.jboss.org/browse/RF-12977
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-output
Environment: This happens in RF 4.3.2.CR1, but I can't select such version in JIRA.
Reporter: Bernard Labno
Priority: Critical
There is clearly a bug in tabPanel.js
{code}
execAjax : function (oldPanel, newPanel) {
var options = $.extend({}, newPanel.getTogglePanel().options["ajax"], {});
this.__setActiveItem(newPanel);
rf.ajax(newPanel.id, null, options);
if (oldPanel) { // HERE IS THE BUG
this.__setActiveItem(oldPanel);
}
return false;
},
{code}
If the tab panel works in ajax mode and we attach a4j:queue with requestDelay="1000" then rf.ajax... will just add request to queue, but meanwhile the active item will be changed to old value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-12976 at 5/13/13 10:37 AM:
-----------------------------------------------------------
The use case in Metamer...
* with RF 4.3.1.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
* with RF 4.3.2.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
thus this is issue introduced by Mojarra 2.1.18
was (Author: lfryc):
The use case fine in Metamer...
* with RF 4.3.1.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
* with RF 4.3.2.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
thus this is issue introduced by Mojarra 2.1.18
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12976:
---------------------------------
The use case fine in Metamer...
* with RF 4.3.1.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
* with RF 4.3.2.Final
** *works:* on Mojarra 2.1.7, 2.1.17
** *doesn't work:* on Mojarra 2.1.18, 2.1.19, 2.1.21
thus this is issue introduced by Mojarra 2.1.18
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-12976 at 5/13/13 9:07 AM:
----------------------------------------------------------
The issue is in that {{TogglePanelTagHandler}} calls [{{addItemChangeListener}}|https://github.com/richfaces/richfaces5/blob/master/framework/src/main/java/org/richfaces/ui/toggle/TogglePanelTagHandler.java#L73] method for each build of a view.
It adds {{FacesListener}} to the [{{AttachedObjectListerHolder}}|http://grepcode.com/file/repo1.maven.org/maven2/org.glassfish/javax.faces/2.1.19/javax/faces/component/UIComponentBase.java#892] in {{UIComponentBase}}.
Since the bound UITabPanel is stored in a view scope, the list of listeners grows with each subsequent request for a same view.
----
This issue is larger and each of our event listeners should be checked for a same problem.
was (Author: lfryc):
The issue is in that {{TogglePanelTagHandler}} calls [{{addItemChangeListener}}|https://github.com/richfaces/richfaces5/blob/master/framework/src/main/java/org/richfaces/ui/toggle/TogglePanelTagHandler.java#L73] method for each build of a view.
It adds {{FacesListener}} to the [{{AttachedObjectListerHolder}}|http://grepcode.com/file/repo1.maven.org/maven2/org.glassfish/javax.faces/2.1.19/javax/faces/component/UIComponentBase.java#892] in {{UIComponentBase}}.
Since the bound UITabPanel is stored in a view scope, the list of listeners grows with each subsequent request for a same view.
----
This issue is larger and each of our change listeners should be checked for a same problem.
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months