[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12976:
---------------------------------
The issue is in that {{TogglePanelTagHandler}} calls [{{addItemChangeListener}}|https://github.com/richfaces/richfaces5/blob/master/framework/src/main/java/org/richfaces/ui/toggle/TogglePanelTagHandler.java#L73] method for each build of a view.
It adds {{FacesListener}} to the [{{AttachedObjectListerHolder}}|http://grepcode.com/file/repo1.maven.org/maven2/org.glassfish/javax.faces/2.1.19/javax/faces/component/UIComponentBase.java#892] in {{UIComponentBase}}.
Since the bound UITabPanel is stored in a view scope, the list of listeners grows with each subsequent request for a same view.
----
This issue is larger and each of our change listeners should be checked for a same problem.
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-12976 at 5/13/13 8:33 AM:
----------------------------------------------------------
This isn't regression, I can reproduce this issue with both, {{4.3.0.Final}} and {{4.3.1.Final}}.
The issue can be tracked down to 4.2.x (reproducible with {{4.2.3.Final}}) and 4.1.x (reproducible with {{4.1.0.Final}}).
I have attached a sample which reproduce it.
was (Author: lfryc):
This isn't regression, I can reproduce this issue with both, {{4.3.0.Final}} and {{4.3.1.Final}}.
The issue can be tracked down to 4.2.x (reproducible with {{4.2.3.Final}}).
I have attached a sample which reproduce it.
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-12976 at 5/13/13 8:32 AM:
----------------------------------------------------------
This isn't regression, I can reproduce this issue with both, {{4.3.0.Final}} and {{4.3.1.Final}}.
The issue can be tracked down to 4.2.x (reproducible with {{4.2.3.Final}}).
I have attached a sample which reproduce it.
was (Author: lfryc):
This isn't regression, I can reproduce this issue with both, {{4.3.0.Final}} and {{4.3.1.Final}}.
The issue can be tracked down to 4.2.x (reproducible with {{4.2.3.Final}}).
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
> Attachments: TabPanelBindingTest-4.3.0.Final.war
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12976) rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12976?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12976:
---------------------------------
This isn't regression, I can reproduce this issue with both, {{4.3.0.Final}} and {{4.3.1.Final}}.
The issue can be tracked down to 4.2.x (reproducible with {{4.2.3.Final}}).
> rich:tabPanel using @binding: switching tabs invokes itemChangeListener multiple times
> --------------------------------------------------------------------------------------
>
> Key: RF-12976
> URL: https://issues.jboss.org/browse/RF-12976
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.2
> Environment: Apache Tomcat 7.0.34
> Java(TM) SE Runtime Environment 1.7.0_21-b11 @ Linux
> Firefox 18.0, IE9, IE10, Chrome 24
> Metamer 4.3.2.20130510-Final
> Reporter: Jiří Štefek
> Labels: regression
> Fix For: 4.3.2
>
>
> Regression against RichFaces 4.3.1.Final. (not working in 4.3.2.CR1|Final)
> See steps to reproduce.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12975) rich:extendedDataTable - can not change order of columns
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-12975?page=com.atlassian.jira.plugin.s... ]
Juraj Húska edited comment on RF-12975 at 5/13/13 8:13 AM:
-----------------------------------------------------------
I have verified the fix both on showcase and metamer with RF {{4.3.3-SNAPSHOT}}.
was (Author: jhuska):
I have verified the fix both on showcase and metamer.
> rich:extendedDataTable - can not change order of columns
> --------------------------------------------------------
>
> Key: RF-12975
> URL: https://issues.jboss.org/browse/RF-12975
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.0.Final
> Environment: RichFaces 4.3.2.Final & 4.3.2.CR1
> Chrome 26 & FF 20
> JBoss AS 7.1.1.Final & Tomcat 7
> Reporter: Juraj Húska
> Assignee: Lukáš Fryč
> Fix For: 4.3.2
>
>
> It is not possible to change order of columns for {{rich:extendedDataTable}}.
> There is no JS error, nor error on server side. The partial response is received with 200 OK status.
> * It is also in {{4.3.2.CR1}}.
> * It can be reproduced on both _showcase_ and _metamer_.
> * It is also occurring in {{SNAPSHOT}} version on [openshift|http://showcase.richfaces.org/richfaces/component-sample.jsf?de...].
> * Note that D&D works correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months
[JBoss JIRA] (RF-12975) rich:extendedDataTable - can not change order of columns
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12975?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-12975 at 5/13/13 6:29 AM:
----------------------------------------------------------
The fix was committed to `master` (`4.3.3-SNAPSHOT`), could you please verify it works correctly?
was (Author: lfryc):
The fix was commited to `master` (`4.3.3-SNAPSHOT`), could you please verify it works correctly?
> rich:extendedDataTable - can not change order of columns
> --------------------------------------------------------
>
> Key: RF-12975
> URL: https://issues.jboss.org/browse/RF-12975
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.0.Final
> Environment: RichFaces 4.3.2.Final & 4.3.2.CR1
> Chrome 26 & FF 20
> JBoss AS 7.1.1.Final & Tomcat 7
> Reporter: Juraj Húska
> Assignee: Lukáš Fryč
> Fix For: 4.3.2
>
>
> It is not possible to change order of columns for {{rich:extendedDataTable}}.
> There is no JS error, nor error on server side. The partial response is received with 200 OK status.
> * It is also in {{4.3.2.CR1}}.
> * It can be reproduced on both _showcase_ and _metamer_.
> * It is also occurring in {{SNAPSHOT}} version on [openshift|http://showcase.richfaces.org/richfaces/component-sample.jsf?de...].
> * Note that D&D works correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 10 months