[JBoss JIRA] (RF-13459) Google map doesn't work because of stack overflow
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13459?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-13459.
--------------------------------
Labels: needs-qe (was: )
Assignee: Brian Leathem
Fix Version/s: 3.3.1.SP4
Resolution: Done
Updated the gmap component to use the v3 maps API. Also update the API key used in the showcase demo.
The facelet api is expected to be preserved, however the client-side javascript API in the showcase demo invoked the google API directly. This javascript API has changed, and the showcase demo updated to show the new API.
Note: the v2 API is no longer available from google, so we have no choice but to follow suit.
> Google map doesn't work because of stack overflow
> -------------------------------------------------
>
> Key: RF-13459
> URL: https://issues.jboss.org/browse/RF-13459
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-misc
> Affects Versions: 3.3.1.SP3, 3.3.4.Final
> Reporter: Pavol Pitonak
> Assignee: Brian Leathem
> Labels: needs-qe
> Fix For: 3.3.1.SP4
>
>
> # open http://showcase-rf3.richfaces.org/richfaces/gmap.jsf?c=gmap&tab=usage in Chrome 31, IE7/8/9
> result:
> * map is rendered for a second but that it disappear and popup with stack overflow error is displayed
> * this is in browser console:
> {code}
> Uncaught RangeError: Maximum call stack size exceeded %7Bmain,adsense,geometry,zombie%7D.js:11
> {code}
> * there are several warnings in browser console but I'm not sure if they are somehow related:
> {code}
> Map.disableContinuousZoom is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> Control is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> Map.addControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> ScaleControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13459) Google map doesn't work because of stack overflow
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13459?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13459:
------------------------------------
The error comes from an invalid API key. The warnings come from use of the deprecated google maps v2 API.
Instructions on upgrading to use the google maps API v3:
https://developers.google.com/maps/documentation/javascript/v2/v2tov3
> Google map doesn't work because of stack overflow
> -------------------------------------------------
>
> Key: RF-13459
> URL: https://issues.jboss.org/browse/RF-13459
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-misc
> Affects Versions: 3.3.1.SP3, 3.3.4.Final
> Reporter: Pavol Pitonak
>
> # open http://showcase-rf3.richfaces.org/richfaces/gmap.jsf?c=gmap&tab=usage in Chrome 31, IE7/8/9
> result:
> * map is rendered for a second but that it disappear and popup with stack overflow error is displayed
> * this is in browser console:
> {code}
> Uncaught RangeError: Maximum call stack size exceeded %7Bmain,adsense,geometry,zombie%7D.js:11
> {code}
> * there are several warnings in browser console but I'm not sure if they are somehow related:
> {code}
> Map.disableContinuousZoom is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> Control is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> Map.addControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> ScaleControl is no longer supported in the Google Maps Javascript API v2. Please visit https://developers.google.com/maps/documentation/javascript/v2/v2tov3 to migrate your application to v3. %7Bmain,adsense,geometry,zombie%7D.js:66
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13492) Photoalbum: cancel selection in other r:trees when browsing an album navigation panel
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13492?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13492:
---------------------------------
I don§t think we need to collapse it, just reset a selection.
The selection will need to be bound to model and re-set there I guess.
> Photoalbum: cancel selection in other r:trees when browsing an album navigation panel
> -------------------------------------------------------------------------------------
>
> Key: RF-13492
> URL: https://issues.jboss.org/browse/RF-13492
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Reporter: Lukáš Fryč
> Labels: photoalbum
> Attachments: screenshot02.png
>
>
> When we have several album categories opened, we can select a current album from each of them.
> Only one is an opened one (visible in the main page content area), but the r:tree components show current selection for each album shelf separately.
> Look at the attached screenshot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13317) ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13317?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13317:
---------------------------------
The only approach I can think about ATM is leveraging non-specified implementation-dependent {{#getViewStateId()}} method.
> ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
> -----------------------------------------------------------------------------------------------
>
> Key: RF-13317
> URL: https://issues.jboss.org/browse/RF-13317
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.4
> Environment: Wildfly-8.0.0.Beta1, jsf-impl-2.2.3-jbossorg-1
> Reporter: Matti Bickel
> Assignee: Lukáš Fryč
> Priority: Critical
> Labels: jsf22
> Fix For: 5.0.0.Alpha3
>
>
> I'm using several {{<rich:autocomplete>}} fields in a {{<h:form>}}, but have noticed the issue with several other AJAX requests:
> When the response comes back, the data is fine but I get a JSF error saying
> bq. During update: javax.faces.ViewState not found
> Following that, no componentData is available to the Autocomplete component and no suggestions get displayed.
> For reference the [javadoc for ResponseStateManager.VIEW_STATE_PARAM|https://javaserverfaces.java.net/no...] says:
> {quote}
> Implementations must use this constant field value as the name of the client parameter in which to save the state between requests. The id attribute must be a concatenation of the return from UIComponent.getContainerClientId(javax.faces.context.FacesContext), the return from UINamingContainer.getSeparatorChar(javax.faces.context.FacesContext), this constant field value, the separator char, and a number that is guaranteed to be unique with respect to all the other instances of this kind of client parameter in the view.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13317) ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13317?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13317:
---------------------------------
We have discussed following refactoring with Brian:
* we won't rewrite {{PartialViewContextImpl#processPartial()}} implementation and we will use vanilla JSF implementation here.
* we used our impl for 2 reasons:
** extended partial tree visitor + extended partial visit context
*** for meta-component rendering ({{MetaComponentEncoder}})
*** and implicit area rendering ({{AjaxOutput}} with {{#isAjaxRendered() == true}})
** rendering javascripts and custom partial response extensions
Unfortunately this approach isn't possible as we are not able to instruct JSF visitor that it should visit components that contains meta-component. Therefore the encode* methods aren't visited during a tree traversal and so no components gets rendered.
> ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
> -----------------------------------------------------------------------------------------------
>
> Key: RF-13317
> URL: https://issues.jboss.org/browse/RF-13317
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.4
> Environment: Wildfly-8.0.0.Beta1, jsf-impl-2.2.3-jbossorg-1
> Reporter: Matti Bickel
> Assignee: Lukáš Fryč
> Priority: Critical
> Labels: jsf22
> Fix For: 5.0.0.Alpha3
>
>
> I'm using several {{<rich:autocomplete>}} fields in a {{<h:form>}}, but have noticed the issue with several other AJAX requests:
> When the response comes back, the data is fine but I get a JSF error saying
> bq. During update: javax.faces.ViewState not found
> Following that, no componentData is available to the Autocomplete component and no suggestions get displayed.
> For reference the [javadoc for ResponseStateManager.VIEW_STATE_PARAM|https://javaserverfaces.java.net/no...] says:
> {quote}
> Implementations must use this constant field value as the name of the client parameter in which to save the state between requests. The id attribute must be a concatenation of the return from UIComponent.getContainerClientId(javax.faces.context.FacesContext), the return from UINamingContainer.getSeparatorChar(javax.faces.context.FacesContext), this constant field value, the separator char, and a number that is guaranteed to be unique with respect to all the other instances of this kind of client parameter in the view.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13317) ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13317?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13317 at 1/15/14 2:50 PM:
----------------------------------------------------------
We have discussed following refactoring with Brian:
* we won't rewrite {{PartialViewContextImpl#processPartial()}} implementation and we will use vanilla JSF implementation here.
* we used our impl for 2 reasons:
** extended partial tree visitor + extended partial visit context
*** for meta-component rendering ({{MetaComponentEncoder}})
*** and implicit area rendering ({{AjaxOutput}} with {{#isAjaxRendered() == true}})
** rendering javascripts and custom partial response extensions
Unfortunately this approach isn't possible as we are not able to instruct JSF visitor that it should visit components that contains meta-component. Therefore the encode* methods aren't visited during a tree traversal and so no meta-components gets rendered.
was (Author: lfryc):
We have discussed following refactoring with Brian:
* we won't rewrite {{PartialViewContextImpl#processPartial()}} implementation and we will use vanilla JSF implementation here.
* we used our impl for 2 reasons:
** extended partial tree visitor + extended partial visit context
*** for meta-component rendering ({{MetaComponentEncoder}})
*** and implicit area rendering ({{AjaxOutput}} with {{#isAjaxRendered() == true}})
** rendering javascripts and custom partial response extensions
Unfortunately this approach isn't possible as we are not able to instruct JSF visitor that it should visit components that contains meta-component. Therefore the encode* methods aren't visited during a tree traversal and so no components gets rendered.
> ExtendedPartialViewContextImpl should specify correct javax.faces.ViewState id in startUpdate()
> -----------------------------------------------------------------------------------------------
>
> Key: RF-13317
> URL: https://issues.jboss.org/browse/RF-13317
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.4
> Environment: Wildfly-8.0.0.Beta1, jsf-impl-2.2.3-jbossorg-1
> Reporter: Matti Bickel
> Assignee: Lukáš Fryč
> Priority: Critical
> Labels: jsf22
> Fix For: 5.0.0.Alpha3
>
>
> I'm using several {{<rich:autocomplete>}} fields in a {{<h:form>}}, but have noticed the issue with several other AJAX requests:
> When the response comes back, the data is fine but I get a JSF error saying
> bq. During update: javax.faces.ViewState not found
> Following that, no componentData is available to the Autocomplete component and no suggestions get displayed.
> For reference the [javadoc for ResponseStateManager.VIEW_STATE_PARAM|https://javaserverfaces.java.net/no...] says:
> {quote}
> Implementations must use this constant field value as the name of the client parameter in which to save the state between requests. The id attribute must be a concatenation of the return from UIComponent.getContainerClientId(javax.faces.context.FacesContext), the return from UINamingContainer.getSeparatorChar(javax.faces.context.FacesContext), this constant field value, the separator char, and a number that is guaranteed to be unique with respect to all the other instances of this kind of client parameter in the view.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13491) Photoalbum: allow to use hotkeys for switching between image details in an album
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13491?page=com.atlassian.jira.plugin.s... ]
Michal Petrov commented on RF-13491:
------------------------------------
I've implemented this but I'm encountering a strange error with datascroller/repeat. See the images:
# I am pressing the right arrow to go to the next image
# everything's ok, the grid shows the correct image being selected
# the repeat should have rendered the next page, notice the second page is selected on the datascroller
# this is the second page, one step too late; because {{3}} was the last image, we're now back at first page
# now at second image of the first page
I am not sure what's happening. {{\@page}} and {{\@first}} are resolved correctly.
> Photoalbum: allow to use hotkeys for switching between image details in an album
> --------------------------------------------------------------------------------
>
> Key: RF-13491
> URL: https://issues.jboss.org/browse/RF-13491
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Reporter: Lukáš Fryč
> Priority: Optional
> Labels: photoalbum
> Attachments: 1.png, 2.png, 3.png, 4.png, 5.png
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months