[JBoss JIRA] (RF-13227) Prepare the RichFaces 4.3.x photoalbum for release
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13227?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13227 at 1/15/14 9:48 AM:
----------------------------------------------------------
My review:
* --doesn’t work from JBDS (even when the `release` profile is enabled)--
** --the packed.css resource is not found--
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* --Click on monuments -> {{[]}} appears in the left bottom corner (some debugging thing?)--
* back-space returns us to the previous page (should we handle that?)
* --Facebook login - “Error: User cancelled login or did not fully authorize.”--
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* --browser console inspection--
** --Uncaught TypeError: Cannot call method 'show' of null--
*** --when switching from one tree node to another (quickly)--
* --What is a purpose of a "What is this" (“?”) link in the header?--
was (Author: lfryc):
My review:
* --doesn’t work from JBDS (even when the `release` profile is enabled)--
** --the packed.css resource is not found--
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* --Click on monuments -> {{[]}} appears in the left bottom corner (some debugging thing?)--
* back-space returns us to the previous page (should we handle that?)
* --Facebook login - “Error: User cancelled login or did not fully authorize.”--
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* --browser console inspection--
** --Uncaught TypeError: Cannot call method 'show' of null --
*** --when switching from one tree node to another (quickly)--
* --What is a purpose of a "What is this" (“?”) link in the header?--
> Prepare the RichFaces 4.3.x photoalbum for release
> --------------------------------------------------
>
> Key: RF-13227
> URL: https://issues.jboss.org/browse/RF-13227
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.3.5
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Review the photoalbum example application addressing any usability issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13227) Prepare the RichFaces 4.3.x photoalbum for release
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13227?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13227 at 1/15/14 9:46 AM:
----------------------------------------------------------
My review:
* --doesn’t work from JBDS (even when the `release` profile is enabled)--
** --the packed.css resource is not found--
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* --Click on monuments -> {{[]}} appears in the left bottom corner (some debugging thing?)--
* back-space returns us to the previous page (should we handle that?)
* --Facebook login - “Error: User cancelled login or did not fully authorize.”--
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* --browser console inspection--
** --Uncaught TypeError: Cannot call method 'show' of null --
*** --when switching from one tree node to another (quickly)--
* --What is a purpose of a "What is this" (“?”) link in the header?--
was (Author: lfryc):
My review:
* --doesn’t work from JBDS (even when the `release` profile is enabled)--
** --the packed.css resource is not found--
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* --Click on monuments -> {[]} appears in the left bottom corner (some debugging thing?)--
* back-space returns us to the previous page (should we handle that?)
* --Facebook login - “Error: User cancelled login or did not fully authorize.”--
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* --browser console inspection--
** --Uncaught TypeError: Cannot call method 'show' of null --
*** --when switching from one tree node to another (quickly)--
* --What is a purpose of a "What is this" (“?”) link in the header?--
> Prepare the RichFaces 4.3.x photoalbum for release
> --------------------------------------------------
>
> Key: RF-13227
> URL: https://issues.jboss.org/browse/RF-13227
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.3.5
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Review the photoalbum example application addressing any usability issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13227) Prepare the RichFaces 4.3.x photoalbum for release
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13227?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč edited comment on RF-13227 at 1/15/14 9:46 AM:
----------------------------------------------------------
My review:
* --doesn’t work from JBDS (even when the `release` profile is enabled)--
** --the packed.css resource is not found--
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* --Click on monuments -> {[]} appears in the left bottom corner (some debugging thing?)--
* back-space returns us to the previous page (should we handle that?)
* --Facebook login - “Error: User cancelled login or did not fully authorize.”--
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* --browser console inspection--
** --Uncaught TypeError: Cannot call method 'show' of null --
*** --when switching from one tree node to another (quickly)--
* --What is a purpose of a "What is this" (“?”) link in the header?--
was (Author: lfryc):
My review:
* doesn’t work from JBDS (even when the `release` profile is enabled)
** the packed.css resources is not found
* popups (e.g. login, image details, add album, ..)
** the styling of popups doesn’t look nice
* G+ albums
** slideshow/start-slideshow/original size doesn’t work
* The photoalbum doesn’t differentiate between G+ albums and My albums
* Click on monuments -> {[]} appears in the left bottom corner (some debugging thing?)
* back-space returns us to the previous page (should we handle that?)
* Facebook login - “Error: User cancelled login or did not fully authorize.”
* we are able to select from Events and Public album groups simultaneously - (it isn't obvious what's actually selected)
* we could use hotkeys for switching photos in series
* browser console inspection
** Uncaught TypeError: Cannot call method 'show' of null
*** when switching from one tree node to another (quickly)
* What is a purpose of a "What is this" (“?”) link in the header?
> Prepare the RichFaces 4.3.x photoalbum for release
> --------------------------------------------------
>
> Key: RF-13227
> URL: https://issues.jboss.org/browse/RF-13227
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.3.5
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Review the photoalbum example application addressing any usability issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13488) Photoalbum: facebook login - User cancelled login or did not fully authorize.
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13488?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-13488:
----------------------------
Environment: Chrome 31, Firefox 26
> Photoalbum: facebook login - User cancelled login or did not fully authorize.
> -----------------------------------------------------------------------------
>
> Key: RF-13488
> URL: https://issues.jboss.org/browse/RF-13488
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Environment: Chrome 31, Firefox 26
> Reporter: Lukáš Fryč
> Assignee: Michal Petrov
> Labels: photoalbum
> Attachments: screenshot01.png
>
>
> Steps to reproduce:
> 1. without being logged into Facebook account
> 2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
> 3. click Login
> 4. click Facebook logo to log into
> 5. type the Facebook credentials
> FAIL: following error appears:
> {code}
> User cancelled login or did not fully authorize
> {code}
> (Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
> I can see no errors in browser console or server console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13358) rich:panelMenuGroup allowing actions executions even if originally disabled
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13358?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak reopened RF-13358:
--------------------------------
I added a reproducer to Metamer (http://localhost:8080/metamer/faces/components/richPanelMenu/rf13358.xhtml).
Works fine in 4.3.5-SNAPSHOT and 5.0.0-SNAPSHOT.
Action and action listener are still invoked in 4.5.0-SNAPSHOT.
> rich:panelMenuGroup allowing actions executions even if originally disabled
> ---------------------------------------------------------------------------
>
> Key: RF-13358
> URL: https://issues.jboss.org/browse/RF-13358
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-menu
> Affects Versions: 4.3.4
> Environment: Linux, AS 7.1.1 Brontes, FF 25 with FireBug addOn
> Reporter: Pavel Slegr
> Assignee: Brian Leathem
> Priority: Critical
> Labels: needs-qe
> Fix For: 4.3.5, 4.5.0.Alpha2, 5.0.0.Alpha3
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> related to https://issues.jboss.org/browse/RF-12813
> This can be possibly a security hole, as the second component piece is discovered to allow tampering actions through JS.
> I suggest to try out on other components as well !!!
> with following example
> {code}
> {
> <rich:panelMenuGroup id="group4" label="Group 4" expanded="false">
> <rich:panelMenuItem id="item41" label="Item 4.1" />
> <rich:panelMenuItem id="item42" label="Item 4.2" disabled="true" />
> <rich:panelMenuGroup id="group43" label="Group 4.1" disabled="true">
> <rich:panelMenuItem id="item431" label="Item 4.1.1" />
> </rich:panelMenuGroup>
> </rich:panelMenuGroup>
> }
> {code}
> the group43 element is intended to be disabled and thus not allowing any actions execution on it
> Once tampered with
> {code}
> {
> new RichFaces.ui.PanelMenuGroup("f:group43",{"collapseEvent":"click","unselectable":false,"selectable":false,"name":"group43","ajax":{"incId":"1"} ,"stylePrefix":"rf\u002Dpm\u002Dgr","expanded":false,"expandEvent":"click","disabled":false,"mode":"client"} )
> }
> {code}
> It is possible to expand the group and execute further actions on its children elements
> NOTE: to verify this in RF 4.5 the JS function is: _new RichFaces.rf4.ui....._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13488) Photoalbum: facebook login - User cancelled login or did not fully authorize.
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13488?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-13488:
----------------------------
Environment:
Chrome 31, Firefox 26
JBoss EAP 6.1.1.GA
was:Chrome 31, Firefox 26
> Photoalbum: facebook login - User cancelled login or did not fully authorize.
> -----------------------------------------------------------------------------
>
> Key: RF-13488
> URL: https://issues.jboss.org/browse/RF-13488
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Environment: Chrome 31, Firefox 26
> JBoss EAP 6.1.1.GA
> Reporter: Lukáš Fryč
> Assignee: Michal Petrov
> Labels: photoalbum
> Attachments: screenshot01.png
>
>
> Steps to reproduce:
> 1. without being logged into Facebook account
> 2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
> 3. click Login
> 4. click Facebook logo to log into
> 5. type the Facebook credentials
> FAIL: following error appears:
> {code}
> User cancelled login or did not fully authorize
> {code}
> (Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
> I can see no errors in browser console or server console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13488) Photoalbum: facebook login - User cancelled login or did not fully authorize.
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13488?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-13488:
----------------------------
Description:
Steps to reproduce:
1. without being logged into Facebook account
2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
3. click Login
4. click Facebook logo to log into
5. type the Facebook credentials
FAIL: following error appears
(Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
I can see no errors in browser console or server console.
was:
Steps to reproduce:
1. without being logged into Facebook account
2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
3. click Login
4. click Facebook logo to log into
(Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
I can see no errors in browser console or server console.
> Photoalbum: facebook login - User cancelled login or did not fully authorize.
> -----------------------------------------------------------------------------
>
> Key: RF-13488
> URL: https://issues.jboss.org/browse/RF-13488
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Reporter: Lukáš Fryč
> Assignee: Michal Petrov
> Labels: photoalbum
> Attachments: screenshot01.png
>
>
> Steps to reproduce:
> 1. without being logged into Facebook account
> 2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
> 3. click Login
> 4. click Facebook logo to log into
> 5. type the Facebook credentials
> FAIL: following error appears
> (Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
> I can see no errors in browser console or server console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months
[JBoss JIRA] (RF-13488) Photoalbum: facebook login - User cancelled login or did not fully authorize.
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13488?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-13488:
----------------------------
Description:
Steps to reproduce:
1. without being logged into Facebook account
2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
3. click Login
4. click Facebook logo to log into
5. type the Facebook credentials
FAIL: following error appears:
{code}
User cancelled login or did not fully authorize
{code}
(Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
I can see no errors in browser console or server console.
was:
Steps to reproduce:
1. without being logged into Facebook account
2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
3. click Login
4. click Facebook logo to log into
5. type the Facebook credentials
FAIL: following error appears
(Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
I can see no errors in browser console or server console.
> Photoalbum: facebook login - User cancelled login or did not fully authorize.
> -----------------------------------------------------------------------------
>
> Key: RF-13488
> URL: https://issues.jboss.org/browse/RF-13488
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: examples
> Affects Versions: 4.3.5
> Reporter: Lukáš Fryč
> Assignee: Michal Petrov
> Labels: photoalbum
> Attachments: screenshot01.png
>
>
> Steps to reproduce:
> 1. without being logged into Facebook account
> 2. open Photoalbum app: http://localhost:8080/richfaces-photoalbum/
> 3. click Login
> 4. click Facebook logo to log into
> 5. type the Facebook credentials
> FAIL: following error appears:
> {code}
> User cancelled login or did not fully authorize
> {code}
> (Note: I had to disable popup blocking for that page, but it doesn't work though. I repeated steps above after disabling popups.)
> I can see no errors in browser console or server console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 3 months