1:13 p.m.
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone1
Attachments: generator.patch.zip
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://jira.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov updated RF-8898:
----------------------------------
Attachment: generator.patch.zip
Proposed patch from forum.
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone1
Attachments: generator.patch.zip
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://jira.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.syst...
]
Bernard Labno updated RF-8898:
------------------------------
Attachment: keywordAttributes.patch
Here is another patch. Attribute names get "Key" suffix in generated code.
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone1
Attachments: generator.patch.zip, keywordAttributes.patch
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:07 p.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://jira.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.syst...
]
Alexander Smirnov updated RF-8898:
----------------------------------
Fix Version/s: 4.0.0.Milestone2
(was: 4.0.0.Milestone1)
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: generator.patch.zip, keywordAttributes.patch
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:25 a.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://jira.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.syst...
]
Bernard Labno updated RF-8898:
------------------------------
Attachment: keywordAttributes2.patch
Alex, my patch is a disaster! If we use any suffix, then ComponentStateHelper will (if we
do not specify direct value, but a binding) delegate evaluation to UIComponent, and it is
set by default facelet handlers accordingly to attribute name:
public Object eval(Serializable key, Object defaultValue) {
Object retVal = get(key);
if (retVal == null) {
ValueExpression ve = component.getValueExpression(key.toString());
if (ve != null) {
retVal = ve.getValue(component.getFacesContext().getELContext());
}
}
return ((retVal != null) ? retVal : defaultValue);
}
Either we abandon this path or cut suffix in generated Properties enum in it's
toString().
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: 4.0.0.Milestone2
Attachments: generator.patch.zip, keywordAttributes.patch,
keywordAttributes2.patch
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:44 a.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://jira.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.syst...
]
Jay Balunas updated RF-8898:
----------------------------
Fix Version/s: Future_4.X
(was: 4.0.0.Milestone2)
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://jira.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CDK
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: generator.patch.zip, keywordAttributes.patch,
keywordAttributes2.patch
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:06 p.m.
New subject: [JBoss JIRA] Resolved: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://issues.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.sy...
]
Alexander Smirnov resolved RF-8898.
-----------------------------------
Resolution: Done
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://issues.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: generator.patch.zip, keywordAttributes.patch,
keywordAttributes2.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:06 p.m.
New subject: [JBoss JIRA] Updated: (RF-8898) CDK could generate object names that conflict with Java keywords.
[
https://issues.jboss.org/browse/RF-8898?page=com.atlassian.jira.plugin.sy...
]
Alexander Smirnov updated RF-8898:
----------------------------------
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
CDK could generate object names that conflict with Java keywords.
-----------------------------------------------------------------
Key: RF-8898
URL: https://issues.jboss.org/browse/RF-8898
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: cdk
Reporter: Alexander Smirnov
Assignee: Alexander Smirnov
Fix For: Future_4.X
Attachments: generator.patch.zip, keywordAttributes.patch,
keywordAttributes2.patch
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
CDK creates enum for attributes referenced in the property getters/setters. If attribute
name coincides with Java keyword, generated Java class couldn't be compiled.
Mojarra uses a little bit more complicated enum class for these cases, so CDK has to do
the same:
enum PropertyKeys {
forValue("for"),
showDetail,
showSummary,
redisplay;
String toString;
PropertyKeys(String toString) {
this.toString = toString;
}
PropertyKeys() {
}
public String toString() {
return ((this.toString != null) ? this.toString : super.toString());
}
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5069
days inactive
5256
days old
richfaces-issues@lists.jboss.org
7 comments
3 participants
participants (3)
-
Alexander Smirnov (JIRA) -
Bernard Labno (JIRA)
-
Jay Balunas (JIRA)